Skip to content

Conversation

@sairameshv
Copy link
Member

Manual back port of #1428

  • cgroupv1 has been removed from ocp > 4.19
  • Hence, the CgroupModeV1 constant can be safely removed from the api code

- cgroupv1 has been removed from ocp > 4.19
- Hence, the CgroupModeV1 constant can be safely removed from the api
  code

Signed-off-by: Sai Ramesh Vanka <[email protected]>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 26, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 26, 2025

@sairameshv: This pull request references OCPNODE-3883 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.20." or "openshift-4.20.", but it targets "openshift-4.21" instead.

In response to this:

Manual back port of #1428

  • cgroupv1 has been removed from ocp > 4.19
  • Hence, the CgroupModeV1 constant can be safely removed from the api code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from MarSik and swatisehgal November 26, 2025 12:25
@MarSik
Copy link
Contributor

MarSik commented Nov 26, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik, sairameshv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2025
@sairameshv
Copy link
Member Author

sairameshv commented Nov 26, 2025

/label jira/valid-bug
/label backport-risk-assessed

I don't know if this can be considered as a bug as it is not breaking any existing functionality but a good to have change to remove the unused code for better maintainability
Hence, added jira/valid-bug, backport-risk-assessed labels

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 26, 2025

@sairameshv: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn 0fcad19 link true /test e2e-aws-ovn
ci/prow/e2e-hypershift 0fcad19 link true /test e2e-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants