Bug 1775838: Back-port, OVNKubernetes: introduce OVS anti-selector by alexanderConstantinescu · Pull Request #492 · openshift/cluster-network-operator

alexanderConstantinescu · 2020-02-24T16:01:31Z

/hold

While waiting for PR: #483 to get in

OVNKubernetes is shipped with its own openvswitch service running
as a separate daemonset. However, in some cases we may want to use
an external openvswitch running on the host (e.g. to use it for
host networking). In order to support a mixed environment where some
hosts have this external service and some don't, we introduce an
openvswitch anti-selector:

network.operator.openshift.io/external-openvswitch

Note that this selector has to be set before the operator is started.
Otherwise, the label would not take effect on already scheduled
pods.

openshift-ci-robot · 2020-02-24T16:01:34Z

@alexanderConstantinescu: This pull request references Bugzilla bug 1806591, which is invalid:

expected the bug to target the "4.3.z" release, but it targets "4.5.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead
expected Bugzilla bug 1806591 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1806591: Back-port, OVNKubernetes: introduce OVS anti-selector

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alexanderConstantinescu · 2020-02-24T16:02:42Z

/retitle Bug 1775838: Back-port, OVNKubernetes: introduce OVS anti-selector

openshift-ci-robot · 2020-02-24T16:03:48Z

@alexanderConstantinescu: This pull request references Bugzilla bug 1775838, which is invalid:

expected dependent Bugzilla bug 1806591 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1775838: Back-port, OVNKubernetes: introduce OVS anti-selector

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alexanderConstantinescu · 2020-02-24T16:06:59Z

/cc @mmirecki @nellyc
/assign @danwinship

alexanderConstantinescu · 2020-02-25T12:51:34Z

/test e2e-gcp-ovn
/test e2e-aws-ovn

alexanderConstantinescu · 2020-02-27T12:45:24Z

Now that the 4.3 back-port is in

/hold cancel

alexanderConstantinescu · 2020-03-09T10:03:56Z

/bugzilla refresh

openshift-ci-robot · 2020-03-09T10:04:00Z

@alexanderConstantinescu: This pull request references Bugzilla bug 1775838, which is invalid:

expected dependent Bugzilla bug 1806591 to target the "4.4.0" release, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alexanderConstantinescu · 2020-03-09T10:07:02Z

/bugzilla refresh

openshift-ci-robot · 2020-03-09T10:07:12Z

@alexanderConstantinescu: This pull request references Bugzilla bug 1775838, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1806591 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1806591 targets the "4.4.0" release, matching the expected (4.4.0) release
bug has dependents

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alexanderConstantinescu · 2020-03-11T16:02:37Z

@danwinship PTAL: this is a back-port of #357 which did not make it to 4.3 in time

bindata/network/ovn-kubernetes/006-ovs-node.yaml

alexanderConstantinescu · 2020-03-26T20:12:32Z

/test e2e-gcp-upgrade

plus

I addressed your comments @danwinship, PTAL again

danwinship

just one nit, then please squash to a single commit

bindata/network/ovn-kubernetes/006-ovs-node.yaml

OVNKubernetes is shipped with its own openvswitch service running as a separate daemonset. However, in some cases we may want to use an external openvswitch running on the host (e.g. to use it for host networking). In order to support a mixed environment where some hosts have this external service and some don't, we introduce an openvswitch anti-selector: network.operator.openshift.io/external-openvswitch Note that this selector has to be set before the operator is started. Otherwise, the label would not take effect on already scheduled pods. Fixing compatibility issues with 4.3

alexanderConstantinescu · 2020-04-01T22:26:20Z

just one nit, then please squash to a single commit

Done and done.

danwinship · 2020-04-02T14:22:27Z

/lgtm

openshift-ci-robot · 2020-04-02T14:23:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderConstantinescu, danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [danwinship]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

eparis · 2020-04-16T03:31:05Z

/bugzilla refresh

openshift-ci-robot · 2020-04-16T03:31:08Z

@eparis: This pull request references Bugzilla bug 1775838, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1806591 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1806591 targets the "4.4.0" release, which is one of the valid target releases: 4.4.0, 4.4.z
bug has dependents

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-04-18T20:14:55Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-18T22:47:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-19T01:23:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-19T03:59:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-19T04:12:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-04-19T05:16:11Z

@alexanderConstantinescu: All pull requests linked via external trackers have merged: openshift/cluster-network-operator#492. Bugzilla bug 1775838 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1775838: Back-port, OVNKubernetes: introduce OVS anti-selector

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2020

openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 24, 2020

openshift-ci-robot requested review from danwinship and dcbw February 24, 2020 16:03

openshift-ci-robot changed the title ~~Bug 1806591: Back-port, OVNKubernetes: introduce OVS anti-selector~~ Bug 1775838: Back-port, OVNKubernetes: introduce OVS anti-selector Feb 24, 2020

openshift-ci-robot assigned danwinship Feb 24, 2020

openshift-ci-robot requested review from mmirecki and nellyc February 24, 2020 16:07

openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 27, 2020

alexanderConstantinescu force-pushed the backport/1806591 branch from 5890cbf to b88ab17 Compare February 27, 2020 12:50

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 9, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 9, 2020

danwinship requested changes Mar 17, 2020

View reviewed changes

bindata/network/ovn-kubernetes/006-ovs-node.yaml Outdated Show resolved Hide resolved

bindata/network/ovn-kubernetes/006-ovs-node.yaml Show resolved Hide resolved

alexanderConstantinescu force-pushed the backport/1806591 branch from 7f8c099 to 42b551d Compare March 18, 2020 13:49

danwinship reviewed Apr 1, 2020

View reviewed changes

bindata/network/ovn-kubernetes/006-ovs-node.yaml Outdated Show resolved Hide resolved

alexanderConstantinescu force-pushed the backport/1806591 branch from 42b551d to 0e9379b Compare April 1, 2020 22:25

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2020

eparis added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 16, 2020

openshift-merge-robot merged commit 932b28a into openshift:release-4.3 Apr 19, 2020

Conversation

alexanderConstantinescu commented Feb 24, 2020

Uh oh!

openshift-ci-robot commented Feb 24, 2020

Uh oh!

alexanderConstantinescu commented Feb 24, 2020

Uh oh!

openshift-ci-robot commented Feb 24, 2020

Uh oh!

alexanderConstantinescu commented Feb 24, 2020

Uh oh!

alexanderConstantinescu commented Feb 25, 2020

Uh oh!

alexanderConstantinescu commented Feb 27, 2020

Uh oh!

alexanderConstantinescu commented Mar 9, 2020

Uh oh!

openshift-ci-robot commented Mar 9, 2020

Uh oh!

alexanderConstantinescu commented Mar 9, 2020

Uh oh!

openshift-ci-robot commented Mar 9, 2020

Uh oh!

alexanderConstantinescu commented Mar 11, 2020

Uh oh!

Uh oh!

Uh oh!

alexanderConstantinescu commented Mar 26, 2020

Uh oh!

danwinship left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alexanderConstantinescu commented Apr 1, 2020

Uh oh!

danwinship commented Apr 2, 2020

Uh oh!

openshift-ci-robot commented Apr 2, 2020

Uh oh!

eparis commented Apr 16, 2020

Uh oh!

openshift-ci-robot commented Apr 16, 2020

Uh oh!

openshift-bot commented Apr 18, 2020

Uh oh!

openshift-bot commented Apr 18, 2020

Uh oh!

openshift-bot commented Apr 19, 2020

Uh oh!

openshift-bot commented Apr 19, 2020

Uh oh!

openshift-bot commented Apr 19, 2020

Uh oh!

openshift-ci-robot commented Apr 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants