Bug 1803701: Back-port changing OVN DB readinessProbe to check membership status instead of …

[alexanderConstantinescu]

Backport of #466 to 4.3

[openshift-ci-robot]

@alexanderConstantinescu: This pull request references Bugzilla bug 1803701, which is invalid:

• expected dependent Bugzilla bug 1803697 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1803701: Back-port changing OVN DB readinessProbe to check membership status instead of …

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alexanderConstantinescu
To complete the pull request process, please assign squeed
You can assign the PR to them by writing /assign @squeed in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@alexanderConstantinescu: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp-upgrade	76106c7	link	/test e2e-gcp-upgrade
ci/prow/e2e-gcp	76106c7	link	/test e2e-gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dcbw]

/bugzilla refresh

[openshift-ci-robot]

@dcbw: This pull request references Bugzilla bug 1803701, which is invalid:

• expected dependent Bugzilla bug 1803697 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[danwinship]

covered by #483

[alexanderConstantinescu]

@danwinship : that back-port does not contain the patch I am proposing in this PR. Please make sure to include this in that PR. We could also re-open this PR and make sure to merge it after you've managed to merge that back-port? As you prefer.

EDIT: to be more precise, that back-port PR contains the old readinessProbe @dcbw implemented:

exec ${APPCTL_PATH} -t ${DB_SOCK_PATH} ovsdb-server/sync-status

We should change that to:

exec ${APPCTL_PATH} -t ${DB_SOCK_PATH} cluster/status OVN_Southbound 2>/dev/null | grep ${K8S_NODE_IP} | grep -v Address -q

As done here: https://github.com/openshift/cluster-network-operator/pull/466/files