Skip to content

Bug 1796616: Put brackets around IPv6 addresses passed to ovn-ctl#459

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
danwinship:ovn-ctl-ipv6
Jan 31, 2020
Merged

Bug 1796616: Put brackets around IPv6 addresses passed to ovn-ctl#459
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
danwinship:ovn-ctl-ipv6

Conversation

@danwinship
Copy link
Contributor

per https://bugzilla.redhat.com/show_bug.cgi?id=1794923 we're expected to put brackets around IPv6 addresses here even though there are no ports attached to them (at the time we pass them)

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 30, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2020
@danwinship
Copy link
Contributor Author

/test e2e-aws-ovn

@dcbw
Copy link
Contributor

dcbw commented Jan 30, 2020

Now that openshift/origin#24477 is in...
/test e2e-aws-ovn

@dcbw
Copy link
Contributor

dcbw commented Jan 30, 2020

Flakes
/test e2e-aws-ovn

@dcbw dcbw changed the title WIP Put brackets around IPv6 addresses passed to ovn-ctl Bug 1796616: WIP Put brackets around IPv6 addresses passed to ovn-ctl Jan 30, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2020
@openshift-ci-robot
Copy link
Contributor

@danwinship: This pull request references Bugzilla bug 1796616, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1796616: WIP Put brackets around IPv6 addresses passed to ovn-ctl

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 30, 2020
@dcbw dcbw changed the title Bug 1796616: WIP Put brackets around IPv6 addresses passed to ovn-ctl Bug 1796616: Put brackets around IPv6 addresses passed to ovn-ctl [wip] Jan 30, 2020
@dcbw
Copy link
Contributor

dcbw commented Jan 30, 2020

/hold
Until Dan is ready with this one.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2020
@dcbw
Copy link
Contributor

dcbw commented Jan 30, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 30, 2020
@openshift-ci-robot
Copy link
Contributor

@dcbw: This pull request references Bugzilla bug 1796616, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw dcbw changed the title Bug 1796616: Put brackets around IPv6 addresses passed to ovn-ctl [wip] WIP Bug 1796616: Put brackets around IPv6 addresses passed to ovn-ctl Jan 30, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2020
@dcbw
Copy link
Contributor

dcbw commented Jan 30, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2020
@dcbw
Copy link
Contributor

dcbw commented Jan 31, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, dcbw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smarterclayton smarterclayton changed the title WIP Bug 1796616: Put brackets around IPv6 addresses passed to ovn-ctl Bug 1796616: Put brackets around IPv6 addresses passed to ovn-ctl Jan 31, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2020
@openshift-merge-robot openshift-merge-robot merged commit 3c3ad8d into openshift:master Jan 31, 2020
@openshift-ci-robot
Copy link
Contributor

@danwinship: All pull requests linked via external trackers have merged. Bugzilla bug 1796616 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1796616: Put brackets around IPv6 addresses passed to ovn-ctl

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship danwinship deleted the ovn-ctl-ipv6 branch January 31, 2020 19:19
@danwinship
Copy link
Contributor Author

/cherry-pick release-4.3

@openshift-cherrypick-robot

@danwinship: #459 failed to apply on top of branch "release-4.3":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	bindata/network/ovn-kubernetes/ovnkube-master.yaml
Falling back to patching base and 3-way merge...
Auto-merging bindata/network/ovn-kubernetes/ovnkube-master.yaml
CONFLICT (content): Merge conflict in bindata/network/ovn-kubernetes/ovnkube-master.yaml
Patch failed at 0001 Put brackets around IPv6 addresses passed to ovn-ctl

Details

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments