Bug 1796514: Adds openAPIV3Schema to NetworkAttachmentDefinitions by dougbtv · Pull Request #454 · openshift/cluster-network-operator

dougbtv · 2020-01-22T17:06:33Z

To fit requirements for having a structural schema to CRDs.

rcarrillocruz · 2020-01-22T17:58:40Z

/lgtm

abhat · 2020-01-22T18:50:34Z

/test e2e-gcp

abhat · 2020-01-22T18:50:52Z

/unassign @squeed
/assign @abhat

abhat · 2020-01-22T18:51:07Z

/lgtm

dougbtv · 2020-01-22T19:15:10Z

/test e2e-gcp
/test e2e-gcp-upgrade

openshift-bot · 2020-01-23T01:29:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T07:33:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T08:38:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T08:51:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T10:22:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T11:26:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T12:31:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T13:37:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T13:52:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T14:03:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T14:57:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T15:21:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T15:34:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T15:47:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T16:25:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T17:08:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T23:39:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-24T01:08:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

dcbw · 2020-01-28T15:34:00Z

@dougbtv

level=error msg="Cluster operator network Degraded is True with ApplyOperatorConfig: Error while updating operator configuration: could not apply (apiextensions.k8s.io/v1beta1, Kind=CustomResourceDefinition) /network-attachment-definitions.k8s.cni.cncf.io: could not create (apiextensions.k8s.io/v1beta1, Kind=CustomResourceDefinition) /network-attachment-definitions.k8s.cni.cncf.io: CustomResourceDefinition.apiextensions.k8s.io \"network-attachment-definitions.k8s.cni.cncf.io\" is invalid: [spec.versions: Invalid value: []apiextensions.CustomResourceDefinitionVersion(nil): must have exactly one version marked as storage version, status.storedVersions: Invalid value: []string(nil): must have at least one stored version]"

dougbtv · 2020-01-28T22:22:09Z

Gahhh, I think I had wrong indentation there after applying to a local cluster.... let's see if this one is good.

dougbtv · 2020-01-29T03:26:24Z

/test e2e-gcp

Looks like a flake.

dougbtv · 2020-01-29T13:20:48Z

/test e2e-gcp

Still looks like a flake to me, with other operators still updating, such as:

level=fatal msg="failed to initialize the cluster: Some cluster operators are still updating: authentication, console, csi-snapshot-controller, image-registry, ingress, kube-storage-version-migrator, monitoring"
--

dcbw · 2020-01-29T15:30:09Z

/test e2e-gcp

dougbtv · 2020-01-30T13:34:51Z

/test e2e-gcp

Looked like GCP error allocating resources.

dcbw · 2020-01-30T15:50:07Z

/lgtm

abhat · 2020-01-30T15:51:13Z

bindata/network/additional-networks/crd/001-crd.yaml

    kind: NetworkAttachmentDefinition
    shortNames:
    - net-attach-def
+  versions:


please add preserveUnknownFields to this so that oc explain will work.

openshift-ci-robot · 2020-01-30T15:52:55Z

@dougbtv: This pull request references Bugzilla bug 1796514, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1796514: Adds openAPIV3Schema to NetworkAttachmentDefinitions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dcbw · 2020-01-30T15:53:05Z

/lgtm cancel

…n CRD

dcbw · 2020-01-30T16:04:25Z

/lgtm

openshift-ci-robot · 2020-01-30T16:05:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, dcbw, dougbtv, rcarrillocruz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dcbw,rcarrillocruz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-01-30T18:21:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-30T18:47:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-30T20:29:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-30T20:42:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-01-30T22:20:00Z

@dougbtv: All pull requests linked via external trackers have merged. Bugzilla bug 1796514 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1796514: Adds openAPIV3Schema to NetworkAttachmentDefinitions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 22, 2020

openshift-ci-robot requested review from JacobTanenbaum and squeed January 22, 2020 17:07

openshift-ci-robot assigned rcarrillocruz Jan 22, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 22, 2020

openshift-ci-robot assigned abhat Jan 22, 2020

dougbtv force-pushed the add-nad-structural-schema branch from df26d9a to e55311a Compare January 28, 2020 15:06

dougbtv force-pushed the add-nad-structural-schema branch 2 times, most recently from c61a5cd to 86f70c0 Compare January 28, 2020 22:20

openshift-ci-robot assigned dcbw Jan 30, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2020

abhat reviewed Jan 30, 2020

View reviewed changes

dcbw changed the title ~~Adds openAPIV3Schema to NetworkAttachmentDefinitions~~ Bug 1796514: Adds openAPIV3Schema to NetworkAttachmentDefinitions Jan 30, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 30, 2020

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2020

Adds structural schema, openAPIV3Schema to NetworkAttachmentDefinitio…

8bdeabe

…n CRD

dougbtv force-pushed the add-nad-structural-schema branch from 86f70c0 to 8bdeabe Compare January 30, 2020 15:57

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2020

openshift-merge-robot merged commit d78b575 into openshift:master Jan 30, 2020

pecameron mentioned this pull request Feb 21, 2020

Bug 1806009: Backport ovn-kubernetes-related changes to 4.3 #483

Merged

Conversation

dougbtv commented Jan 22, 2020

Uh oh!

rcarrillocruz commented Jan 22, 2020

Uh oh!

abhat commented Jan 22, 2020

Uh oh!

abhat commented Jan 22, 2020

Uh oh!

abhat commented Jan 22, 2020

Uh oh!

dougbtv commented Jan 22, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 24, 2020

Uh oh!

dcbw commented Jan 28, 2020

Uh oh!

dougbtv commented Jan 28, 2020

Uh oh!

dougbtv commented Jan 29, 2020

Uh oh!

dougbtv commented Jan 29, 2020

Uh oh!

dcbw commented Jan 29, 2020

Uh oh!

dougbtv commented Jan 30, 2020

Uh oh!

dcbw commented Jan 30, 2020

Uh oh!

abhat Jan 30, 2020

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Jan 30, 2020

Uh oh!

dcbw commented Jan 30, 2020

Uh oh!

dcbw commented Jan 30, 2020

Uh oh!

openshift-ci-robot commented Jan 30, 2020

Uh oh!

openshift-bot commented Jan 30, 2020

Uh oh!

openshift-bot commented Jan 30, 2020

Uh oh!

openshift-bot commented Jan 30, 2020

Uh oh!