Skip to content

Support ovn2.12#439

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
pecameron:sdn643
Jan 11, 2020
Merged

Support ovn2.12#439
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
pecameron:sdn643

Conversation

@pecameron
Copy link
Contributor

ovn2.12 places the ovn-ctl script in a different directory than earlier
versions. This uses the correct path for the installed version.

SDN-643 - OVN: Bump to ovn v2.12
https://issues.redhat.com/browse/SDN-643

Signed-off-by: Phil Cameron pcameron@redhat.com

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 7, 2020
@pecameron
Copy link
Contributor Author

@dcbw PTAL

@pecameron
Copy link
Contributor Author

/test e2e-aws-ovn

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 7, 2020
@pecameron
Copy link
Contributor Author

/test e2e-aws-ovn

1 similar comment
@dcbw
Copy link
Contributor

dcbw commented Jan 8, 2020

/test e2e-aws-ovn

ovn2.12 places the ovn-ctl script in a different directory than earlier
versions. This uses the correct path for the installed version.

SDN-643 - OVN: Bump to ovn v2.12
https://issues.redhat.com/browse/SDN-643

Signed-off-by: Phil Cameron <pcameron@redhat.com>
@pecameron
Copy link
Contributor Author

/test e2e-aws-ovn

@pecameron
Copy link
Contributor Author

@dcbw PTAL

@pecameron
Copy link
Contributor Author

@rcarrillocruz @JacobTanenbaum PTAL

@abhat
Copy link
Contributor

abhat commented Jan 8, 2020

@pecameron i went over the changes with my limited expertise in the area. Is there a separate PR that flips the switch from 2.11 to 2.12 in some daemonset configuration?

/lgtm

cc @dcbw.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2020
@pecameron
Copy link
Contributor Author

@abhat We use whatever is built into the image. See
openshift/ovn-kubernetes#72

@pecameron
Copy link
Contributor Author

/assign @knobunc

@dcbw
Copy link
Contributor

dcbw commented Jan 9, 2020

/test e2e-aws-ovn

@pecameron
Copy link
Contributor Author

Last test there are no nodes, no pods
/test e2e-aws-ovn

@pecameron
Copy link
Contributor Author

msg="Error: ResourceLimitExceeded: Task limit exceeded"
/test e2e-aws-ovn

@pecameron
Copy link
Contributor Author

/test e2e-aws-ovn

@pecameron
Copy link
Contributor Author

@dcbw Tests passed. Are we ready to merge this? PTAL

@pecameron
Copy link
Contributor Author

@JacobTanenbaum @knobunc @dcbw PTAL
is this ready to merge? Its blocking openshift/ovn-kubernetes PR72

@knobunc
Copy link
Contributor

knobunc commented Jan 10, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, knobunc, pecameron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants