ovn-kube: add pod disruption budget, readiness check#414
ovn-kube: add pod disruption budget, readiness check#414openshift-merge-robot merged 1 commit intoopenshift:masterfrom squeed:ovn-improvements
Conversation
Add a PodDisruptionBudget to protect the raft quorum. Configure a readines probe for the DBs: ovsdb raft only opens its port once it has a raft consensus. Utilize that. Also, add a TerminationMessagePolicy.
openshift-ci-robot
added
the
size/M
|
/test e2e-aws-ovn |
|
/cc @dcbw |
openshift-ci-robot
added
the
approved
| done | ||
| fi | ||
| readinessProbe: | ||
| initialDelaySeconds: 30 |
There was a problem hiding this comment.
Question, I am not sure how readinessProbes impact hostNetwork pods. But will ovnkube-node be able to communicate with its depedencies in ovnkube-master during the first 30 seconds while ovnkube-master is not ready? Otherwise I suspect we might have a lot of errors logged in those pods (if they don't even CrashLoop?)
There was a problem hiding this comment.
Very good question. In this case, that won't be an issue, because we're not using a Service / Endpoints. Basically, only Ready pods can show up in a Service. However, we talk directly to the pods, so that's not an issue here.
|
Looks like the test failure is due to a pod not being created in time, but the logs indicate it only waits about 5 seconds. That seems... wrong. Looking further. |
|
Aha, seems to be a bit of a flake |
|
Filed https://bugzilla.redhat.com/show_bug.cgi?id=1780143 for test flake. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderConstantinescu, squeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@squeed: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
5 participants
Add a PodDisruptionBudget to protect the raft quorum.
Configure a readines probe for the DBs: ovsdb raft only opens its port once it has a raft consensus. Utilize that.
Also, add a TerminationMessagePolicy.
(Closes SDN-662)
/cc @alexanderConstantinescu