Skip to content

[release-4.2] Fixes Bug 1759253: Adds GCP metadata hostnames to default noProxy #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 8, 2019
Merged

[release-4.2] Fixes Bug 1759253: Adds GCP metadata hostnames to default noProxy #338

openshift-merge-robot merged 1 commit into from
Oct 8, 2019

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Oct 7, 2019

This is an automated cherry-pick of #325

/assign danehans

@danehans
Fixes Bug 1753930: Adds GCP metadata hostnames to default noProxy
ea9717a 
Previously, only the metadata IP was being added to the default
noProxy list. This causes calls to GCP metadata that use hostname
instead of IP to be proxied.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 7, 2019
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 7, 2019

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1754049, which is invalid:

  • expected the bug to target the "4.2.0" release, but it targets "4.3.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.2] Fixes Bug 1754049: Adds GCP metadata hostnames to default noProxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 7, 2019
@danehans
Copy link
Contributor

danehans commented Oct 7, 2019

/retitle [release-4.2] Fixes Bug 1759253: Adds GCP metadata hostnames to default noProxy

@openshift-ci-robot openshift-ci-robot changed the title [release-4.2] Fixes Bug 1754049: Adds GCP metadata hostnames to default noProxy [release-4.2] Fixes Bug 1759253: Adds GCP metadata hostnames to default noProxy Oct 7, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 7, 2019

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1759253, which is invalid:

  • expected the bug to target the "4.2.0" release, but it targets "4.2.z" instead
  • expected dependent Bugzilla bug 1754049 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.2] Fixes Bug 1759253: Adds GCP metadata hostnames to default noProxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danehans
Copy link
Contributor

danehans commented Oct 7, 2019 •
edited
Loading

/assign @wking @knobunc

@sdodson
Copy link
Member

sdodson commented Oct 8, 2019

/refresh bugzilla

@sdodson
Copy link
Member

sdodson commented Oct 8, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 8, 2019

@sdodson: This pull request references Bugzilla bug 1759253, which is invalid:

  • expected dependent Bugzilla bug 1754049 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson sdodson added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 8, 2019
@sdodson
Copy link
Member

sdodson commented Oct 8, 2019

overriding bugzilla/invalid-bug

@sdodson
Copy link
Member

sdodson commented Oct 8, 2019

/retest

@knobunc
Copy link
Contributor

knobunc commented Oct 8, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 8, 2019
@knobunc
Copy link
Contributor

knobunc commented Oct 8, 2019

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@crawford crawford added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 8, 2019
@openshift-merge-robot openshift-merge-robot merged commit 86be17e into openshift:release-4.2 Oct 8, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 8, 2019

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1759253 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.2] Fixes Bug 1759253: Adds GCP metadata hostnames to default noProxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcbw dcbw Awaiting requested review from dcbw

@squeed squeed Awaiting requested review from squeed

Assignees

@wking wking

@danehans danehans

@knobunc knobunc

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@openshift-cherrypick-robot @openshift-ci-robot @danehans @sdodson @knobunc @wking @crawford @openshift-merge-robot