[release-4.18] OCPBUGS-77151: Add config override for openflow-probe by taanyas · Pull Request #2965 · openshift/cluster-network-operator

taanyas · 2026-04-20T13:16:48Z

Manual cherry-pick of 4.19 commits to release-4.18:

e2ba945: Allow overriding OVN-Kubernetes configuration (ConfigOverrides infrastructure)
003d471: Add config override for openflow-probe (OpenFlowProbe feature)

This backport adds ConfigOverrides infrastructure and openflow-probe feature support to release-4.18.

Conflict Resolution

During cherry-picking, merge conflicts were resolved:

Removed advertised-udn-isolation-mode code (not needed for this backport)
Kept ConfigOverrides infrastructure (required by openflow-probe feature)
Kept openflow-probe feature code and tests only

Files Changed

bindata/network/ovn-kubernetes/common/008-script-lib.yaml
pkg/network/ovn_kubernetes.go
pkg/network/ovn_kubernetes_test.go

openshift-ci-robot · 2026-04-20T13:16:56Z

@taanyas: This pull request references Jira Issue OCPBUGS-77151, which is invalid:

expected dependent Jira Issue OCPBUGS-77150 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual cherry-pick of 4.20 commits to release-4.18.

Cherry-picked commits:

Allow overriding OVN-Kubernetes configuration

Add config override for openflow-probe

This backport adds ConfigOverrides infrastructure and openflow-probe feature support to release-4.18.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-04-20T13:16:56Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ddae6064-676c-4a07-99de-976c3c7a8195

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

arkadeepsen · 2026-04-20T15:35:11Z

/retest-required

arkadeepsen · 2026-04-20T17:39:36Z

/retest-required

danwinship · 2026-04-20T18:17:54Z


+      if [[ "{{.AdvertisedUDNIsolationMode}}" != "" ]]; then
+        ovn_advertised_udn_isolation_mode_flag="--advertised-udn-isolation-mode={{.AdvertisedUDNIsolationMode}}"
+      fi


This is not part of backporting "config override for openflow-probe". Do we actually want this change backported as well?

Both commits were cherry-picked from 4.19 -

e2ba945 - ConfigOverrides infrastructure (PR [release-4.19] OCPBUGS-60761: Allow overriding OVN-Kubernetes configuration #2781)

003d471 - OpenflowProbe feature (PR [release-4.20] OCPBUGS-77148: Add config override for openflow-probe #2918)

The AdvertisedUDNIsolationMode code is part of the ConfigOverrides
infrastructure that the openflow-probe feature depends on.

Both commits were included together to maintain consistency with the 4.19 backport.
@pperiyasamy

Hey @taanyas, the original PR is only for openflow-probe feature and not for advertised-udn-isolation-mode. Since we are only backporting the openflow-probe feature, you can remove the code for enabling advertised-udn-isolation-mode via config overrides.

This change introduces a mechanism to provide hidden or experimental configuration to OVN-Kubernetes through a ConfigMap. This provides a flexible way to enable advanced or experimental OVN-Kubernetes features without modifying the CNO API. A new ConfigMap 'ovn-kubernetes-config-overrides', is now read by the operator during the bootstrap process. The key-value data from this ConfigMap is passed down to the OVN-K components. As an initial implementation, this is used to support the flag 'advertised-udn-isolation-mode' which is to enable user to select the UDN isolation mode between 'loose' and 'strict'. If unset, the default mode is 'strict'. Signed-off-by: Peng Liu <pliu@redhat.com> (cherry picked from commit e2ba945)

(cherry picked from commit 119a5bc) (cherry picked from commit cd14da6) (cherry picked from commit 003d471)

openshift-ci · 2026-04-21T16:21:14Z

@taanyas: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	`7da176f`	link	false	`/test security`
ci/prow/4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade	`7da176f`	link	false	`/test 4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

pperiyasamy · 2026-04-22T14:39:51Z

/jira refresh

openshift-ci-robot · 2026-04-22T14:39:59Z

@pperiyasamy: This pull request references Jira Issue OCPBUGS-77151, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.18.z) matches configured target version for branch (4.18.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-77150 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-77150 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pperiyasamy · 2026-04-22T14:42:27Z

@taanyas can you update PR description with an info about resolved conflicts ?

pperiyasamy · 2026-04-22T14:47:27Z

/assign @SachinNinganure

openshift-ci-robot · 2026-04-22T15:59:53Z

@taanyas: This pull request references Jira Issue OCPBUGS-77151, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.18.z) matches configured target version for branch (4.18.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-77150 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-77150 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

Manual cherry-pick of 4.19 commits to release-4.18:

e2ba945: Allow overriding OVN-Kubernetes configuration (ConfigOverrides infrastructure)

003d471: Add config override for openflow-probe (OpenFlowProbe feature)

This backport adds ConfigOverrides infrastructure and openflow-probe feature support to release-4.18.

Conflict Resolution

During cherry-picking, merge conflicts were resolved:

Removed advertised-udn-isolation-mode code (not needed for this backport)

Kept ConfigOverrides infrastructure (required by openflow-probe feature)

Kept openflow-probe feature code and tests only

Files Changed

bindata/network/ovn-kubernetes/common/008-script-lib.yaml

pkg/network/ovn_kubernetes.go

pkg/network/ovn_kubernetes_test.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

danwinship · 2026-04-22T21:48:59Z

/lgtm
/label backport-risk-assessed

openshift-ci · 2026-04-22T21:49:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, taanyas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [danwinship]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

arkadeepsen · 2026-04-23T05:30:33Z

/jira refresh

openshift-ci-robot · 2026-04-23T05:30:38Z

@arkadeepsen: This pull request references Jira Issue OCPBUGS-77151, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.18.z) matches configured target version for branch (4.18.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-77150 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-77150 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

SachinNinganure · 2026-04-24T17:10:24Z

System handled complex policy setup without ACL explosion
more details
https://docs.google.com/document/d/1y5JSgEwT8aVwOKsxY3vjdiFIdX8ob7vdZhwAtuBj7ac/edit?tab=t.0#heading=h.klqn662hjs1l

/verified by @SachinNinganure

openshift-ci-robot · 2026-04-24T17:10:37Z

@SachinNinganure: This PR has been marked as verified by @SachinNinganure.

Details

In response to this:

System handled complex policy setup without ACL explosion
more details
https://docs.google.com/document/d/1y5JSgEwT8aVwOKsxY3vjdiFIdX8ob7vdZhwAtuBj7ac/edit?tab=t.0#heading=h.klqn662hjs1l

/verified by @SachinNinganure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-04-24T17:14:50Z

@taanyas: Jira Issue OCPBUGS-77151: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

openshift/ovn-kubernetes#3143 is open

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-77151 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

Details

In response to this:

Manual cherry-pick of 4.19 commits to release-4.18:

e2ba945: Allow overriding OVN-Kubernetes configuration (ConfigOverrides infrastructure)

003d471: Add config override for openflow-probe (OpenFlowProbe feature)

This backport adds ConfigOverrides infrastructure and openflow-probe feature support to release-4.18.

Conflict Resolution

During cherry-picking, merge conflicts were resolved:

Removed advertised-udn-isolation-mode code (not needed for this backport)

Kept ConfigOverrides infrastructure (required by openflow-probe feature)

Kept openflow-probe feature code and tests only

Files Changed

bindata/network/ovn-kubernetes/common/008-script-lib.yaml

pkg/network/ovn_kubernetes.go

pkg/network/ovn_kubernetes_test.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2026-04-27T23:05:29Z

Fix included in release 4.18.0-0.nightly-2026-04-27-154955

openshift-ci Bot requested review from arkadeepsen and bpickard22 April 20, 2026 13:23

danwinship reviewed Apr 20, 2026

View reviewed changes

taanyas force-pushed the ovs-bundle-timeout-release-4.18 branch 2 times, most recently from be27d13 to 987e546 Compare April 21, 2026 10:58

pliurh and others added 2 commits April 21, 2026 16:57

Add config override for openflow-probe

7da176f

(cherry picked from commit 119a5bc) (cherry picked from commit cd14da6) (cherry picked from commit 003d471)

taanyas force-pushed the ovs-bundle-timeout-release-4.18 branch from 987e546 to 7da176f Compare April 21, 2026 11:44

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 22, 2026

openshift-ci Bot requested a review from anuragthehatter April 22, 2026 14:40

openshift-ci Bot assigned SachinNinganure Apr 22, 2026

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 22, 2026

openshift-ci Bot assigned anuragthehatter, asood-rh and barbora137 Apr 22, 2026

openshift-ci Bot assigned imatza-rh, jechen0648, mffiedler, rbbratta, weliang1 and danwinship Apr 22, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 24, 2026

openshift-merge-bot Bot merged commit 99c785c into openshift:release-4.18 Apr 24, 2026
19 of 21 checks passed

Conversation

taanyas commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conflict Resolution

Files Changed

Uh oh!

openshift-ci-robot commented Apr 20, 2026

Uh oh!

coderabbitai Bot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

arkadeepsen commented Apr 20, 2026

Uh oh!

arkadeepsen commented Apr 20, 2026

Uh oh!

danwinship Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

taanyas Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

arkadeepsen Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Apr 21, 2026

Uh oh!

pperiyasamy commented Apr 22, 2026

Uh oh!

openshift-ci-robot commented Apr 22, 2026

Uh oh!

pperiyasamy commented Apr 22, 2026

Uh oh!

pperiyasamy commented Apr 22, 2026

Uh oh!

openshift-ci-robot commented Apr 22, 2026

Conflict Resolution

Files Changed

Uh oh!

danwinship commented Apr 22, 2026

Uh oh!

openshift-ci Bot commented Apr 22, 2026

Uh oh!

arkadeepsen commented Apr 23, 2026

Uh oh!

openshift-ci-robot commented Apr 23, 2026

Uh oh!

SachinNinganure commented Apr 24, 2026

Uh oh!

openshift-ci-robot commented Apr 24, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 24, 2026

Conflict Resolution

Files Changed

Uh oh!

openshift-merge-robot commented Apr 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

taanyas commented Apr 20, 2026 •

edited

Loading

coderabbitai Bot commented Apr 20, 2026 •

edited

Loading