-
Notifications
You must be signed in to change notification settings - Fork 270
OCPBUGS-38249: Verify that the codegen changes were commited #2373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-38249: Verify that the codegen changes were commited #2373
Conversation
|
Skipping CI for Draft Pull Request. |
|
@kyrtapz: GitHub didn't allow me to request PR reviews from the following users: kyrtapz. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
410a98a to
badbb13
Compare
|
/test verify |
|
/test verify |
|
/test verify |
|
/test verify |
|
@kyrtapz: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retet |
|
/retest |
1 similar comment
|
/retest |
|
/assign @martinkennelly |
|
/lgtm Holding to allow other PR review volunteers to review. |
|
@kyrtapz: This pull request references Jira Issue OCPBUGS-38249, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/override ci/prow/okd-scos-images we don't know what is going on with okd images, tracking here |
|
@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/okd-scos-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.17 |
|
@jcaamano: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/okd-scos-images we don't know what is going on with okd images, tracking here |
|
@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/okd-scos-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
/test e2e-aws-ovn-upgrade |
1 similar comment
|
/test e2e-aws-ovn-upgrade |
|
/test okd-scos-images |
1 similar comment
|
/test okd-scos-images |
|
/test okd-scos-images |
|
/hold Revision 6611fc6 was retested 3 times: holding |
|
@kyrtapz: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
|
/hold cancel |
|
@kyrtapz: Jira Issue OCPBUGS-38249: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-38249 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jcaamano: Failed to get PR patch from GitHub. This PR will need to be manually cherrypicked. Error messagestatus code 406 not one of [200], body: {"message":"Sorry, the diff exceeded the maximum number of lines (20000)","errors":[{"resource":"PullRequest","field":"diff","code":"too_large"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#get-a-pull-request","status":"406"}DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] Distgit: cluster-network-operator |
In the past we had several bugs in which we forgot to run
hack/update-codegen.shthat resulted in the APIs not being updated.This change ensures that this won't happen as CI would catch that in the
verifystep.Tested here: #2176