Skip to content

Conversation

@kyrtapz
Copy link
Contributor

@kyrtapz kyrtapz commented May 17, 2024

In the past we had several bugs in which we forgot to run hack/update-codegen.sh that resulted in the APIs not being updated.
This change ensures that this won't happen as CI would catch that in the verify step.
Tested here: #2176

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2024

@kyrtapz: GitHub didn't allow me to request PR reviews from the following users: kyrtapz.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
@kyrtapz kyrtapz force-pushed the codegen_refactor branch 2 times, most recently from 410a98a to badbb13 Compare May 17, 2024 13:33
@kyrtapz
Copy link
Contributor Author

kyrtapz commented May 17, 2024

/test verify

@kyrtapz kyrtapz force-pushed the codegen_refactor branch from badbb13 to 002cd18 Compare May 17, 2024 13:56
@kyrtapz
Copy link
Contributor Author

kyrtapz commented May 17, 2024

/test verify

@kyrtapz
Copy link
Contributor Author

kyrtapz commented May 17, 2024

/test verify

@kyrtapz kyrtapz force-pushed the codegen_refactor branch from 5f33304 to 59532a8 Compare May 17, 2024 16:58
@kyrtapz
Copy link
Contributor Author

kyrtapz commented May 17, 2024

/test verify

@kyrtapz kyrtapz changed the title [WIP] Refactor hack/update-codegen.sh Verify that the codegen changes were commited May 17, 2024
@kyrtapz kyrtapz marked this pull request as ready for review May 17, 2024 17:05
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2024
@kyrtapz kyrtapz changed the title Verify that the codegen changes were commited NO-JIRA: Verify that the codegen changes were commited May 17, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 17, 2024
@openshift-ci-robot
Copy link
Contributor

@kyrtapz: This pull request explicitly references no jira issue.

Details

In response to this:

In the past we had several bugs in which we forgot to run hack/update-codegen.sh that resulted in the APIs not being updated.
This change ensures that this won't happen as CI would catch that in the verify step.
Tested here: #2176

The first 3 commits are mostly vendoring.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from JacobTanenbaum and dougbtv May 17, 2024 17:15
@kyrtapz
Copy link
Contributor Author

kyrtapz commented May 20, 2024

/retet

@kyrtapz
Copy link
Contributor Author

kyrtapz commented May 20, 2024

/retest

1 similar comment
@kyrtapz
Copy link
Contributor Author

kyrtapz commented May 20, 2024

/retest

@martinkennelly
Copy link
Contributor

/assign @martinkennelly

@martinkennelly
Copy link
Contributor

/lgtm
/hold

Holding to allow other PR review volunteers to review.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 9, 2024
@openshift-ci-robot
Copy link
Contributor

@kyrtapz: This pull request references Jira Issue OCPBUGS-38249, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

In the past we had several bugs in which we forgot to run hack/update-codegen.sh that resulted in the APIs not being updated.
This change ensures that this won't happen as CI would catch that in the verify step.
Tested here: #2176

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from anuragthehatter August 9, 2024 15:07
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d035fdd and 2 for PR HEAD 6611fc6 in total

@jcaamano
Copy link
Contributor

jcaamano commented Aug 9, 2024

/override ci/prow/okd-scos-images

we don't know what is going on with okd images, tracking here
https://issues.redhat.com/browse/OCPBUGS-38256

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2024

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/okd-scos-images

Details

In response to this:

/override ci/prow/okd-scos-images

we don't know what is going on with okd images, tracking here
https://issues.redhat.com/browse/OCPBUGS-38256

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jcaamano
Copy link
Contributor

jcaamano commented Aug 9, 2024

/cherry-pick release-4.17

@openshift-cherrypick-robot

@jcaamano: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jcaamano
Copy link
Contributor

/override ci/prow/okd-scos-images

we don't know what is going on with okd images, tracking here
https://issues.redhat.com/browse/OCPBUGS-38256

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2024

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/okd-scos-images

Details

In response to this:

/override ci/prow/okd-scos-images

we don't know what is going on with okd images, tracking here
https://issues.redhat.com/browse/OCPBUGS-38256

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jcaamano
Copy link
Contributor

/retest

@jcaamano
Copy link
Contributor

/test e2e-aws-ovn-upgrade

1 similar comment
@jcaamano
Copy link
Contributor

/test e2e-aws-ovn-upgrade

@jcaamano
Copy link
Contributor

/test okd-scos-images

1 similar comment
@jcaamano
Copy link
Contributor

/test okd-scos-images

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 18610b8 and 1 for PR HEAD 6611fc6 in total

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Aug 14, 2024

/test okd-scos-images
🤞

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c798d47 and 0 for PR HEAD 6611fc6 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 6611fc6 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2024

@kyrtapz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-live-migration-sdn-ovn-rollback 59532a8 link false /test e2e-aws-live-migration-sdn-ovn-rollback
ci/prow/e2e-aws-sdn-upgrade 59532a8 link false /test e2e-aws-sdn-upgrade
ci/prow/e2e-vsphere-ovn-dualstack 6611fc6 link false /test e2e-vsphere-ovn-dualstack
ci/prow/e2e-aws-ovn-techpreview-serial 6611fc6 link false /test e2e-aws-ovn-techpreview-serial
ci/prow/e2e-azure-ovn 6611fc6 link false /test e2e-azure-ovn
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 6611fc6 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/security 6611fc6 link false /test security
ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration 6611fc6 link false /test e2e-aws-ovn-shared-to-local-gateway-mode-migration
ci/prow/e2e-aws-hypershift-ovn-kubevirt 6611fc6 link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/e2e-aws-ovn-serial 6611fc6 link false /test e2e-aws-ovn-serial
ci/prow/okd-scos-images 6611fc6 link true /test okd-scos-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Aug 19, 2024

/retest-required

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Aug 19, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3465b50 and 2 for PR HEAD 6611fc6 in total

@openshift-merge-bot openshift-merge-bot bot merged commit b9b0285 into openshift:master Aug 19, 2024
@openshift-ci-robot
Copy link
Contributor

@kyrtapz: Jira Issue OCPBUGS-38249: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38249 has been moved to the MODIFIED state.

Details

In response to this:

In the past we had several bugs in which we forgot to run hack/update-codegen.sh that resulted in the APIs not being updated.
This change ensures that this won't happen as CI would catch that in the verify step.
Tested here: #2176

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@jcaamano: Failed to get PR patch from GitHub. This PR will need to be manually cherrypicked.

Error messagestatus code 406 not one of [200], body: {"message":"Sorry, the diff exceeded the maximum number of lines (20000)","errors":[{"resource":"PullRequest","field":"diff","code":"too_large"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#get-a-pull-request","status":"406"}
Details

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-network-operator
This PR has been included in build cluster-network-operator-container-v4.18.0-202408191846.p0.gb9b0285.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants