Skip to content

[wip][poc]Interconnect on hypershift#1832

Closed
JacobTanenbaum wants to merge 4 commits intoopenshift:masterfrom
JacobTanenbaum:interconnect-hypershift-1
Closed

[wip][poc]Interconnect on hypershift#1832
JacobTanenbaum wants to merge 4 commits intoopenshift:masterfrom
JacobTanenbaum:interconnect-hypershift-1

Conversation

@JacobTanenbaum
Copy link
Contributor

@JacobTanenbaum JacobTanenbaum commented Jun 8, 2023

using this PR it is possible to deploy an ovn-IC cluster hosted on hypershift

you need to build an image using this PR and point the hosted control plane image at the custom CNO image by modifying this line

https://github.com/openshift/hypershift/blob/main/control-plane-operator/controllers/hostedcontrolplane/cno/clusternetworkoperator.go#L79

Also a version of openshift/ovn-kubernetes is needed that supports ovn-ic e.g: openshift/ovn-kubernetes#1690

and the hosted control plane will also need to be pointed at that image
https://github.com/openshift/hypershift/blob/main/control-plane-operator/controllers/hostedcontrolplane/cno/clusternetworkoperator.go#L90

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2023
@openshift-ci openshift-ci bot requested review from dcbw and tssurya June 8, 2023 17:24
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JacobTanenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2023
@JacobTanenbaum JacobTanenbaum force-pushed the interconnect-hypershift-1 branch from be16812 to 968d5e3 Compare June 21, 2023 13:53
@kyrtapz
Copy link
Contributor

kyrtapz commented Jun 23, 2023

/assign @kyrtapz

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2023
@JacobTanenbaum JacobTanenbaum force-pushed the interconnect-hypershift-1 branch from 968d5e3 to 0e45f20 Compare June 26, 2023 13:13
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 26, 2023

@JacobTanenbaum: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift-ovn 0e45f20 link true /test e2e-hypershift-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6 0e45f20 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-openstack-ovn 0e45f20 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node 0e45f20 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-network-mtu-migration-ovn-ipv6 0e45f20 link false /test e2e-network-mtu-migration-ovn-ipv6
ci/prow/e2e-vsphere-ovn-windows 0e45f20 link true /test e2e-vsphere-ovn-windows
ci/prow/e2e-vsphere-ovn-dualstack 0e45f20 link false /test e2e-vsphere-ovn-dualstack
ci/prow/e2e-vsphere-ovn 0e45f20 link false /test e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 25, 2023
@ricky-rav
Copy link
Contributor

/close

@openshift-ci openshift-ci bot closed this Sep 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 25, 2023

@ricky-rav: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants