Skip to content

[wip][poc] CNO with ovn-ic#1825

Closed
kyrtapz wants to merge 3 commits intoopenshift:masterfrom
kyrtapz:cno_ic_poc
Closed

[wip][poc] CNO with ovn-ic#1825
kyrtapz wants to merge 3 commits intoopenshift:masterfrom
kyrtapz:cno_ic_poc

Conversation

@kyrtapz
Copy link
Contributor

@kyrtapz kyrtapz commented Jun 1, 2023 •
edited
Loading

This builds on top of #1757
Always deploys ovn-ic, retries zone setting in nbdb poststart hook

uses hardcoded ovn-k image: quay.io/pdiak/ovn-kubernetes:upstream-pr-3699 based on ovn-kubernetes/ovn-kubernetes#3699

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 1, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2023

@kyrtapz: GitHub didn't allow me to request PR reviews from the following users: kyrtapz.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

This builds on top of #1757
Always deploys ovn-ic, retries zone setting in nbdb poststart hook

Has to be used with an ovn-k image that has ic support, e.g: openshift/ovn-kubernetes#1693
/cc
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyrtapz kyrtapz force-pushed the cno_ic_poc branch 5 times, most recently from 1e59bf2 to 4c042ef Compare June 2, 2023 11:32
@kyrtapz
Copy link
Contributor Author

kyrtapz commented Jun 6, 2023

/test e2e-aws-ovn-network-migration

@qinqon qinqon mentioned this pull request Jun 20, 2023
Closed
@qinqon qinqon mentioned this pull request Jun 23, 2023
Closed
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2023
numansiddique and others added 3 commits June 27, 2023 11:56
@numansiddique @kyrtapz
WIP: Add OVN Interconnect support for OVNKubernetes.
3065ec9 
Signed-off-by: Numan Siddique <nusiddiq@redhat.com>
(cherry picked from commit e00aa00)

Conflicts:
	bindata/network/ovn-kubernetes/self-hosted/ovnkube-node.yaml
@kyrtapz
Always deploy IC, retry zone setting
533ba68 
Signed-off-by: Patryk Diak <pdiak@redhat.com>
@kyrtapz
Hardcoded ovn image to quay.io/pdiak/ovn-kubernetes:upstream-pr-3699
41ef86c 
Image built from: ovn-kubernetes/ovn-kubernetes#3699 containing some IC fixes

Signed-off-by: Patryk Diak <pdiak@redhat.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 27, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kyrtapz
Once this PR has been reviewed and has the lgtm label, please assign fepan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyrtapz kyrtapz marked this pull request as draft June 27, 2023 10:07
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2023

@kyrtapz: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tssurya
Copy link
Contributor

tssurya commented Jul 18, 2023

/close

@openshift-ci openshift-ci bot closed this Jul 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2023

@tssurya: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kyrtapz @tssurya @openshift-merge-robot @numansiddique