manifests: prefix manifests used by CVO with a 0000_xx_NAME prefix#388
Merged
Merged
Conversation
openshift-ci-robot
added
approved
Contributor
Author
|
/retest |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, paulfantom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
I need to hold it for a moment to check SM definitions in OLM |
openshift-ci-robot
added
the
do-not-merge/hold
Contributor
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
wking
added a commit
to wking/cluster-monitoring-operator
that referenced
this pull request
Aug 17, 2020
…g-operator" The regular expression for the component portion is [1]: [a-z0-9\-]+ or [2]: [a-zA-Z0-9]+(-[a-zA-Z0-9]+)*?) Either way, it cannot include underscores, so manifests like 0000_50_cluster_monitoring_operator_01-namespace.yaml end up in the 'cluster' component. With this change, they will end up in the 'cluster-monitoring-operator' component. The outgoing, underscore form landed in 9fd35c2 (manifests: prefix manifests used by CVO with a 0000_xx_NAME prefix, 2019-06-25, openshift#388). Generated with: $ rename cluster_monitoring_operator cluster-monitoring-operator manifests/*.yaml $ sed -i 's/cluster_monitoring_operator/cluster-monitoring-operator/g' Documentation/data-collection.md Makefile README.md hack/build-jsonnet.sh hack/build-jsonnet.sh hack/local-cmo.sh hack/telemeter_query.go [1]: https://github.com/openshift/cluster-version-operator/blob/71aef74480d199fe96a590f2f1e4e8056a9cb687/docs/dev/operators.md#what-is-the-order-that-resources-get-createdupdated-in [2]: https://github.com/openshift/cluster-version-operator/blob/71aef74480d199fe96a590f2f1e4e8056a9cb687/pkg/payload/task_graph.go#L21
wking
added a commit
to wking/cluster-monitoring-operator
that referenced
this pull request
Aug 26, 2020
…g-operator" The regular expression for the component portion is [1]: [a-z0-9\-]+ or [2]: [a-zA-Z0-9]+(-[a-zA-Z0-9]+)*?) Either way, it cannot include underscores, so manifests like 0000_50_cluster_monitoring_operator_01-namespace.yaml end up in the 'cluster' component. With this change, they will end up in the 'cluster-monitoring-operator' component. The outgoing, underscore form landed in 9fd35c2 (manifests: prefix manifests used by CVO with a 0000_xx_NAME prefix, 2019-06-25, openshift#388). Generated with: $ rename cluster_monitoring_operator cluster-monitoring-operator manifests/*.yaml $ sed -i 's/cluster_monitoring_operator/cluster-monitoring-operator/g' Documentation/data-collection.md Makefile README.md hack/build-jsonnet.sh hack/build-jsonnet.sh hack/local-cmo.sh hack/telemeter_query.go [1]: https://github.com/openshift/cluster-version-operator/blob/71aef74480d199fe96a590f2f1e4e8056a9cb687/docs/dev/operators.md#what-is-the-order-that-resources-get-createdupdated-in [2]: https://github.com/openshift/cluster-version-operator/blob/71aef74480d199fe96a590f2f1e4e8056a9cb687/pkg/payload/task_graph.go#L21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a minor clarification on what runlevel cmo is running on and unifying manifests naming across openshift org.
From https://coreos.slack.com/archives/C0VMT03S5/p1561474960242800
/cc @brancz @metalmatze @squat