Skip to content

OCPBUGS-93756: update github.com/prometheus/prometheus - #2979

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
simonpasquier:OCPBUGS-93756
Jul 2, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
simonpasquier:OCPBUGS-93756

Conversation

@simonpasquier

Copy link
Copy Markdown
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 30, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@simonpasquier: This pull request references Jira Issue OCPBUGS-93756, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from danielmellado and jan--f June 30, 2026 14:58
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2026
@simonpasquier

Copy link
Copy Markdown
Contributor Author

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jun 30, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@simonpasquier: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026 •

Copy link
Copy Markdown

Caution

Review failed

An error occurred during the review process. Please try again later.

📝 Walkthrough

Walkthrough

go.mod updates several direct dependencies, including Prometheus-related, golang.org/x/*, and k8s.io/* modules, and refreshes the indirect dependency block with newer cloud/auth, OpenTelemetry, gRPC, protobuf, and go-openapi/* versions. In hack/promql_rule/main.go and pkg/promqlgen/promqlgen.go, PromQL parsing now reuses a single parser instance instead of invoking package-level parse helpers for each expression or selector.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 13 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning No PR description was provided, so the required Telemetry report template is missing entirely. Add the Telemetry report section and fill in the required telemetry report block, or explain why it is not needed for this change.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (13 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: updating the Prometheus dependency.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No test files were changed in the commit, and the patch adds no Ginkgo titles with dynamic content.
Test Structure And Quality ✅ Passed No Ginkgo test files were changed in this PR, so the test-structure/quality check is not applicable.
Microshift Test Compatibility ✅ Passed Only go.mod and an internal parser helper changed; no new Ginkgo/e2e tests were added, and no MicroShift-unavailable APIs appear in touched code.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The PR only updates go.mod and a non-test helper in pkg/promqlgen; no new Ginkgo e2e tests or SNO-sensitive assumptions were added.
Topology-Aware Scheduling Compatibility ✅ Passed Only dependency bumps and a PromQL parsing helper changed; no manifests, controllers, or topology-sensitive scheduling constraints were introduced.
Ote Binary Stdout Contract ✅ Passed The code change is confined to promql parsing; no process-level stdout writes were added in main/init/TestMain/suite setup paths.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; changes are limited to go.mod and a promql parser refactor, with no IPv4 literals or external connectivity.
No-Weak-Crypto ✅ Passed Touched code only reuses PromQL parsing and go.mod bumps; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret compares found.
Container-Privileges ✅ Passed PASS: The PR only updates Go deps and one parser call; patch scans found no manifest/container securityContext settings like privileged, hostPID, or allowPrivilegeEscalation.
No-Sensitive-Data-In-Logs ✅ Passed Changed files add no logging; promqlgen.go only reuses a parser and returns fmt errors, and go.mod is dependency-only.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Tools execution failed with the following error:

Failed to run tools: Ping-pong health check failed


Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Jun 30, 2026
@simonpasquier

Copy link
Copy Markdown
Contributor Author

/test e2e-aws-ovn-techpreview

@danielmellado

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2026
@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [danielmellado,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danielmellado

Copy link
Copy Markdown
Contributor

/test e2e-aws-ovn-techpreview

@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

@simonpasquier: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@simonpasquier

Copy link
Copy Markdown
Contributor Author

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 2, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@simonpasquier: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 55b3375 into openshift:main Jul 2, 2026
22 checks passed
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@simonpasquier: Jira Issue Verification Checks: Jira Issue OCPBUGS-93756
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-93756 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants