Skip to content

Conversation

@simonpasquier
Copy link
Contributor

@simonpasquier simonpasquier commented Sep 17, 2025

It doesn't update all dependencies to their latest dependencies because the replace directives complicate the operation (we need the forks to be aligned with upstream).

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci-robot
Copy link
Contributor

@simonpasquier: This pull request explicitly references no jira issue.

In response to this:

It doesn't update all dependencies to their latest dependencies because the replace directives complicate the operation (we need the forks to be aligned with upstream).

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 17, 2025
@openshift-ci openshift-ci bot requested review from jan--f and rexagod September 17, 2025 13:57
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2025
@simonpasquier simonpasquier force-pushed the update-go-deps branch 2 times, most recently from 5ab1a52 to f8a4a5f Compare September 17, 2025 15:19
@jan--f
Copy link
Contributor

jan--f commented Sep 18, 2025

/lgtm
/verified by ci/prow/e2e-aws-ovn

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 18, 2025
@openshift-ci-robot
Copy link
Contributor

@jan--f: This PR has been marked as verified by ci/prow/e2e-aws-ovn.

In response to this:

/lgtm
/verified by ci/prow/e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jan--f,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonpasquier
Copy link
Contributor Author

/restest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD ea9a533 and 2 for PR HEAD be8e628 in total

@simonpasquier
Copy link
Contributor Author

/test ci/prow/ginkgo-tests

@simonpasquier
Copy link
Contributor Author

/test ginkgo-tests

@simonpasquier
Copy link
Contributor Author

/skip

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2025

@simonpasquier: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-agnostic-operator
/test e2e-aws-ovn
/test e2e-aws-ovn-techpreview
/test e2e-aws-ovn-upgrade
/test e2e-hypershift-conformance
/test generate
/test ginkgo-tests
/test go-fmt
/test golangci-lint
/test images
/test jsonnet-fmt
/test okd-scos-images
/test rules
/test shellcheck
/test unit
/test vendor
/test verify
/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-aws-ovn-single-node
/test okd-scos-e2e-aws-ovn
/test versions

Use /test all to run all jobs.

In response to this:

/test ci/prow/ginkgo-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@simonpasquier
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2025

@simonpasquier: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn be8e628 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e7abc6a into openshift:main Sep 18, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants