MON-4288: set up openshift-tests-extension and add a sanity test #2616

machine424 · 2025-07-08T21:19:21Z

the extension is to be registered here openshift/origin#29974

I added CHANGELOG entry for this change.
No user facing changes, so no entry in CHANGELOG was needed.

machine424 · 2025-07-08T21:33:30Z

/testwith openshift/cluster-monitoring-operator/main/e2e-aws-ovn openshift/origin#29974
/testwith openshift/cluster-monitoring-operator/main/e2e-aws-ovn-single-node openshift/origin#29974
/testwith openshift/cluster-monitoring-operator/main/e2e-aws-ovn-techpreview openshift/origin#29974
/testwith openshift/cluster-monitoring-operator/main/e2e-aws-ovn-upgrade openshift/origin#29974
/testwith openshift/cluster-monitoring-operator/main/e2e-hypershift-conformance openshift/origin#29974

machine424 · 2025-07-08T21:36:08Z

/payload-with-prs 4.20 nightly blocking openshift/must-gather#498

openshift-ci · 2025-07-08T21:36:13Z

@machine424: trigger 11 job(s) of type blocking for the nightly release of OCP 4.20

periodic-ci-openshift-release-master-ci-4.20-e2e-aws-upgrade-ovn-single-node
periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-upgrade-fips
periodic-ci-openshift-release-master-ci-4.20-e2e-azure-ovn-upgrade
periodic-ci-openshift-release-master-ci-4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-rt-upgrade
periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn-conformance
periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial
periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview
periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial
periodic-ci-openshift-release-master-nightly-4.20-fips-payload-scan
periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-bm
periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8fd87fe0-5c43-11f0-8b54-23d24fc88994-0

machine424 · 2025-07-08T21:36:14Z

/payload-with-prs 4.20 ci blocking openshift/origin#29974

openshift-ci · 2025-07-08T21:36:18Z

@machine424: trigger 4 job(s) of type blocking for the ci release of OCP 4.20

periodic-ci-openshift-release-master-ci-4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade
periodic-ci-openshift-release-master-ci-4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade
periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-upgrade
periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/940efda0-5c43-11f0-9436-fd13a7987086-0

test/ext/sanity.go

machine424 · 2025-07-09T15:36:16Z

/testwith openshift/cluster-monitoring-operator/main/e2e-aws-ovn-techpreview openshift/origin#29975

machine424 · 2025-07-09T15:36:34Z

/testwith openshift/cluster-monitoring-operator/main/e2e-aws-ovn-techpreview openshift/origin#29975

machine424 · 2025-07-09T16:31:12Z

/testwith openshift/cluster-monitoring-operator/main/e2e-aws-ovn-techpreview openshift/origin#29975

juzhao · 2025-07-10T01:34:28Z

/retest

juzhao · 2025-07-10T02:06:13Z

/lgtm
thanks a lot!

machine424 · 2025-07-10T06:40:15Z

needs #2611

machine424 · 2025-07-10T07:11:45Z

/retitle /MON-4288: set up openshift-tests-extension and add a sanity test

machine424 · 2025-07-10T07:11:56Z

/retitle MON-4288: set up openshift-tests-extension and add a sanity test

openshift-ci-robot · 2025-07-10T07:11:57Z

@machine424: This pull request references MON-4288 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

the extension is to be registered here openshift/origin#29974

I added CHANGELOG entry for this change.

No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

juzhao · 2025-07-10T08:17:59Z

/lgtm

openshift-ci-robot · 2025-07-10T09:11:20Z

/retest-required

Remaining retests: 0 against base HEAD 09f9bc0 and 2 for PR HEAD a75fb2a in total

stbenjam · 2025-07-10T10:20:52Z

cmd/tests-ext/main.go

+	ext := e.NewExtension("openshift", "payload", "cluster-monitoring-operator")
+	ext.AddSuite(e.Suite{
+		Name: "openshift/cluster-monitoring-operator/conformance/parallel",
+		// Has no effect for now, the test's name must still contain [Suite:openshift/conformance/parallel]


This does work now, you can drop the [Suite: annotation from the test name

Great! I assume thanks to openshift/origin#29888.
I'll give that a try and adjust the PR accordingly.

If I understand correctly, we're just passing qualifiers to parents.
In our case we'll still need to add [Suite:openshift/cluster-monitoring-operator/conformance/parallel to the test name and also have a name.contains qualifier for that?

machine424 · 2025-07-10T11:20:37Z

/testwith openshift/cluster-monitoring-operator/main/e2e-aws-ovn openshift/origin#29974
/testwith openshift/cluster-monitoring-operator/main/e2e-aws-ovn-single-node openshift/origin#29974
/testwith openshift/cluster-monitoring-operator/main/e2e-aws-ovn-techpreview openshift/origin#29974
/testwith openshift/cluster-monitoring-operator/main/e2e-aws-ovn-upgrade openshift/origin#29974
/testwith openshift/cluster-monitoring-operator/main/e2e-hypershift-conformance openshift/origin#29974

Makefile

machine424 · 2025-07-10T21:25:09Z

/testwith openshift/cluster-monitoring-operator/main/e2e-aws-ovn openshift/origin#29974
/testwith openshift/cluster-monitoring-operator/main/e2e-aws-ovn-single-node openshift/origin#29974
/testwith openshift/cluster-monitoring-operator/main/e2e-aws-ovn-techpreview openshift/origin#29974
/testwith openshift/cluster-monitoring-operator/main/e2e-aws-ovn-upgrade openshift/origin#29974
/testwith openshift/cluster-monitoring-operator/main/e2e-hypershift-conformance openshift/origin#29974

juzhao · 2025-07-11T02:33:36Z

/retest

juzhao · 2025-07-11T06:09:58Z

vendor job failed

diff --git a/go.mod b/go.mod
index aef0aaa22..fa855c53e 100644
--- a/go.mod
+++ b/go.mod
@@ -15,6 +15,8 @@ require (
 	github.com/google/uuid v1.6.0
 	github.com/imdario/mergo v0.3.16
 	github.com/mattn/go-shellwords v1.0.12
+	github.com/onsi/ginkgo/v2 v2.22.0
+	github.com/onsi/gomega v1.36.1
 	github.com/openshift-eng/openshift-tests-extension v0.0.0-20250702172817-97309544869d
 	github.com/openshift/api v0.0.0-20250320170726-75d64d71980b
 	github.com/openshift/client-go v0.0.0-20250125113824-8e1f0b8fa9a7
@@ -107,8 +109,6 @@ require (
 	github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
 	github.com/mwitkow/go-conntrack v0.0.0-20190716064945-2f068394615f // indirect
 	github.com/oklog/ulid v1.3.1 // indirect
-	github.com/onsi/ginkgo/v2 v2.22.0 // indirect
-	github.com/onsi/gomega v1.36.1 // indirect
 	github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c // indirect
 	github.com/pkg/errors v0.9.1 // indirect
 	github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect

maybe need to run go mod tidy to fix

juzhao · 2025-07-11T14:19:20Z

/lgtm

openshift-ci · 2025-07-11T14:20:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juzhao, machine424

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [machine424]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-07-11T18:36:51Z

/retest-required

Remaining retests: 0 against base HEAD 26f9666 and 2 for PR HEAD 3a14395 in total

juzhao · 2025-07-14T01:25:55Z

/retest

juzhao · 2025-07-14T08:25:03Z

/retest-required

juzhao · 2025-07-14T13:25:02Z

/retest-required

openshift-ci-robot · 2025-07-14T16:57:17Z

/retest-required

Remaining retests: 0 against base HEAD 26f9666 and 2 for PR HEAD 3a14395 in total

juzhao · 2025-07-15T02:24:30Z

/retest-required

openshift-ci · 2025-07-15T05:26:44Z

@machine424: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`3a14395`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/e2e-aws-ovn-single-node	`3a14395`	link	false	`/test e2e-aws-ovn-single-node`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

juzhao · 2025-07-15T06:48:04Z

/retest-required

openshift-bot · 2025-07-15T16:40:38Z

[ART PR BUILD NOTIFIER]

Distgit: cluster-monitoring-operator
This PR has been included in build cluster-monitoring-operator-container-v4.20.0-202507151447.p0.g2513cbe.assembly.stream.el9.
All builds following this will include this PR.

openshift-ci · 2025-08-04T22:16:18Z

@machine424: trigger 10 job(s) of type blocking for the nightly release of OCP 4.20

periodic-ci-openshift-release-master-ci-4.20-e2e-aws-upgrade-ovn-single-node
periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-upgrade-fips
periodic-ci-openshift-release-master-ci-4.20-e2e-azure-ovn-upgrade
periodic-ci-openshift-release-master-ci-4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-rt-upgrade
periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn-conformance
periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial
periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview
periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial
periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-bm
periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a37260a0-7180-11f0-8659-9f6e4ef903a8-0

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2025

machine424 mentioned this pull request Jul 8, 2025

MON-4288: register CMO tests extension openshift/origin#29974

Merged

openshift-ci bot requested review from simonpasquier and slashpai July 8, 2025 21:20

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2025

machine424 force-pushed the extd branch from 96d73d7 to cb2bce7 Compare July 8, 2025 21:28

machine424 commented Jul 9, 2025

View reviewed changes

test/ext/sanity.go Outdated Show resolved Hide resolved

machine424 force-pushed the extd branch from cb2bce7 to e0cb54a Compare July 9, 2025 16:30

openshift-ci bot assigned juzhao Jul 10, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2025

openshift-ci bot changed the title ~~WIP: set up openshift-tests-extension and add a sanity test~~ /MON-4288: set up openshift-tests-extension and add a sanity test Jul 10, 2025

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 10, 2025

openshift-ci bot changed the title ~~/MON-4288: set up openshift-tests-extension and add a sanity test~~ MON-4288: set up openshift-tests-extension and add a sanity test Jul 10, 2025

machine424 force-pushed the extd branch from e0cb54a to a75fb2a Compare July 10, 2025 07:20

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2025

stbenjam reviewed Jul 10, 2025

View reviewed changes

machine424 force-pushed the extd branch from a75fb2a to 3044884 Compare July 10, 2025 11:20

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2025

machine424 commented Jul 10, 2025

View reviewed changes

Makefile Outdated Show resolved Hide resolved

machine424 force-pushed the extd branch from 3044884 to a4725c6 Compare July 10, 2025 21:22

set up openshift-tests-extension and add a sanity test

3a14395

machine424 force-pushed the extd branch from a4725c6 to 3a14395 Compare July 11, 2025 07:58

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2025

openshift-merge-bot bot merged commit 2513cbe into openshift:main Jul 15, 2025
18 of 20 checks passed

openshift-ci bot mentioned this pull request Aug 4, 2025

ETCD-738: Partial Revert of #489 openshift/must-gather#498

Merged

MON-4288: set up openshift-tests-extension and add a sanity test #2616

MON-4288: set up openshift-tests-extension and add a sanity test #2616

Uh oh!

Conversation

machine424 commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

machine424 commented Jul 8, 2025

Uh oh!

machine424 commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Jul 8, 2025

Uh oh!

machine424 commented Jul 8, 2025

Uh oh!

openshift-ci bot commented Jul 8, 2025

Uh oh!

Uh oh!

machine424 commented Jul 9, 2025

Uh oh!

machine424 commented Jul 9, 2025

Uh oh!

machine424 commented Jul 9, 2025

Uh oh!

juzhao commented Jul 10, 2025

Uh oh!

juzhao commented Jul 10, 2025

Uh oh!

machine424 commented Jul 10, 2025

Uh oh!

machine424 commented Jul 10, 2025

Uh oh!

machine424 commented Jul 10, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 10, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

juzhao commented Jul 10, 2025

Uh oh!

openshift-ci-robot commented Jul 10, 2025

Uh oh!

stbenjam Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

machine424 Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

machine424 Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

machine424 commented Jul 10, 2025

Uh oh!

Uh oh!

machine424 commented Jul 10, 2025

Uh oh!

juzhao commented Jul 11, 2025

Uh oh!

juzhao commented Jul 11, 2025

Uh oh!

juzhao commented Jul 11, 2025

Uh oh!

openshift-ci bot commented Jul 11, 2025

Uh oh!

openshift-ci-robot commented Jul 11, 2025

Uh oh!

juzhao commented Jul 14, 2025

Uh oh!

juzhao commented Jul 14, 2025

Uh oh!

juzhao commented Jul 14, 2025

Uh oh!

openshift-ci-robot commented Jul 14, 2025

Uh oh!

juzhao commented Jul 15, 2025

Uh oh!

openshift-ci bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

machine424 commented Jul 8, 2025 •

edited

Loading

machine424 commented Jul 8, 2025 •

edited

Loading

machine424 commented Jul 10, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jul 10, 2025 •

edited by openshift-ci bot

Loading

machine424 Jul 10, 2025 •

edited

Loading

openshift-ci bot commented Jul 15, 2025 •

edited

Loading