4.13: OCPBUGS-11294: Add vSphere CSI migration to telemetry by jsafrane · Pull Request #1929 · openshift/cluster-monitoring-operator

jsafrane · 2023-03-30T10:17:29Z

I added CHANGELOG entry for this change.
No user facing changes, so no entry in CHANGELOG was needed.

Add vsphere_csi_migration to telemetry in 4.13.

WIP:

~~Testing, Jira will follow soon.~~ Tested OK with the PR below.
Needs OCPBUGS-11294: Add CSI migration metric vmware-vsphere-csi-driver-operator#146 merged first.

openshift-ci · 2023-03-30T10:17:33Z

@jsafrane: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

WIP: Add vSphere CSI migration to telemetry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-30T15:54:54Z

@jsafrane: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

WIP: Add vSphere CSI migration to telemetry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jan--f

This looks good, just one request to make things easier for future readers.

jan--f · 2023-03-31T14:50:32Z

          record: 'cluster:vsphere_infrastructure_failure_domains:max',
        },
+        {
+          expr: 'max by(status)(vsphere_csi_migration)',


Suggested change

expr: 'max by(status)(vsphere_csi_migration)',

expr: 'max by(status)vsphere_csi_migration{status=~"|LegacyDeprecatedInTreeDriver|CSIWithMigrationDriver"})',

Since we already know the possible label value set, lets be explicit here. I understand this is also constrained on the openshift/api level, but we'd like to establish this sort of aggressive cardinality specification for telemetry rules.

openshift-ci · 2023-04-03T11:07:21Z

@jsafrane: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

WIP: 4.13: Add vSphere CSI migration to telemetry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Add vsphere_csi_migration to telemetry. This will show how many clusters have opted into CSI migration on vSphere. This applies to 4.13 only. In 4.14 CSI migration is force enabled and there is nothing to report.

simonpasquier · 2023-04-03T14:20:34Z

        },
+        {
+          expr: 'max by(status)(vsphere_csi_migration{status=~"|LegacyDeprecatedInTreeDriver|CSIWithMigrationDriver"})',
+          record: 'cluster:vsphere_csi_migration:max',


Could the rule be moved to https://github.com/openshift/vmware-vsphere-csi-driver-operator? This way clusters that don't run the vsphere CSI operator won't have this additional rule.

Yes, eventually. I created https://issues.redhat.com/browse/STOR-1289.

openshift-ci · 2023-04-03T14:52:50Z

@jsafrane: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

4.13: OCPBUGS-11294: Add vSphere CSI migration to telemetry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-04-03T14:52:52Z

@jsafrane: This pull request references Jira Issue OCPBUGS-11294, which is invalid:

expected dependent Jira Issue OCPBUGS-11269 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

I added CHANGELOG entry for this change.

No user facing changes, so no entry in CHANGELOG was needed.

Add vsphere_csi_migration to telemetry in 4.13.

WIP:

~~Testing, Jira will follow soon.~~ Tested OK with the PR below.

Needs OCPBUGS-11294: Add CSI migration metric vmware-vsphere-csi-driver-operator#146 merged first.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jsafrane · 2023-04-05T11:07:31Z

/jira refresh
/retest-required

I am not sure about ci/prow/versions - should I fix anything?

openshift-ci-robot · 2023-04-05T11:07:38Z

@jsafrane: This pull request references Jira Issue OCPBUGS-11294, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-11269 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-11269 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

Details

In response to this:

/jira refresh
/retest-required

I am not sure about ci/prow/versions - should I fix anything?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jsafrane · 2023-04-05T11:08:04Z

/hold
for openshift/vmware-vsphere-csi-driver-operator#146 to merge

jan--f · 2023-04-05T12:16:33Z

I am not sure about ci/prow/versions - should I fix anything?

No need, only the required checks need to succeed.

jan--f · 2023-04-05T12:19:05Z

/label backport-risk-assessed
/lgtm
Feel free to unhold once the blocking PR merged.

openshift-ci · 2023-04-05T12:22:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jan--f]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jsafrane · 2023-04-06T09:20:30Z

/retest-required

openshift-ci · 2023-04-06T11:48:27Z

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/versions	`59bbb32`	link	false	`/test versions`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

simonpasquier · 2023-04-07T09:19:30Z

/skip

the versions job isn't required.

simonpasquier · 2023-04-07T09:20:22Z

/retest-required

ropatil010 · 2023-04-20T10:36:33Z

/label cherry-pick-approved

openshift-ci · 2023-04-20T10:36:35Z

@ropatil010: Can not set label cherry-pick-approved: Must be member in one of these teams: []

Details

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jsafrane · 2023-04-27T13:11:56Z

/hold cancel
openshift/vmware-vsphere-csi-driver-operator#146 is merged

sthaha · 2023-05-02T01:47:24Z

/label cherry-pick-approved

openshift-ci · 2023-05-02T01:47:27Z

@sthaha: Can not set label cherry-pick-approved: Must be member in one of these teams: []

Details

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

juzhao · 2023-05-04T07:53:47Z

@jsafrane I am afraid you need to submit one PR to telemeter server, since "cluster:vsphere_csi_migration:max" is not in telemeter server allow list
https://github.com/rhobs/configuration/blob/main/configuration/telemeter/metrics.json
CMO PR is fine, add
/label cherry-pick-approved

openshift-ci-robot · 2023-05-04T10:57:37Z

@jsafrane: Jira Issue OCPBUGS-11294: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-11294 has been moved to the MODIFIED state.

Details

In response to this:

I added CHANGELOG entry for this change.

No user facing changes, so no entry in CHANGELOG was needed.

Add vsphere_csi_migration to telemetry in 4.13.

WIP:

~~Testing, Jira will follow soon.~~ Tested OK with the PR below.

Needs OCPBUGS-11294: Add CSI migration metric vmware-vsphere-csi-driver-operator#146 merged first.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2023

openshift-ci Bot requested review from simonpasquier and slashpai March 30, 2023 10:17

jsafrane force-pushed the add-csimigration-telemetry branch from 1dcdd68 to fbd1264 Compare March 30, 2023 12:38

jan--f requested changes Mar 31, 2023

View reviewed changes

jsafrane force-pushed the add-csimigration-telemetry branch from fbd1264 to 2d726ce Compare April 3, 2023 11:06

jsafrane changed the title ~~WIP: Add vSphere CSI migration to telemetry~~ WIP: 4.13: Add vSphere CSI migration to telemetry Apr 3, 2023

Add CSI migration for vSphere to telemetry

59bbb32

Add vsphere_csi_migration to telemetry. This will show how many clusters have opted into CSI migration on vSphere. This applies to 4.13 only. In 4.14 CSI migration is force enabled and there is nothing to report.

jsafrane force-pushed the add-csimigration-telemetry branch from 2d726ce to 59bbb32 Compare April 3, 2023 11:17

simonpasquier reviewed Apr 3, 2023

View reviewed changes

jsafrane changed the title ~~WIP: 4.13: Add vSphere CSI migration to telemetry~~ 4.13: OCPBUGS-11294: Add vSphere CSI migration to telemetry Apr 3, 2023

openshift-ci-robot added the jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. label Apr 3, 2023

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2023

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 3, 2023

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 5, 2023

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 5, 2023

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2023

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 5, 2023

openshift-ci Bot assigned jan--f Apr 5, 2023

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2023

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2023

openshift-ci-robot mentioned this pull request Apr 25, 2023

OCPBUGS-11294: Add CSI migration metric openshift/vmware-vsphere-csi-driver-operator#146

Merged

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2023

openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 4, 2023

openshift-merge-robot merged commit e537312 into openshift:release-4.13 May 4, 2023

	expr: 'max by(status)(vsphere_csi_migration)',
	expr: 'max by(status)vsphere_csi_migration{status=~"\|LegacyDeprecatedInTreeDriver\|CSIWithMigrationDriver"})',

Conversation

jsafrane commented Mar 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Mar 30, 2023

Uh oh!

openshift-ci Bot commented Mar 30, 2023

Uh oh!

jan--f left a comment

Choose a reason for hiding this comment

Uh oh!

jan--f Mar 31, 2023

Choose a reason for hiding this comment

Uh oh!

jsafrane Apr 3, 2023

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Apr 3, 2023

Uh oh!

simonpasquier Apr 3, 2023

Choose a reason for hiding this comment

Uh oh!

jsafrane Apr 4, 2023

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Apr 3, 2023

Uh oh!

openshift-ci-robot commented Apr 3, 2023

Uh oh!

jsafrane commented Apr 5, 2023

Uh oh!

openshift-ci-robot commented Apr 5, 2023

Uh oh!

jsafrane commented Apr 5, 2023

Uh oh!

jan--f commented Apr 5, 2023

Uh oh!

jan--f commented Apr 5, 2023

Uh oh!

openshift-ci Bot commented Apr 5, 2023

Uh oh!

jsafrane commented Apr 6, 2023

Uh oh!

openshift-ci Bot commented Apr 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simonpasquier commented Apr 7, 2023

Uh oh!

simonpasquier commented Apr 7, 2023

Uh oh!

ropatil010 commented Apr 20, 2023

Uh oh!

openshift-ci Bot commented Apr 20, 2023

Uh oh!

jsafrane commented Apr 27, 2023

Uh oh!

sthaha commented May 2, 2023

Uh oh!

openshift-ci Bot commented May 2, 2023

Uh oh!

juzhao commented May 4, 2023

Uh oh!

openshift-ci-robot commented May 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jsafrane commented Mar 30, 2023 •

edited

Loading

openshift-ci Bot commented Apr 6, 2023 •

edited

Loading