jsonnet: add named tenancy port#183
Merged
openshift-merge-robot merged 2 commits intoDec 13, 2018
Merged
Conversation
It is declared in the service but not in the kube-rbac-proxy sidecar.
openshift-ci-robot
added
the
size/L
openshift-ci-robot
added
the
approved
Contributor
Author
|
/hold |
Contributor
|
/lgtm cancel |
openshift-ci-robot
added
the
do-not-merge/hold
Contributor
Author
|
@squat: @metalmatze raised concerns about the grafana bump, I'll change this PR to only consider the target port changes. |
s-urbaniak
force-pushed
the
fix-tenancy-port
branch
from
f661eb2 to
15ee4e4
Compare
openshift-ci-robot
added
size/S
Contributor
Author
|
@metalmatze PTAL |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalmatze, s-urbaniak, squat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/retest |
2 similar comments
Contributor
|
/retest |
Contributor
Author
|
/retest |
Member
|
@s-urbaniak did you mean to leave the hold on this pr? |
Contributor
Author
|
@spadgett the PR is LGTM'ed, but we're having flakes on e2e :-/ |
Contributor
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Contributor
Author
|
@spadgett flakes resolved, this is merged now :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is declared in the service but not in the kube-rbac-proxy sidecar.
cc @metalmatze @squat