Skip to content

Documentation/data-collection: Collect cluster_version_capability#1607

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
wking:export-cluster_version_capabilites
Mar 30, 2022
Merged

Documentation/data-collection: Collect cluster_version_capability#1607
openshift-merge-robot merged 1 commit into
openshift:masterfrom
wking:export-cluster_version_capabilites

Conversation

@wking

@wking wking commented Mar 23, 2022

Copy link
Copy Markdown
Member

Builds on #1606; possibly review that one first.

The cluster-version operator is growing this new metric in openshift/cluster-version-operator#755, and @bparees wants it included in Telemetry so we collect it for clusters that have Telemetry enabled, even if Insights is disabled. Cardinality is expected to be very small, with a single label (name) and a restricted value set (only three registered capabilities expected for 4.11).

@openshift-ci openshift-ci Bot requested review from bison and jan--f March 23, 2022 06:14
@wking wking force-pushed the export-cluster_version_capabilites branch from cb2f879 to f0a8051 Compare March 23, 2022 07:07
@jan--f

jan--f commented Mar 23, 2022

Copy link
Copy Markdown
Contributor

/lgtm
/label docs-approved
/label px-approved
/label qe-approved
/hold
until #1606 is merged.

@wking

wking commented Mar 28, 2022

Copy link
Copy Markdown
Member Author

/hold cancel

@wking

wking commented Mar 30, 2022

Copy link
Copy Markdown
Member Author

/retest

@jan--f , looks like your label requests didn't stick? Can you add them again?

The cluster-version operator is growing this new metric [1], and Ben
Parees wants it included in Telemetry so we collect it for clusters
that have Telemetry enabled, even if Insights is disabled [2].
Cardinality is expected to be very small, with a single label ('name'
[1]) and a restricted value set (only three registered capabilities
expected for 4.11).

[1]: openshift/cluster-version-operator#755
[2]: openshift/enhancements#922 (comment)
@wking wking force-pushed the export-cluster_version_capabilites branch from f0a8051 to ebdc1ae Compare March 30, 2022 06:14
@wking

wking commented Mar 30, 2022

Copy link
Copy Markdown
Member Author

I guess with no lgtm label yet to blow away, I might as well rebase on master to show that we're down to one new commit here, so I've done that with f0a8051 -> ebdc1ae.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2022
@jan--f

jan--f commented Mar 30, 2022

Copy link
Copy Markdown
Contributor

/lgtm
/label docs-approved
/label px-approved
/label qe-approved

@openshift-ci openshift-ci Bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Mar 30, 2022
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2022
@openshift-ci

openshift-ci Bot commented Mar 30, 2022

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot

Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci

openshift-ci Bot commented Mar 30, 2022

Copy link
Copy Markdown
Contributor

@wking: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node ebdc1ae link false /test e2e-aws-single-node
ci/prow/versions ebdc1ae link false /test versions

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 51722cf into openshift:master Mar 30, 2022
@wking wking deleted the export-cluster_version_capabilites branch March 31, 2022 17:36
wking added a commit to wking/red-hat-observability-configuration that referenced this pull request Mar 31, 2022
It was recently added to the metrics the Telemetry client submits in
[1].

[1]: openshift/cluster-monitoring-operator#1607
wking added a commit to wking/red-hat-observability-configuration that referenced this pull request Mar 31, 2022
It was recently added to the metrics the Telemetry client submits in
[1].

[1]: openshift/cluster-monitoring-operator#1607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants