Bug 1978091: fix node_exporter recording rules for cluster network dashboards #1296
Conversation
Prometheus scrapes node_exporter every 15 seconds so the associated recording rules can use a range interval value of 1m instead of the default 5m. It also fixes an issue with the cluster network dashboard in the OCP console because it queries the instance:node_network_*_bytes_excluding_lo:rate1m metrics. Signed-off-by: Simon Pasquier <[email protected]>
openshift-ci
bot
added
bugzilla/severity-medium
|
@simonpasquier: This pull request references Bugzilla bug 1978091, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
/assign @paulfantom |
|
@simonpasquier: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paulfantom, PhilipGough, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@simonpasquier: All pull requests linked via external trackers have merged: Bugzilla bug 1978091 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
#1214 introduced a change in the node_exporter recording rules that breaks the console. And since node_exporter metrics are scraped every 15 seconds, a time range of 1m is a correct choice.