Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
/machine-approver
/machine-approver
*.idea*
14 changes: 9 additions & 5 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
FROM registry.svc.ci.openshift.org/openshift/release:golang-1.10 AS builder
COPY . /go/src/github.com/openshift/cluster-machine-appover
RUN cd /go/src/github.com/openshift/cluster-machine-appover && go build -o machine-approver .
#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This less consistent with our default pattern than the previous (which was also not correct)

See https://github.com/openshift/cluster-version-operator/blob/master/Dockerfile for the standard format, you should only have to change the RUN line in the builder and insert your custom steps after the COPY line in the runtime image.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

# The standard name for this image is openshift/origin-cluster-machine-approver
#
FROM openshift/origin-release:golang-1.10
COPY . /go/src/github.com/openshift/cluster-machine-approver
RUN cd /go/src/github.com/openshift/cluster-machine-approver && go build ./cmd/machine-approver

FROM centos:7
COPY --from=0 /go/src/github.com/openshift/cluster-machine-approver/machine-approver /usr/bin/machine-approver

FROM registry.svc.ci.openshift.org/openshift/origin-v4.0:base
COPY --from=builder /go/src/github.com/openshift/cluster-machine-appover/machine-approver /usr/bin/machine-approver
COPY manifests /manifests
LABEL io.openshift.release.operator true
48 changes: 48 additions & 0 deletions cmd/machine-approver/main.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
package main

import (
goflag "flag"
"fmt"
"math/rand"
"os"
"time"

"github.com/spf13/cobra"
"github.com/spf13/pflag"

utilflag "k8s.io/apiserver/pkg/util/flag"
"k8s.io/apiserver/pkg/util/logs"

"github.com/openshift/cluster-machine-approver/pkg/cmd/operator"
)

func main() {
rand.Seed(time.Now().UTC().UnixNano())

pflag.CommandLine.SetNormalizeFunc(utilflag.WordSepNormalizeFunc)
pflag.CommandLine.AddGoFlagSet(goflag.CommandLine)

logs.InitLogs()
defer logs.FlushLogs()

command := NewMachineApproverOperatorCommand()
if err := command.Execute(); err != nil {
fmt.Fprintf(os.Stderr, "%v\n", err)
os.Exit(1)
}
}

func NewMachineApproverOperatorCommand() *cobra.Command {
cmd := &cobra.Command{
Use: "machine-approver",
Short: "OpenShift osin OAuth server operator",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder to update.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you didn't fix this.

Run: func(cmd *cobra.Command, args []string) {
cmd.Help()
os.Exit(1)
},
}

cmd.AddCommand(operator.NewOperator())

return cmd
}
Loading