-
Notifications
You must be signed in to change notification settings - Fork 76
Operator restructure #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
The diff you're trying to view is too large. We only load the first 3000 changed files.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| /machine-approver | ||
| /machine-approver | ||
| *.idea* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,12 @@ | ||
| FROM registry.svc.ci.openshift.org/openshift/release:golang-1.10 AS builder | ||
| COPY . /go/src/github.com/openshift/cluster-machine-appover | ||
| RUN cd /go/src/github.com/openshift/cluster-machine-appover && go build -o machine-approver . | ||
| # | ||
| # The standard name for this image is openshift/origin-cluster-machine-approver | ||
| # | ||
| FROM openshift/origin-release:golang-1.10 | ||
| COPY . /go/src/github.com/openshift/cluster-machine-approver | ||
| RUN cd /go/src/github.com/openshift/cluster-machine-approver && go build ./cmd/machine-approver | ||
|
|
||
| FROM centos:7 | ||
| COPY --from=0 /go/src/github.com/openshift/cluster-machine-approver/machine-approver /usr/bin/machine-approver | ||
|
|
||
| FROM registry.svc.ci.openshift.org/openshift/origin-v4.0:base | ||
| COPY --from=builder /go/src/github.com/openshift/cluster-machine-appover/machine-approver /usr/bin/machine-approver | ||
| COPY manifests /manifests | ||
| LABEL io.openshift.release.operator true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| package main | ||
|
|
||
| import ( | ||
| goflag "flag" | ||
| "fmt" | ||
| "math/rand" | ||
| "os" | ||
| "time" | ||
|
|
||
| "github.com/spf13/cobra" | ||
| "github.com/spf13/pflag" | ||
|
|
||
| utilflag "k8s.io/apiserver/pkg/util/flag" | ||
| "k8s.io/apiserver/pkg/util/logs" | ||
|
|
||
| "github.com/openshift/cluster-machine-approver/pkg/cmd/operator" | ||
| ) | ||
|
|
||
| func main() { | ||
| rand.Seed(time.Now().UTC().UnixNano()) | ||
|
|
||
| pflag.CommandLine.SetNormalizeFunc(utilflag.WordSepNormalizeFunc) | ||
| pflag.CommandLine.AddGoFlagSet(goflag.CommandLine) | ||
|
|
||
| logs.InitLogs() | ||
| defer logs.FlushLogs() | ||
|
|
||
| command := NewMachineApproverOperatorCommand() | ||
| if err := command.Execute(); err != nil { | ||
| fmt.Fprintf(os.Stderr, "%v\n", err) | ||
| os.Exit(1) | ||
| } | ||
| } | ||
|
|
||
| func NewMachineApproverOperatorCommand() *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "machine-approver", | ||
| Short: "OpenShift osin OAuth server operator", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. reminder to update.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like you didn't fix this. |
||
| Run: func(cmd *cobra.Command, args []string) { | ||
| cmd.Help() | ||
| os.Exit(1) | ||
| }, | ||
| } | ||
|
|
||
| cmd.AddCommand(operator.NewOperator()) | ||
|
|
||
| return cmd | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This less consistent with our default pattern than the previous (which was also not correct)
See https://github.com/openshift/cluster-version-operator/blob/master/Dockerfile for the standard format, you should only have to change the RUN line in the builder and insert your custom steps after the COPY line in the runtime image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍