Skip to content

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Oct 10, 2022

This was added in openshift/cluster-version-operator#821 to allow more featuresets and allow for a future migration to include actual gates. Because usage of this manifest would prevent upgrades, there are not upgrade concerns for this change.

@openshift-ci openshift-ci bot requested review from enxebre and lobziik October 10, 2022 15:19
@JoelSpeed
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 18dba4a and 2 for PR HEAD 7f7d418 in total

@deads2k deads2k added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 10, 2022
@deads2k
Copy link
Contributor Author

deads2k commented Oct 10, 2022

/retest

@JoelSpeed
Copy link
Contributor

/retest-required

@JoelSpeed
Copy link
Contributor

On the latest run, only 2 tests failed which were autoscaler tests, we know these are flaking and are working on improving them, I think this can merge safely

/override ci/prow/e2e-aws-operator

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-machine-approver/172/pull-ci-openshift-cluster-machine-approver-master-e2e-aws-operator/1579784005534879744

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2022

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-operator

Details

In response to this:

On the latest run, only 2 tests failed which were autoscaler tests, we know these are flaking and are working on improving them, I think this can merge safely

/override ci/prow/e2e-aws-operator

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-machine-approver/172/pull-ci-openshift-cluster-machine-approver-master-e2e-aws-operator/1579784005534879744

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2022

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-operator 7f7d418 link false /test e2e-azure-operator
ci/prow/e2e-gcp-operator 7f7d418 link false /test e2e-gcp-operator
ci/prow/e2e-aws-disruptive 7f7d418 link false /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k deads2k merged commit 93fac26 into openshift:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants