Skip to content

Define all flags before parsing flags #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Apr 6, 2022
Merged

Define all flags before parsing flags #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,13 @@ func main() {
flagSet.DurationVar(&leaderElectRetryPeriod, "leader-elect-retry-period", 26*time.Second, "the duration the LeaderElector clients should wait between tries of actions.")
flagSet.StringVar(&leaderElectResourceName, "leader-elect-resource-name", "cluster-machine-approver-leader", "the name of the resource that leader election will use for holding the leader lock.")
flagSet.StringVar(&leaderElectResourceNamespace, "leader-elect-resource-namespace", "openshift-cluster-machine-approver", "the namespace in which the leader election resource will be created.")
flagSet.Parse(os.Args[1:])

// Deprecated options
flagSet.StringVar(&apiGroup, "apigroup", "", "API group for machines")
flagSet.MarkDeprecated("apigroup", "apigroup has been deprecated in favor of api-group-version option")

flagSet.Parse(os.Args[1:])

if apiGroup != "" && len(apiGroupVersions) > 0 {
klog.Fatal("Cannot set both --apigroup and --api-group-version options together.")
}
Expand Down