Skip to content

README.md: Elaborate a bit more on node join #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 31, 2022
Merged

README.md: Elaborate a bit more on node join #150

openshift-merge-robot merged 1 commit into from
Jan 31, 2022

Conversation

@cgwalters
Copy link
Member

@cgwalters cgwalters commented Dec 17, 2021

This came up in the context of https://github.com/redhat-et/microshift

Let's cross-reference to the MCO and specifically the MCS code
which handles the token, since it's important to understand
specifically for OpenShift.

@cgwalters
README.md: Elaborate a bit more on node join
35def69 
This came up in the context of https://github.com/redhat-et/microshift

Let's cross-reference to the MCO and specifically the MCS code
which handles the token, since it's important to understand
specifically for OpenShift.
@cgwalters cgwalters mentioned this pull request Dec 17, 2021
Closed
@openshift-ci openshift-ci bot requested review from enxebre and lobziik December 17, 2021 16:49
@lobziik
Copy link
Contributor

lobziik commented Jan 12, 2022

/lgtm
/cc @elmiko @JoelSpeed

@openshift-ci openshift-ci bot requested review from JoelSpeed and elmiko January 12, 2022 10:55
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2022
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Jan 12, 2022

/approve
/skip as this is docs only, we don't need E2Es

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2022
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 12, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 12, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 12, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 12, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 12, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2022 •
edited
Loading

@cgwalters: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator 35def69 link false /test e2e-gcp-operator
ci/prow/e2e-azure-operator 35def69 link false /test e2e-azure-operator
ci/prow/e2e-aws-disruptive 35def69 link false /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 12, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Jan 12, 2022

/hold for 4.11 branch to open

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2022
elmiko
elmiko reviewed Jan 12, 2022
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my only concern is the deep link into the MCO code, since it might drift over time. but i think this is a solid improvement overall. thanks @lobziik
/lgtm

@lobziik
Copy link
Contributor

lobziik commented Jan 31, 2022

/hold cancel
4.11 should be open now

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2022
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 31, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 31, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e44b8bd into openshift:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enxebre enxebre Awaiting requested review from enxebre

@lobziik lobziik Awaiting requested review from lobziik

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

1 more reviewer

@elmiko elmiko elmiko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@elmiko elmiko

@lobziik lobziik

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cgwalters @lobziik @JoelSpeed @openshift-bot @elmiko @openshift-merge-robot