Skip to content

Bug 1994480: Update dependencies to K8s 1.22 #128

Merged
openshift-ci[bot] merged 4 commits intoopenshift:masterfrom
JoelSpeed:k8s-1.22
Aug 18, 2021
Merged

Bug 1994480: Update dependencies to K8s 1.22 #128
openshift-ci[bot] merged 4 commits intoopenshift:masterfrom
JoelSpeed:k8s-1.22

Conversation

@JoelSpeed
Copy link
Contributor

We should make sure our dependencies are up to date before the 4.9 code freeze

@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Aug 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2021

@JoelSpeed: This pull request references Bugzilla bug 1994480, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

Bug 1994480: Update dependencies to K8s 1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 17, 2021
@elmiko
Copy link
Contributor

elmiko commented Aug 17, 2021

although the cluster tests are all failing for various connectivity reasons (i suspect some flakes), the unit test failure is confusing to me. i tried to replicate locally, but am not getting the same error.

this seems to be common in the failures though,

make[1]: Entering directory `/go/src/github.com/openshift/cluster-machine-approver'
go test -v ./...
panic: mkdir /.cache: permission denied 

@JoelSpeed JoelSpeed force-pushed the k8s-1.22 branch 3 times, most recently from f57510a to 5553917 Compare August 18, 2021 08:23
When the HOME directory is unset or is set to /, kubebuilder tries to create a cache directory but fails. Make sure in these cases that we set it to a temp folder so that the test can create its cache
@JoelSpeed
Copy link
Contributor Author

although the cluster tests are all failing for various connectivity reasons (i suspect some flakes), the unit test failure is confusing to me. i tried to replicate locally, but am not getting the same error.

this seems to be common in the failures though,

make[1]: Entering directory `/go/src/github.com/openshift/cluster-machine-approver'
go test -v ./...
panic: mkdir /.cache: permission denied 

This should now be fixed by dc23c86

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 18, 2021

@JoelSpeed: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-disruptive dc23c86 link /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor Author

/override ci/prow/e2e-gcp-operator

The test itself passed, there's something broken about the teardown and gathering console logs

INFO[2021-08-18T09:16:21Z] Running step e2e-gcp-operator-test.          
INFO[2021-08-18T10:22:11Z] Step e2e-gcp-operator-test succeeded after 1h5m50s.

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-machine-approver/128/pull-ci-openshift-cluster-machine-approver-master-e2e-gcp-operator/1427913063352242176

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 18, 2021

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-gcp-operator

Details

In response to this:

/override ci/prow/e2e-gcp-operator

The test itself passed, there's something broken about the teardown and gathering console logs

INFO[2021-08-18T09:16:21Z] Running step e2e-gcp-operator-test.          
INFO[2021-08-18T10:22:11Z] Step e2e-gcp-operator-test succeeded after 1h5m50s.

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-machine-approver/128/pull-ci-openshift-cluster-machine-approver-master-e2e-gcp-operator/1427913063352242176

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2021
Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demichev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot merged commit 093c444 into openshift:master Aug 18, 2021
@JoelSpeed JoelSpeed deleted the k8s-1.22 branch August 18, 2021 14:05
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 18, 2021

@JoelSpeed: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1994480 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1994480: Update dependencies to K8s 1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants