Bug 1956609: Bypass cache when reading Node and Machine objects

[JoelSpeed]

We have observed that reading stale data for Machine and Node objects from the cache can cause node bootstrap failures as the approver does not recognise the correct links between CSRs, Machines and Nodes. To prevent reading stale data, only allow the client to return Machine and Node objetcs and lists directly from the API server instead of from the informer cache.

[openshift-ci]

@JoelSpeed: This pull request references Bugzilla bug 1956609, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.8.0) matches configured target release for branch (4.8.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

Bug 1956609: Bypass cache when reading Node and Machine objects

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[elmiko]

this makes sense to me, i don't suppose there is a meaningful way to test this in unit test? (seems like we'd just be duplicating whatever tests happen in controller-runtime)
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [elmiko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lobziik]

/lgtm

[openshift-ci]

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp-operator	a2fee48	link	/test e2e-gcp-operator
ci/prow/e2e-azure-operator	a2fee48	link	/test e2e-azure-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@JoelSpeed: All pull requests linked via external trackers have merged:

• openshift/cluster-machine-approver#121

Bugzilla bug 1956609 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1956609: Bypass cache when reading Node and Machine objects

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.