Skip to content

Upgrade library-go version#80

Merged
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
qJkee:CNF-3684-deps
Dec 15, 2021
Merged

Upgrade library-go version#80
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
qJkee:CNF-3684-deps

Conversation

@qJkee
Copy link
Copy Markdown
Contributor

@qJkee qJkee commented Dec 14, 2021 •
edited
Loading

Bumping the library-go dependency to latest, this should take advantage of leader election changes for SNO clusters proposed in this library-go PR and performance improvements in this PR.

  • bump go version in builder image

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 14, 2021
@openshift-ci openshift-ci Bot requested review from sttts and tkashem December 14, 2021 17:34
@qJkee qJkee force-pushed the CNF-3684-deps branch 2 times, most recently from 59eab8d to 8a7f073 Compare December 14, 2021 18:37
@qJkee qJkee changed the title [WIP] Upgrade library-go version Upgrade library-go version Dec 15, 2021
@qJkee
Copy link
Copy Markdown
Contributor Author

qJkee commented Dec 15, 2021

@sttts @tkashem could you please take a look?

@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2021
@tkashem
Copy link
Copy Markdown

tkashem commented Dec 15, 2021

/assign @sanchezl

sanchezl
sanchezl suggested changes Dec 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@sanchezl sanchezl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the go version in go.mod to 1.17 to match.

@qJkee
Copy link
Copy Markdown
Contributor Author

qJkee commented Dec 15, 2021

Hi @sanchezl !
I've updated go version in go.mod file

@qJkee qJkee requested a review from sanchezl December 15, 2021 16:51
@qJkee
Copy link
Copy Markdown
Contributor Author

qJkee commented Dec 15, 2021

/retest-required

sanchezl
sanchezl approved these changes Dec 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@sanchezl sanchezl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qJkee, sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 15, 2021

@qJkee: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 308a3ed into openshift:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sttts sttts Awaiting requested review from sttts

@tkashem tkashem Awaiting requested review from tkashem

1 more reviewer

@sanchezl sanchezl sanchezl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sanchezl sanchezl

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qJkee @tkashem @sanchezl @openshift-merge-robot