prevent panic in logging message #94
Conversation
openshift-ci-robot
added
the
size/XS
deads2k
added
approved
|
blocks config.openshift.io resource creation. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, ravisantoshgudimetla The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| } else { | ||
| klog.Infof("Error while getting scheduler type %v and using default algorithm provider in kubernetes scheduler", err.Error()) | ||
| msg := "unknown" | ||
| switch { |
There was a problem hiding this comment.
BTW, we're already checking for error here https://github.com/openshift/cluster-kube-scheduler-operator/pull/94/files#diff-c65577daa1eb9509fc39b6af03a81eeeR97, so perhaps removing err=nil in https://github.com/openshift/cluster-kube-scheduler-operator/pull/94/files#diff-c65577daa1eb9509fc39b6af03a81eeeR101 is ok and we can remove the switch altogether.
There was a problem hiding this comment.
BTW, we're already checking for error here https://github.com/openshift/cluster-kube-scheduler-operator/pull/94/files#diff-c65577daa1eb9509fc39b6af03a81eeeR97, so perhaps removing
err=nilin https://github.com/openshift/cluster-kube-scheduler-operator/pull/94/files#diff-c65577daa1eb9509fc39b6af03a81eeeR101 is ok and we can remove the switch altogether.
after openshift/cluster-config-operator#15 merges, feel free to refactor
|
unsticking pulls in other repos. merging |
|
@deads2k: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
3 participants
I've observed a panic from this line for logging that stopped my cluster from starting.