Skip to content

OCPBUGS-63213: Add priority field to prevent early shutdown #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 4 commits into from
Oct 14, 2025
Merged

OCPBUGS-63213: Add priority field to prevent early shutdown #572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
48e3986
Add priority field to prevent early shutdown
CoreyCook8 Aug 29, 2025
9209bc1
Update ks_pod_scenario_1.yaml
CoreyCook8 Oct 14, 2025
de62c2d
Update ks_pod_scenario_2.yaml
CoreyCook8 Oct 14, 2025
fe7d9e8
Update ks_pod_scenario_3.yaml
CoreyCook8 Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bindata/assets/kube-scheduler/pod.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ spec:
- mountPath: /etc/kubernetes/static-pod-certs
name: cert-dir
hostNetwork: true
priority: 2000001000
Copy link
Copy Markdown
Member

@ingvagabund ingvagabund Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Priority admission plugin mentions:

// if the pod contained a priority that differs from the one computed from the priority class, error

As long as the priority of system-node-critical PC does not change we are ok.

Copy link
Copy Markdown
Member

@ingvagabund ingvagabund Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CoreyCook8 we need to introduce a new e2e test under https://github.com/openshift/origin/tree/main/test/extended to make sure the priority number does not change for system-node-critical. Would you be willing to go through this exercise? :)

Copy link
Copy Markdown
Contributor Author

@CoreyCook8 CoreyCook8 Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 I created openshift/origin#30268 if you don't mind taking a look and giving an ok-to-test?

priorityClassName: system-node-critical
tolerations:
- operator: "Exists"
Expand Down
1 change: 1 addition & 0 deletions pkg/operator/targetconfigcontroller/testdata/ks_pod_scenario_1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,4 +146,5 @@ spec:
tolerations:
- operator: Exists
priorityClassName: system-node-critical
priority: 2000001000
status: {}
1 change: 1 addition & 0 deletions pkg/operator/targetconfigcontroller/testdata/ks_pod_scenario_2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,4 +147,5 @@ spec:
tolerations:
- operator: Exists
priorityClassName: system-node-critical
priority: 2000001000
status: {}
1 change: 1 addition & 0 deletions pkg/operator/targetconfigcontroller/testdata/ks_pod_scenario_3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,4 +148,5 @@ spec:
tolerations:
- operator: Exists
priorityClassName: system-node-critical
priority: 2000001000
status: {}