Bump openshift/api#359
Conversation
|
/assign @bertinatto |
damemi
left a comment
There was a problem hiding this comment.
--- FAIL: TestCheckForFeatureGates (0.00s)
--- FAIL: TestCheckForFeatureGates/techpreview (0.00s)
targetconfigcontroller_test.go:331: missing in actual: map[]
targetconfigcontroller_test.go:332: missing in expected: map[CSIMigrationAzureDisk:{} CSIMigrationGCE:{}]
targetconfigcontroller_test.go:333: Expected map[APIPriorityAndFairness:true CSIDriverAzureDisk:true CSIDriverVSphere:true CSIMigrationAWS:true CSIMigrationOpenStack:true DownwardAPIHugePages:true LegacyNodeRoleBehavior:false NodeDisruptionExclusion:true RotateKubeletServerCertificate:true ServiceNodeExclusion:true SupportPodPidsLimit:true] feature gates to be present but found map[APIPriorityAndFairness:true CSIDriverAzureDisk:true CSIDriverVSphere:true CSIMigrationAWS:true CSIMigrationAzureDisk:true CSIMigrationGCE:true CSIMigrationOpenStack:true DownwardAPIHugePages:true LegacyNodeRoleBehavior:false NodeDisruptionExclusion:true RotateKubeletServerCertificate:true ServiceNodeExclusion:true SupportPodPidsLimit:true]
I0630 19:14:53.786472 9516 targetconfigcontroller.go:329] Error while listing features.config.openshift.io/cluster with featuregate.config.openshift.io "cluster" not found: so return default feature gates
I0630 19:14:53.817692 9516 targetconfigcontroller.go:329] Error while listing features.config.openshift.io/cluster with featuregate.config.openshift.io "cluster" not found: so return default feature gates
I0630 19:14:53.840505 9516 targetconfigcontroller.go:329] Error while listing features.config.openshift.io/cluster with featuregate.config.openshift.io "cluster" not found: so return default feature gates
The first part of this failure looks like you might need to update the test (as that default list of feature gates changes, what we expect also needs to update to match it, see for example edfb1a3)
Though the 2nd part ("cluster" not found) sounds like it could have just been due to an infra issue, so retesting to double check
/retest
c324976 to
1cbf29c
Compare
|
|
I have run |
|
After running the command locally over your PR I get a diff: |
Thanks for your review, I have pushed a fix 👍🏽 |
28b1bcd to
f0b0ccf
Compare
|
/retest |
f0b0ccf to
3cd9c0a
Compare
The goal of this bump is to apply `CSIMigrationGCE` and `CSIMigrationAzureDisk` feature gates when the `TechPreviewNoUpgrade` featureSet is set by the user.
3cd9c0a to
3dd3f69
Compare
|
/retest |
|
/assign @damemi |
|
/lgtm /assign @damemi @ingvagabund |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, Elbehery, ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This will allow us to get latest feature gates about CSI migration
Note: this is needed for CSI migration feature to work in OCP 4.9.
Goal of this PR is to apply
CSIMigrationGCEandCSIMigrationAzureDiskfeature gates when the
TechPreviewNoUpgradefeatureSet is set by the user., which was introduced in openshift/api#957