CORS-4220: pass dualstack cluster cidrs as an comma-separated list argument#889
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@tthvo: This pull request references CORS-4220 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@tthvo: This pull request references CORS-4220 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @sadasu @mkowalski |
…d lists kube-controller-manager expects the dualstack cluster and service CIDRs to be passed as comma-separated list arguments [0]. This ensures the dualstack cluster and service cidrs are indeed passed as comma-separated lists. References [0] https://kubernetes.io/docs/concepts/services-networking/dual-stack/#configure-ipv4-ipv6-dual-stack
|
/lgtm |
|
/verified by @tthvo |
openshift-ci-robot
added
the
verified
|
@tthvo: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@atiratree , @deads2k , @ingvagabund Could you PTAL? |
|
/retest |
|
I don't have the right expertise in the area to decide whether the change is valid. I assume @mkowalski has the right expertise here. So is the request just about approving the PR or is it more about providing additional networking related review? |
|
@ingvagabund, currently the need is for an approval. |
|
After a quick exchange of PMs on Slack I was assured the review is not about correctness but rather providing a final approval label. The changes were validated through tests and the correctness verified by @mkowalski. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund, mkowalski, tthvo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/label acknowledge-critical-fixes-only These changes are required for the DualStack on AWS which is a high priority feature for 4.22. Azure and GCP are close behind. |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
/tide refresh |
|
@tthvo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
6 participants
kube-controller-managerexpects the dualstack cluster and service CIDRs to be passed as comma-separated list arguments according to the kubernetes IPv4/IPv6 documentation.This ensures the dualstack cluster and service cidrs are indeed passed as comma-separated lists.
Notes
There was previous unmerged work due to inactivity: #745, which has more details on why we need this.
Related Information
Tested with openshift/installer#9930
kube-controller-managerpod logs:KubeControllerManagerCR is rendered:$ oc get kubecontrollermanager cluster -o yaml | yq .spec logLevel: Normal managementState: Managed observedConfig: extendedArguments: cluster-cidr: - 10.128.0.0/14,fd01::/48 service-cluster-ip-range: - 172.30.0.0/16,fd02::/112 ...output-omitted...