-
Notifications
You must be signed in to change notification settings - Fork 138
CNTRLPLANE-1275: set up openshift-tests-extension and add a sanity test #859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNTRLPLANE-1275: set up openshift-tests-extension and add a sanity test #859
Conversation
|
@gangwgr: This pull request references CNTRLPLANE-1275 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
28ef58d to
edd872f
Compare
| "removedTests": [], | ||
| "tests": [ | ||
| { | ||
| "name": "[Jira:cluster-kube-controller-manager-operator][sig-api-machinery] sanity test should always pass [Suite:openshift/cluster-kube-controller-manager-operator/conformance/parallel]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "name": "[Jira:cluster-kube-controller-manager-operator][sig-api-machinery] sanity test should always pass [Suite:openshift/cluster-kube-controller-manager-operator/conformance/parallel]", | |
| "name": "[Jira:kube-controller-manager][sig-api-machinery] sanity test should always pass [Suite:openshift/cluster-kube-controller-manager-operator/conformance/parallel]", |
| Run: func(cmd *cobra.Command, args []string) { | ||
| tests := []Test{ | ||
| { | ||
| Name: "[Jira:cluster-kube-controller-manager-operator][sig-api-machinery] sanity test should always pass [Suite:openshift/cluster-kube-controller-manager-operator/conformance/parallel]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Name: "[Jira:cluster-kube-controller-manager-operator][sig-api-machinery] sanity test should always pass [Suite:openshift/cluster-kube-controller-manager-operator/conformance/parallel]", | |
| Name: "[Jira:kube-controller-manager][sig-api-machinery] sanity test should always pass [Suite:openshift/cluster-kube-controller-manager-operator/conformance/parallel]", |
|
/approve |
edd872f to
8bd088a
Compare
Dockerfile.rhel7
Outdated
| WORKDIR /go/src/github.com/openshift/cluster-kube-controller-manager-operator | ||
| COPY . . | ||
| RUN make build --warn-undefined-variables | ||
| RUN make tests-ext-build --warn-undefined-variables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| RUN make tests-ext-build --warn-undefined-variables | |
| RUN make tests-ext-build --warn-undefined-variables \ | |
| && gzip cluster-kube-controller-manager-operator-tests-ext |
Dockerfile.rhel7
Outdated
| COPY --from=builder /go/src/github.com/openshift/cluster-kube-controller-manager-operator/bindata/bootkube/config /usr/share/bootkube/manifests/config/ | ||
| COPY --from=builder /go/src/github.com/openshift/cluster-kube-controller-manager-operator/bindata/bootkube/manifests /usr/share/bootkube/manifests/manifests/ | ||
| COPY --from=builder /go/src/github.com/openshift/cluster-kube-controller-manager-operator/cluster-kube-controller-manager-operator /usr/bin/ | ||
| COPY --from=builder /go/src/github.com/openshift/cluster-kube-controller-manager-operator/cluster-kube-controller-manager-operator-tests-ext /usr/bin/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| COPY --from=builder /go/src/github.com/openshift/cluster-kube-controller-manager-operator/cluster-kube-controller-manager-operator-tests-ext /usr/bin/ | |
| COPY --from=builder /go/src/github.com/openshift/cluster-kube-controller-manager-operator/cluster-kube-controller-manager-operator-tests-ext.gz /usr/bin/ |
| GitTreeState string | ||
| ) | ||
|
|
||
| func main() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we don't need to implement the sub-command lines, we can create new one registry for kcm operator to github.com/openshift-eng/openshift-tests-extension/pkg/extension
see https://github.com/openshift-eng/openshift-tests-extension/blob/main/cmd/example-tests/main.go
For example, https://github.com/openshift/oauth-apiserver/pull/138/files#diff-84d0421ec3110230d5cc64f661941c97fcde4b758b8e0cc707fd002169bf3e32R27-R28, this will reduce more code.
a303fc6 to
1e8f093
Compare
|
@gangwgr: This pull request references CNTRLPLANE-1275 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gangwgr: This pull request references CNTRLPLANE-1275 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
test sanity results |
vrutkovs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
| COPY --from=builder /go/src/github.com/openshift/cluster-kube-controller-manager-operator/bindata/bootkube/config /usr/share/bootkube/manifests/config/ | ||
| COPY --from=builder /go/src/github.com/openshift/cluster-kube-controller-manager-operator/bindata/bootkube/manifests /usr/share/bootkube/manifests/manifests/ | ||
| COPY --from=builder /go/src/github.com/openshift/cluster-kube-controller-manager-operator/cluster-kube-controller-manager-operator /usr/bin/ | ||
| COPY --from=builder /go/src/github.com/openshift/cluster-kube-controller-manager-operator/cluster-kube-controller-manager-operator-tests-ext.gz /usr/bin/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dockerfile.rhel7 is used for production. Does the new binary needs to be part of a production image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
|
/lgtm |
|
/approve |
|
/test e2e-aws-ovn |
|
/test e2e-aws-ovn |
- Simplify main.go using pkg/extension registry approach (~170 lines vs ~400) - Add proper test execution functions with Ginkgo integration - Update Dockerfile.rhel7 to gzip tests binary for smaller image size - Use [Jira:kube-controller-manager] component name format - Provide all standard OTE commands: info, list, run-test, run-suite, update Benefits: - 75% code reduction using openshift-tests-extension framework - All commands provided by cmd.DefaultExtensionCommands() - Proper test execution with JSONL output format - Docker image optimization with gzip compression Addresses review feedback from @wangke19 and @vrutkovs
- Add github.com/openshift-eng/openshift-tests-extension v0.0.0-20250804142706-7b3ab438a292 - Add required Ginkgo/Gomega dependencies for test execution - Add vendor/ dependencies for registry-based OTE implementation - Use OpenShift Ginkgo fork replace directive Dependencies: - github.com/onsi/ginkgo/v2 (via OpenShift fork) - github.com/onsi/gomega v1.36.1 - github.com/openshift-eng/openshift-tests-extension - github.com/spf13/cobra v1.8.1
51d43f8 to
f1f7d80
Compare
f1f7d80 to
c919a88
Compare
vrutkovs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gangwgr, ingvagabund, vrutkovs, wangke19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws-ovn |
|
@gangwgr: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
90b2397
into
openshift:master
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-kube-controller-manager-operator |
This commit introduces a binary and supporting structure to enable the execution of OpenShift cluster-kube-controller-manager-operator tests using the Open Test Environment (OTE).
It lays the groundwork for moving tests to be executed from this repository using OTE.
Changes: