Render CIDR blocks in bootstrapping phase #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XXL
Contributor
Author
|
cc @sttts |
sttts
reviewed
Nov 7, 2018
sttts
reviewed
Nov 7, 2018
sttts
reviewed
Nov 7, 2018
sttts
reviewed
Nov 7, 2018
| } | ||
| var clusterk8sio clusterv1a1.Cluster | ||
| if err := yaml.Unmarshal([]byte(clusterConfigFileData), &clusterk8sio); err != nil { | ||
| return err |
Contributor
|
Some nits. Otherwise lgtm 👍 |
damemi
force-pushed
the
render-bootstrap-cidrs
branch
2 times, most recently
from
fc1d930 to
786ce58
Compare
sttts
reviewed
Nov 7, 2018
| manifest: *genericrenderoptions.NewManifestOptions("kube-controller-manager", "openshift/origin-hyperkube:latest"), | ||
| generic: *genericrenderoptions.NewGenericOptions(), | ||
| errOut: errOut, | ||
| clusterConfigFile: "/assets/tectonic/99_openshift-cluster-api_cluster.yaml", |
Contributor
There was a problem hiding this comment.
would leave this out actually. Otherwise we keep installer details around here for ages.
damemi
force-pushed
the
render-bootstrap-cidrs
branch
2 times, most recently
from
6ef4455 to
2613378
Compare
Contributor
|
Lgtm. Now let's get e2e-aws green :) |
Contributor
Author
|
/retest |
damemi
force-pushed
the
render-bootstrap-cidrs
branch
from
2613378 to
d7573c4
Compare
Contributor
Author
|
@sttts all green now, could you give an /lgtm so that we can also get openshift/installer#612 to pass? |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in openshift/cluster-kube-apiserver-operator#105 (comment), this passes necessary CIDR information available on the bootstrap node to the operator for rendering as part of bootstrap phase startup.