Bug 2087684: Reject transition from/to extreme latency profiles (default<->low) #629

swghosh · 2022-05-25T14:06:07Z

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2087684

Bump library-go (openshift/library-go#1372) for including following changes:

added another suppress func for LatencyProfileObserver that rejects extreme profile transition attempts in case of
- Default -> LowUpdateSlowReaction
- LowUpdateSlowReaction -> Default
bumped LatencyProfileController with rejection scenarios' check func
- to update WorkerLatencyProfileDegraded status with rejection related reason, message

This is in favour of cluster stability as mentioned in EP [1][2].

Signed-off-by: Swarup Ghosh [email protected]

openshift-ci · 2022-05-25T14:06:35Z

@swghosh: This pull request references Bugzilla bug 2087684, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.11.0) matches configured target release for branch (4.11.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

Bug 2087684: Reject transition from/to extreme latency profiles (default<->low)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

swghosh · 2022-05-25T14:07:27Z

/hold till openshift/library-go#1372 is merged.

openshift-ci · 2022-05-25T14:08:50Z

@swghosh: This pull request references Bugzilla bug 2087684, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.11.0) matches configured target release for branch (4.11.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

Bug 2087684: Reject transition from/to extreme latency profiles (default<->low)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

swghosh · 2022-05-27T05:39:24Z

/test e2e-upgrade

swghosh · 2022-05-27T07:48:07Z

/assign @atiratree
/cc @soltysh @rphillips

openshift-ci · 2022-05-27T07:51:39Z

@swghosh: This pull request references Bugzilla bug 2087684, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.11.0) matches configured target release for branch (4.11.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

Bug 2087684: Reject transition from/to extreme latency profiles (default<->low)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

swghosh · 2022-06-06T18:05:17Z

/test e2e-aws

swghosh · 2022-06-16T05:35:01Z

/retest

swghosh · 2022-06-16T15:02:28Z

/retest

nee1esh · 2022-06-17T15:28:09Z

/retest-required

pkg/operator/configobservation/configobservercontroller/observe_config_controller.go

swghosh · 2022-06-22T13:07:40Z

/hold cancel
as openshift/library-go#1372 is merged.

atiratree · 2022-06-22T14:08:58Z

@swghosh could you please split the library changes and the KCMo changes into separate commits?

Signed-off-by: Swarup Ghosh <[email protected]>

swghosh · 2022-06-22T15:16:18Z

could you please split the library changes and the KCMo changes into separate commits?

Using two separate commits now.

atiratree · 2022-06-22T15:27:59Z

/lgtm

openshift-ci · 2022-06-22T15:31:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, swghosh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [atiratree]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2022-06-22T17:43:12Z

/retest-required

Remaining retests: 2 against base HEAD 8876b93 and 8 for PR HEAD 0d17c27 in total

swghosh · 2022-06-22T20:13:51Z

/retest

openshift-ci-robot · 2022-06-22T22:42:56Z

/retest-required

Remaining retests: 1 against base HEAD 8876b93 and 7 for PR HEAD 0d17c27 in total

openshift-ci · 2022-06-23T00:42:58Z

@swghosh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ccm	`0d17c27`	link	false	`/test e2e-aws-ccm`
ci/prow/e2e-aws-ccm-install	`0d17c27`	link	false	`/test e2e-aws-ccm-install`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-06-23T00:44:10Z

@swghosh: All pull requests linked via external trackers have merged:

Bugzilla bug 2087684 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2087684: Reject transition from/to extreme latency profiles (default<->low)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-06-23T06:55:41Z

@swghosh: Bugzilla bug 2087684 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

Details

In response to this:

Bug 2087684: Reject transition from/to extreme latency profiles (default<->low)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 25, 2022

swghosh mentioned this pull request May 25, 2022

Bug 2087684: Support for rejecting transition from/to extreme latency profiles openshift/library-go#1372

Merged

openshift-ci bot requested review from ingvagabund and mfojtik May 25, 2022 14:07

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2022

swghosh force-pushed the bz-2087684 branch 2 times, most recently from c9deef4 to f68580b Compare May 26, 2022 11:18

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 26, 2022

swghosh force-pushed the bz-2087684 branch 2 times, most recently from ce8f7b5 to b2616b0 Compare May 26, 2022 12:03

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 26, 2022

swghosh force-pushed the bz-2087684 branch from b2616b0 to 4297983 Compare May 26, 2022 15:12

openshift-ci bot assigned atiratree May 27, 2022

openshift-ci bot requested review from rphillips and soltysh May 27, 2022 07:48

swghosh force-pushed the bz-2087684 branch 7 times, most recently from a4056b9 to 30d279e Compare June 3, 2022 11:16

swghosh force-pushed the bz-2087684 branch 3 times, most recently from 5f69fc4 to 4293411 Compare June 16, 2022 12:23

swghosh force-pushed the bz-2087684 branch from 4293411 to a9f513f Compare June 17, 2022 06:06

swghosh force-pushed the bz-2087684 branch 2 times, most recently from 1f76dca to b5a60e1 Compare June 21, 2022 12:31

atiratree reviewed Jun 21, 2022

View reviewed changes

pkg/operator/configobservation/configobservercontroller/observe_config_controller.go Show resolved Hide resolved

swghosh force-pushed the bz-2087684 branch 2 times, most recently from 1dce27a to e466775 Compare June 22, 2022 13:07

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2022

swghosh added 2 commits June 22, 2022 20:43

Bump library-go: support for worker latency profile rejections

72c0270

Signed-off-by: Swarup Ghosh <[email protected]>

Add extreme profile rejection in latency profile observer and controller

0d17c27

Signed-off-by: Swarup Ghosh <[email protected]>

swghosh force-pushed the bz-2087684 branch from e466775 to 0d17c27 Compare June 22, 2022 15:15

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2022

openshift-ci bot merged commit 85d20ea into openshift:master Jun 23, 2022

Bug 2087684: Reject transition from/to extreme latency profiles (default<->low) #629

Bug 2087684: Reject transition from/to extreme latency profiles (default<->low) #629

Uh oh!

Conversation

swghosh commented May 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented May 25, 2022

Uh oh!

swghosh commented May 25, 2022

Uh oh!

openshift-ci bot commented May 25, 2022

Uh oh!

swghosh commented May 27, 2022

Uh oh!

swghosh commented May 27, 2022

Uh oh!

openshift-ci bot commented May 27, 2022

Uh oh!

swghosh commented Jun 6, 2022

Uh oh!

swghosh commented Jun 16, 2022

Uh oh!

swghosh commented Jun 16, 2022

Uh oh!

nee1esh commented Jun 17, 2022

Uh oh!

Uh oh!

swghosh commented Jun 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

atiratree commented Jun 22, 2022

Uh oh!

swghosh commented Jun 22, 2022

Uh oh!

atiratree commented Jun 22, 2022

Uh oh!

openshift-ci bot commented Jun 22, 2022

Uh oh!

openshift-ci-robot commented Jun 22, 2022

Uh oh!

swghosh commented Jun 22, 2022

Uh oh!

openshift-ci-robot commented Jun 22, 2022

Uh oh!

openshift-ci bot commented Jun 23, 2022

Uh oh!

openshift-ci bot commented Jun 23, 2022

Uh oh!

openshift-ci bot commented Jun 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

swghosh commented May 25, 2022 •

edited

Loading

swghosh commented Jun 22, 2022 •

edited

Loading