Skip to content

[release-4.4] Bug 1833128: Updates Resource Graph to use default-ingress-cert CM#409

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.4from
openshift-cherrypick-robot:cherry-pick-408-to-release-4.4
Jun 11, 2020
Merged

[release-4.4] Bug 1833128: Updates Resource Graph to use default-ingress-cert CM#409
openshift-merge-robot merged 1 commit intoopenshift:release-4.4from
openshift-cherrypick-robot:cherry-pick-408-to-release-4.4

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #408

/assign danehans

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Bugzilla bug 1830364 has been cloned as Bugzilla bug 1833125. Retitling PR to link against new bug.
/retitle [release-4.4] Bug 1833125: Updates Resource Graph to use default-ingress-cert CM

Details

In response to this:

[release-4.4] Bug 1830364: Updates Resource Graph to use default-ingress-cert CM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] Bug 1830364: Updates Resource Graph to use default-ingress-cert CM [release-4.4] Bug 1833125: Updates Resource Graph to use default-ingress-cert CM May 7, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label May 7, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1833125, which is invalid:

  • expected dependent Bugzilla bug 1830364 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.4] Bug 1833125: Updates Resource Graph to use default-ingress-cert CM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 7, 2020
@danehans
Copy link
Contributor

danehans commented May 7, 2020

/retitle [release-4.4] Bug 1833128: Updates Resource Graph to use default-ingress-cert CM

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] Bug 1833125: Updates Resource Graph to use default-ingress-cert CM [release-4.4] Bug 1833128: Updates Resource Graph to use default-ingress-cert CM May 7, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1833128, which is invalid:

  • expected dependent Bugzilla bug 1830364 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.4] Bug 1833128: Updates Resource Graph to use default-ingress-cert CM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah
Copy link
Contributor

Miciah commented May 7, 2020

This PR needs to incorporate #402 (or #402 needs to be backported separately).

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2020
@soltysh
Copy link
Contributor

soltysh commented May 11, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 11, 2020
@openshift-ci-robot
Copy link

@soltysh: This pull request references Bugzilla bug 1833128, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.z) matches configured target release for branch (4.4.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1830364 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1830364 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
  • bug has dependents
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 11, 2020
@knobunc knobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 10, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@knobunc
Copy link

knobunc commented Jun 11, 2020

/retest

@Miciah
Copy link
Contributor

Miciah commented Jun 11, 2020

I think #409 (comment) still needs to be addressed. #402 does not apply cleanly to release-4.2 (see #402 (comment)), so a manual cherry-pick will be needed.

@openshift-merge-robot openshift-merge-robot merged commit 8a6f5da into openshift:release-4.4 Jun 11, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/cluster-kube-controller-manager-operator#409. Bugzilla bug 1833128 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.4] Bug 1833128: Updates Resource Graph to use default-ingress-cert CM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants