Restart controller manager process when certs change on disk#254
Restart controller manager process when certs change on disk#254mfojtik wants to merge 5 commits intoopenshift:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mfojtik If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@mfojtik: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@mfojtik: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
We already redeploy when these certs change, closing. |
This is added a side-car container to the controller-manager process that use shared PID namespace to watch the certificates in the main container and perform graceful termination of the main container (controller-manager) process when the certificates change on disk.
/cc @tnozicka
/cc @deads2k
/cc @sttts