Skip to content

Restart controller manager process when certs change on disk#254

Closed
mfojtik wants to merge 5 commits intoopenshift:masterfrom
mfojtik:wire-watchdog
Closed

Restart controller manager process when certs change on disk#254
mfojtik wants to merge 5 commits intoopenshift:masterfrom
mfojtik:wire-watchdog

Conversation

@mfojtik
Copy link
Contributor

@mfojtik mfojtik commented May 17, 2019

This is added a side-car container to the controller-manager process that use shared PID namespace to watch the certificates in the main container and perform graceful termination of the main container (controller-manager) process when the certificates change on disk.

/cc @tnozicka
/cc @deads2k
/cc @sttts

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 17, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mfojtik
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sttts

If they are not already assigned, you can assign the PR to them by writing /assign @sttts in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 17, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 17, 2019

@mfojtik: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade 3fa8cea link /test e2e-aws-upgrade
ci/prow/unit 3fa8cea link /test unit
ci/prow/verify 3fa8cea link /test verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

@mfojtik: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2019
@mfojtik
Copy link
Contributor Author

mfojtik commented Aug 28, 2019

We already redeploy when these certs change, closing.

@mfojtik mfojtik closed this Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants