defaultconfig: add --cert-dir in preparation of 1.13 by sttts · Pull Request #202 · openshift/cluster-kube-controller-manager-operator

sttts · 2019-03-26T12:43:55Z

To avoid in-memory certs, compare kubernetes/kubernetes#69884.

This reverts commit b7507f5.

deads2k · 2019-03-26T12:45:23Z

It's plausible, but please

/hold

until you have the kube-scheduler one and I can try to confirm it.

deads2k · 2019-03-26T13:12:07Z

/hold cancel

/lgtm

openshift-ci-robot · 2019-03-26T13:12:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [deads2k,sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deads2k · 2019-03-26T13:12:31Z

  - "/etc/kubernetes/secrets/kubelet-signer.crt"
  cluster-signing-key-file:
  - "/etc/kubernetes/secrets/kubelet-signer.key"
+  secure-port:


why do we bother to override this to the same value?

Just reverted.

From what I understood @deads2k we don't need that bit at all.

sttts · 2019-03-26T14:10:54Z

/retest

openshift-bot · 2019-03-26T15:51:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

sttts · 2019-03-27T08:19:55Z

/retest

soltysh · 2019-03-27T10:18:08Z

/retest

openshift-bot · 2019-03-27T11:18:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

soltysh · 2019-03-27T14:28:04Z

/retest

sttts · 2019-03-27T14:41:18Z

/retest

openshift-bot · 2019-03-27T15:31:56Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-27T23:20:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-28T03:54:55Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-28T04:59:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-28T06:06:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-28T07:09:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-28T09:38:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-28T12:02:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-28T14:47:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-30T23:47:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-31T00:47:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-31T04:59:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-31T05:11:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-31T06:23:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-31T07:35:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-31T08:47:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-31T09:47:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-31T10:59:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-31T11:59:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-31T13:11:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-31T14:11:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-31T15:11:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-31T16:11:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-31T17:11:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-31T18:23:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-31T19:49:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-31T21:01:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-31T22:13:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-03-31T23:13:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-01T00:13:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-01T01:13:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-01T02:13:33Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-01T03:37:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

wking · 2019-04-01T04:35:28Z

/hold

This PR is zero for 74 or so in its e2e-aws test, most recently dying with:

Flaky tests:

[Conformance][Area:Networking][Feature:Router] The HAProxy router should enable openshift-monitoring to pull metrics [Suite:openshift/conformance/parallel/minimal]
[Feature:Platform][Smoke] Managed cluster should start all core operators [Suite:openshift/conformance/parallel]

Failing tests:

[Feature:Prometheus][Conformance] Prometheus when installed on the cluster should start and expose a secured proxy and unsecured metrics [Suite:openshift/conformance/parallel/minimal]

I dunno if that's just a busted test or what, but I certainly don't want CI as a whole to have a ~1% success rate ;). The hold will stop the automatic retest bot from banging away on this, but can someone look into why we're getting so many failures here?

wking · 2019-04-01T04:41:16Z

Heh, another retest-bot run just died while I was writing my previous message. This time with:

Flaky tests:

[k8s.io] Pods should support pod readiness gates [NodeFeature:PodReadinessGate] [Suite:openshift/conformance/parallel] [Suite:k8s]

Failing tests:

[Feature:Prometheus][Conformance] Prometheus when installed on the cluster should start and expose a secured proxy and unsecured metrics [Suite:openshift/conformance/parallel/minimal]

So something about this PR is not playing well with that Prometheus test. The test has been happy in other places, like this recent OKD release promotion gate.

soltysh · 2019-04-04T16:28:26Z

The reason this was failing is b/c we were looking for https in prom, after openshift/origin#22483 merges this should be good to go. There's a nice chain of PRs leading slowly to that 😉

openshift-ci-robot · 2019-04-05T19:51:53Z

@sttts: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws	`3e2a8fa`	link	`/test e2e-aws`
ci/prow/e2e-aws-operator	`3e2a8fa`	link	`/test e2e-aws-operator`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

sttts added 2 commits March 26, 2019 13:41

Revert "disable kcm secure serving"

d1d48f3

This reverts commit b7507f5.

defaultconfig: set cert dir in 1.13 preparation

3e2a8fa

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 26, 2019

openshift-ci-robot requested review from mfojtik and soltysh March 26, 2019 12:44

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2019

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2019

openshift-ci-robot assigned deads2k Mar 26, 2019

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 26, 2019

deads2k reviewed Mar 26, 2019

View reviewed changes

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2019

sttts closed this Apr 9, 2019

Conversation

sttts commented Mar 26, 2019

Uh oh!

deads2k commented Mar 26, 2019

Uh oh!

deads2k commented Mar 26, 2019

Uh oh!

openshift-ci-robot commented Mar 26, 2019

Uh oh!

deads2k Mar 26, 2019

Choose a reason for hiding this comment

Uh oh!

sttts Mar 26, 2019

Choose a reason for hiding this comment

Uh oh!

soltysh Mar 26, 2019

Choose a reason for hiding this comment

Uh oh!

sttts commented Mar 26, 2019

Uh oh!

openshift-bot commented Mar 26, 2019

Uh oh!

sttts commented Mar 27, 2019

Uh oh!

soltysh commented Mar 27, 2019

Uh oh!

openshift-bot commented Mar 27, 2019

Uh oh!

soltysh commented Mar 27, 2019

Uh oh!

sttts commented Mar 27, 2019

Uh oh!

openshift-bot commented Mar 27, 2019

Uh oh!

openshift-bot commented Mar 27, 2019

Uh oh!

openshift-bot commented Mar 28, 2019

Uh oh!

openshift-bot commented Mar 28, 2019

Uh oh!

openshift-bot commented Mar 28, 2019

Uh oh!

openshift-bot commented Mar 28, 2019

Uh oh!

openshift-bot commented Mar 28, 2019

Uh oh!

openshift-bot commented Mar 28, 2019

Uh oh!

openshift-bot commented Mar 28, 2019

Uh oh!

openshift-bot commented Mar 30, 2019

Uh oh!

openshift-bot commented Mar 31, 2019

Uh oh!

openshift-bot commented Mar 31, 2019

Uh oh!

openshift-bot commented Mar 31, 2019

Uh oh!

openshift-bot commented Mar 31, 2019

Uh oh!

openshift-bot commented Mar 31, 2019

Uh oh!

openshift-bot commented Mar 31, 2019

Uh oh!

openshift-bot commented Mar 31, 2019

Uh oh!

openshift-bot commented Mar 31, 2019

Uh oh!

openshift-bot commented Mar 31, 2019

Uh oh!

openshift-bot commented Mar 31, 2019

Uh oh!

openshift-bot commented Mar 31, 2019

Uh oh!

openshift-bot commented Mar 31, 2019

Uh oh!

openshift-bot commented Mar 31, 2019

Uh oh!

openshift-bot commented Mar 31, 2019

Uh oh!