Skip to content

Change the method to get the ApiServer hostname #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 2 commits into from
Jul 28, 2020
Merged

Change the method to get the ApiServer hostname #855

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
190be57
Change the method to get the ApiServer hostname
a7vicky May 12, 2020
930a4b3
Merge pull request #1 from garbagego/garbagego-patch-1
a7vicky May 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/operator/certrotationcontroller/externalloadbalancer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ func (c *CertRotationController) syncExternalLoadBalancerHostnames() error {
return nil
}
hostname = strings.Replace(hostname, "https://", "", 1)
hostname = hostname[0:strings.LastIndex(hostname, ":")]
hostname_arr := strings.Split(hostname, ":")
hostname = hostname_arr[0]
Copy link
Copy Markdown
Contributor

@sttts sttts May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs say:

        // apiServerURL is a valid URI with scheme(http/https), address and
	// port.  apiServerURL can be used by components like the web console
	// to tell users where to find the Kubernetes API.
	APIServerURL string `json:"apiServerURL"`

I.e. we are supposed to always have a port. This merely looks like missing validation.

Copy link
Copy Markdown
Member Author

@a7vicky a7vicky May 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sttts yes based on Doc it seems missing validation. But why we need to provide port if we are using https scheme with default port 443 ? Is there any dependency or constraints which is forcing to provide ports ?

Copy link
Copy Markdown
Contributor

@sttts sttts May 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am fine with this fix here. But I would like to see a counterpart PR fixing the API doc before merging this.

Copy link
Copy Markdown
Member Author

@a7vicky a7vicky May 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sttts Thanks
Is this the right doc line which needs to modify?
openshift/api#646

Copy link
Copy Markdown
Contributor

@sttts sttts May 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, file is right. Left a comment.


klog.V(2).Infof("syncing external loadbalancer hostnames: %v", hostname)
c.externalLoadBalancer.setHostnames([]string{hostname})
Expand Down