Skip to content

Bug 1827337: Remove stale condition DefaultSecurityContextConstraintsUpgradeable #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Apr 23, 2020
Merged

Bug 1827337: Remove stale condition DefaultSecurityContextConstraintsUpgradeable #838

openshift-merge-robot merged 2 commits into from
Apr 23, 2020

Conversation

@tkashem
Copy link
Contributor

@tkashem tkashem commented Apr 23, 2020

We removed the controller that sets the condition DefaultSecurityContextConstraintsUpgradeable if any default SCC has been mutated. A cluster that already has user-modified default SCCs will have the above condition set. We need to remove the stale condition.

@tkashem
Remove stale condition
6109966 
We removed the controller that sets the condition
`DefaultSecurityContextConstraintsUpgradeable` if any default SCC
has been mutated.
A cluster that already has user-modified default SCCs will have the
above condition set. We need to remove the stale condition.
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 23, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 23, 2020

@tkashem: This pull request references Bugzilla bug 1827337, which is invalid:

  • expected dependent Bugzilla bug 1827336 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1827337: Remove stale condition DefaultSecurityContextConstraintsUpgradeable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tkashem
Copy link
Contributor Author

tkashem commented Apr 23, 2020

/retest

6 similar comments
@tkashem
Copy link
Contributor Author

tkashem commented Apr 23, 2020

/retest

@tkashem
Copy link
Contributor Author

tkashem commented Apr 23, 2020

/retest

@tkashem
Copy link
Contributor Author

tkashem commented Apr 23, 2020

/retest

@tkashem
Copy link
Contributor Author

tkashem commented Apr 23, 2020

/retest

@tkashem
Copy link
Contributor Author

tkashem commented Apr 23, 2020

/retest

@tkashem
Copy link
Contributor Author

tkashem commented Apr 23, 2020

/retest

@tkashem
Copy link
Contributor Author

tkashem commented Apr 23, 2020

/assign @mfojtik

wking
wking approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catching up after #830 .

@mfojtik
Copy link
Contributor

mfojtik commented Apr 23, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 23, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, tkashem, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2020
@russellb russellb added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 23, 2020
@russellb
Copy link
Contributor

russellb commented Apr 23, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2020
@russellb
Copy link
Contributor

russellb commented Apr 23, 2020

As discussed elsewhere, we are manually bypassing some process on this one, since this 4.3 fix needs to get in as soon as possible. I've manually adjusted the bug label for this special case.

@russellb
Copy link
Contributor

russellb commented Apr 23, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2020
@openshift-merge-robot openshift-merge-robot merged commit e04d17f into openshift:release-4.3 Apr 23, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 23, 2020

@tkashem: All pull requests linked via external trackers have merged: . Bugzilla bug 1827337 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1827337: Remove stale condition DefaultSecurityContextConstraintsUpgradeable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking mentioned this pull request Apr 24, 2020
Merged
@tkashem tkashem mentioned this pull request Apr 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@soltysh soltysh Awaiting requested review from soltysh

1 more reviewer

@wking wking wking approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mfojtik mfojtik

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tkashem @openshift-ci-robot @mfojtik @russellb @wking @openshift-merge-robot