Remove unused post-bootstrap overrides from bootstrap bindata#731
Closed
marun wants to merge 1 commit intoopenshift:masterfrom
marun:post-bootstrap-config
Closed
Remove unused post-bootstrap overrides from bootstrap bindata#731marun wants to merge 1 commit intoopenshift:masterfrom marun:post-bootstrap-config
marun wants to merge 1 commit intoopenshift:masterfrom
marun:post-bootstrap-config
Conversation
Post-bootstrap kube-apiserver config is rendered by TargetConfigController.manageKubeAPIServerConfig and does not consider the content of bindata/bootkube/config/config-overrides.yaml. That file still needs to exist, though, to maintain compatibility with the library-go type that renders the configuration.
openshift-ci-robot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: marun The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
/close in favor of #718. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-bootstrap kube-apiserver config is rendered by TargetConfigController.manageKubeAPIServerConfig and does not consider the content of bindata/bootkube/config/config-overrides.yaml. That file still needs to exist, though, to maintain compatibility with the library-go type that renders the configuration.
/cc @sttts