start requiring kubelet trust#247
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Feb 15, 2019
Merged
Conversation
openshift-ci-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
Author
|
kubelets are only signed by the CSR, so if we trust the CSR bundle we should be fine. |
openshift-ci-robot
added
the
needs-rebase
sttts
reviewed
Feb 12, 2019
| ); err != nil { | ||
| return nil, err | ||
| } | ||
| // this ca bundle contains certs used trust kubelets |
Contributor
|
Only the typo, lgtm otherwise. |
deads2k
force-pushed
the
kubelet-trust
branch
from
a93f7c1 to
1a3dffc
Compare
openshift-ci-robot
removed
the
needs-rebase
Contributor
|
/retest |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
deads2k
force-pushed
the
kubelet-trust
branch
from
1a3dffc to
513f00e
Compare
deads2k
added
lgtm
|
New changes are detected. LGTM label has been removed. |
Contributor
Author
|
I need #238 to have a conditional sync function. |
deads2k
force-pushed
the
kubelet-trust
branch
from
513f00e to
3a6e558
Compare
openshift-ci-robot
added
size/S
Contributor
Author
|
/retest |
deads2k
force-pushed
the
kubelet-trust
branch
from
3a6e558 to
daf4876
Compare
|
New changes are detected. LGTM label has been removed. |
squat
added a commit
to squat/cluster-monitoring-operator
that referenced
this pull request
Feb 19, 2019
Now that openshift/cluster-kube-apiserver-operator#247 has landed, we can scrape kubelets on both master AND worker nodes. This commit renames references from "csr-controller-ca" to "kubelet-serving-ca" as this bundle contains the correct CA certs fo both worker and master kubelets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pulls finishes the wiring for requiring proper serving certs from kubelets
@sjenning
/assign @sttts @mfojtik