-
Notifications
You must be signed in to change notification settings - Fork 181
OCPNODE-3758: alpha/beta apis for DRA should not be enabled in 1.34 #1932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughRevised DynamicResourceAllocation API gating: removed Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@bertinatto: This PR was included in a payload test run from openshift/kubernetes#2386
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0712eaf0-a055-11f0-8058-bd3bb2a148cd-0 |
a03b103 to
9da83ef
Compare
9da83ef to
d10c78d
Compare
|
/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-techpreview |
|
@benluddy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1d2532f0-a08f-11f0-862d-d0a553992369-0 |
|
/lgtm |
d10c78d to
d948cb5
Compare
|
/payload abort |
|
/payload-abort |
|
/lgtm |
|
@benluddy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d906e2c0-a08f-11f0-9110-9e5a253f11e6-0 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@tkashem: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
|
@benluddy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9d7dcbb0-a1f2-11f0-9a80-b704fd9543df-0 |
|
/payload-job periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview |
|
@benluddy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/14bf0520-a2c7-11f0-863d-e628aaa2aa2c-0 |
|
/retitle NO-JIRA: alpha/beta apis for DRA should not be enabled in 1.34 |
|
@tkashem: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold cancel |
|
@tkashem: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@tkashem: This pull request references OCPNODE-3758 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by @tkashem Launch a cluster using cluster-bot that uses this PR and the 1.34 rebase PR |
|
@tkashem: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
3e3b6f6
into
openshift:main
this PR updates defaultGroupVersionsByFeatureGate