Skip to content

Conversation

@tkashem
Copy link
Contributor

@tkashem tkashem commented Oct 3, 2025

this PR updates defaultGroupVersionsByFeatureGate

  • by consolidating version ranges up to 1.34
  • removes v1alpha2, and
  • adds v1beta2 for the interim

@coderabbitai
Copy link

coderabbitai bot commented Oct 3, 2025

Walkthrough

Revised DynamicResourceAllocation API gating: removed v1alpha2, retained v1alpha3 and v1beta1, added v1beta2, and consolidated served-version upper bounds to <1.34.0; added comments about GA timing, rebase impact, and planned removal of alpha/beta enablement after the feature gate is removed.

Changes

Cohort / File(s) Summary of changes
API enablement observation
pkg/operator/configobservation/apienablement/observe_runtime_config.go
Updated defaultGroupVersionsByFeatureGate for DynamicResourceAllocation: removed v1alpha2, retained v1alpha3 and v1beta1, added v1beta2; set upper bounds to <1.34.0 for alpha/beta entries and added explanatory TODO/comments regarding GA and post-rebase removal.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed The description clearly outlines the consolidation of version ranges up to 1.34, removal of v1alpha2, and addition of v1beta2, matching the changes in the pull request.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The title clearly summarizes the core change of disabling alpha and beta APIs for DynamicResourceAllocation in version 1.34, directly reflecting the adjustments made to the version bounds and feature gate settings in the code. It is specific, concise, and aligned with the pull request’s main objective.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from deads2k and sanchezl October 3, 2025 11:21
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2025

@bertinatto: This PR was included in a payload test run from openshift/kubernetes#2386
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0712eaf0-a055-11f0-8058-bd3bb2a148cd-0

@tkashem tkashem changed the title temporarily enable api resource.k8s.io/v1beta2 alpha/beta apis for DRA should not be enabled in 1.34 Oct 3, 2025
@benluddy
Copy link
Contributor

benluddy commented Oct 3, 2025

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2025

@benluddy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1d2532f0-a08f-11f0-862d-d0a553992369-0

@benluddy
Copy link
Contributor

benluddy commented Oct 3, 2025

/lgtm
/hold
#1932 (comment)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2025
@benluddy
Copy link
Contributor

benluddy commented Oct 3, 2025

/payload abort

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2025

@benluddy: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@benluddy
Copy link
Contributor

benluddy commented Oct 3, 2025

/payload-abort

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2025

@benluddy: aborted active payload jobs for pull request #1932

@benluddy
Copy link
Contributor

benluddy commented Oct 3, 2025

/lgtm
/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2025

@benluddy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d906e2c0-a08f-11f0-9110-9e5a253f11e6-0

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2025

@tkashem: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator-disruptive-single-node d948cb5 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/okd-scos-e2e-aws-ovn d948cb5 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-operator-single-node d948cb5 link false /test e2e-gcp-operator-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@benluddy
Copy link
Contributor

benluddy commented Oct 5, 2025

/retest-required
/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2025

@benluddy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9d7dcbb0-a1f2-11f0-9a80-b704fd9543df-0

@benluddy
Copy link
Contributor

benluddy commented Oct 6, 2025

/payload-job periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2025

@benluddy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/14bf0520-a2c7-11f0-863d-e628aaa2aa2c-0

@benluddy
Copy link
Contributor

benluddy commented Oct 6, 2025

/retitle NO-JIRA: alpha/beta apis for DRA should not be enabled in 1.34

@openshift-ci openshift-ci bot changed the title alpha/beta apis for DRA should not be enabled in 1.34 NO-JIRA: alpha/beta apis for DRA should not be enabled in 1.34 Oct 6, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 6, 2025
@openshift-ci-robot
Copy link

@tkashem: This pull request explicitly references no jira issue.

In response to this:

this PR updates defaultGroupVersionsByFeatureGate

  • by consolidating version ranges up to 1.34
  • removes v1alpha2, and
  • adds v1beta2 for the interim

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@benluddy
Copy link
Contributor

benluddy commented Oct 6, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2025

@tkashem: The label(s) /label verified cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, run-integration-tests, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, ok-to-test, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label verified

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tkashem tkashem changed the title NO-JIRA: alpha/beta apis for DRA should not be enabled in 1.34 OCPNODE-3758: alpha/beta apis for DRA should not be enabled in 1.34 Oct 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 7, 2025

@tkashem: This pull request references OCPNODE-3758 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

this PR updates defaultGroupVersionsByFeatureGate

  • by consolidating version ranges up to 1.34
  • removes v1alpha2, and
  • adds v1beta2 for the interim

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tkashem
Copy link
Contributor Author

tkashem commented Oct 8, 2025

/verified by @tkashem

Launch a cluster using cluster-bot that uses this PR and the 1.34 rebase PR

launch 4.21,openshift/cluster-kube-apiserver-operator#1932,openshift/kubernetes#2484 gcp
❯ kubectl version
Client Version: v1.33.0-alpha.3.30+30ea0d13cdeeb5-dirty
Kustomize Version: v5.6.0
Server Version: v1.34.1-dirty
❯ kubectl get --raw /apis/resource.k8s.io | jq .
{
  "kind": "APIGroup",
  "apiVersion": "v1",
  "name": "resource.k8s.io",
  "versions": [
    {
      "groupVersion": "resource.k8s.io/v1",
      "version": "v1"
    }
  ],
  "preferredVersion": {
    "groupVersion": "resource.k8s.io/v1",
    "version": "v1"
  }
}
❯ kubectl get --raw /apis/resource.k8s.io/v1 | jq .
{
  "kind": "APIResourceList",
  "apiVersion": "v1",
  "groupVersion": "resource.k8s.io/v1",
  "resources": [
    {
      "name": "deviceclasses",
      "singularName": "deviceclass",
      "namespaced": false,
      "kind": "DeviceClass",
      "verbs": [
        "create",
        "delete",
        "deletecollection",
        "get",
        "list",
        "patch",
        "update",
        "watch"
      ],
      "storageVersionHash": "weQRMT6DeYM="
    },
    {
      "name": "resourceclaims",
      "singularName": "resourceclaim",
      "namespaced": true,
      "kind": "ResourceClaim",
      "verbs": [
        "create",
        "delete",
        "deletecollection",
        "get",
        "list",
        "patch",
        "update",
        "watch"
      ],
      "storageVersionHash": "EJAWH5WrAYg="
    },
    {
      "name": "resourceclaims/status",
      "singularName": "",
      "namespaced": true,
      "kind": "ResourceClaim",
      "verbs": [
        "get",
        "patch",
        "update"
      ]
    },
    {
      "name": "resourceclaimtemplates",
      "singularName": "resourceclaimtemplate",
      "namespaced": true,
      "kind": "ResourceClaimTemplate",
      "verbs": [
        "create",
        "delete",
        "deletecollection",
        "get",
        "list",
        "patch",
        "update",
        "watch"
      ],
      "storageVersionHash": "24m0okHrUtk="
    },
    {
      "name": "resourceslices",
      "singularName": "resourceslice",
      "namespaced": false,
      "kind": "ResourceSlice",
      "verbs": [
        "create",
        "delete",
        "deletecollection",
        "get",
        "list",
        "patch",
        "update",
        "watch"
      ],
      "storageVersionHash": "z6Bc9vgk6yE="
    }
  ]
}
❯ kubectl get --raw /apis/resource.k8s.io/v1beta2 --v=10
...
I1008 11:53:07.243896   65067 helpers.go:246] server response object: %s[{
  "metadata": {},
  "status": "Failure",
  "message": "the server could not find the requested resource",
  "reason": "NotFound",
  "details": {},
  "code": 404
}]
Error from server (NotFound): the server could not find the requested resource
❯ kubectl get --raw /apis/resource.k8s.io/v1beta1 --v=10
...
I1008 11:54:53.094033   65681 helpers.go:246] server response object: %s[{
  "metadata": {},
  "status": "Failure",
  "message": "the server could not find the requested resource",
  "reason": "NotFound",
  "details": {},
  "code": 404
}]
Error from server (NotFound): the server could not find the requested resource
❯ kubectl get --raw /apis/resource.k8s.io/v1alpha3 --v=10
...
I1008 11:55:30.564474   65893 helpers.go:246] server response object: %s[{
  "metadata": {},
  "status": "Failure",
  "message": "the server could not find the requested resource",
  "reason": "NotFound",
  "details": {},
  "code": 404
}]
Error from server (NotFound): the server could not find the requested resource

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 8, 2025
@openshift-ci-robot
Copy link

@tkashem: This PR has been marked as verified by @tkashem.

In response to this:

/verified by @tkashem

Launch a cluster using cluster-bot that uses this PR and the 1.34 rebase PR

launch 4.21,openshift/cluster-kube-apiserver-operator#1932,openshift/kubernetes#2484 gcp
❯ kubectl version
Client Version: v1.33.0-alpha.3.30+30ea0d13cdeeb5-dirty
Kustomize Version: v5.6.0
Server Version: v1.34.1-dirty
❯ kubectl get --raw /apis/resource.k8s.io | jq .
{
 "kind": "APIGroup",
 "apiVersion": "v1",
 "name": "resource.k8s.io",
 "versions": [
   {
     "groupVersion": "resource.k8s.io/v1",
     "version": "v1"
   }
 ],
 "preferredVersion": {
   "groupVersion": "resource.k8s.io/v1",
   "version": "v1"
 }
}
❯ kubectl get --raw /apis/resource.k8s.io/v1 | jq .
{
 "kind": "APIResourceList",
 "apiVersion": "v1",
 "groupVersion": "resource.k8s.io/v1",
 "resources": [
   {
     "name": "deviceclasses",
     "singularName": "deviceclass",
     "namespaced": false,
     "kind": "DeviceClass",
     "verbs": [
       "create",
       "delete",
       "deletecollection",
       "get",
       "list",
       "patch",
       "update",
       "watch"
     ],
     "storageVersionHash": "weQRMT6DeYM="
   },
   {
     "name": "resourceclaims",
     "singularName": "resourceclaim",
     "namespaced": true,
     "kind": "ResourceClaim",
     "verbs": [
       "create",
       "delete",
       "deletecollection",
       "get",
       "list",
       "patch",
       "update",
       "watch"
     ],
     "storageVersionHash": "EJAWH5WrAYg="
   },
   {
     "name": "resourceclaims/status",
     "singularName": "",
     "namespaced": true,
     "kind": "ResourceClaim",
     "verbs": [
       "get",
       "patch",
       "update"
     ]
   },
   {
     "name": "resourceclaimtemplates",
     "singularName": "resourceclaimtemplate",
     "namespaced": true,
     "kind": "ResourceClaimTemplate",
     "verbs": [
       "create",
       "delete",
       "deletecollection",
       "get",
       "list",
       "patch",
       "update",
       "watch"
     ],
     "storageVersionHash": "24m0okHrUtk="
   },
   {
     "name": "resourceslices",
     "singularName": "resourceslice",
     "namespaced": false,
     "kind": "ResourceSlice",
     "verbs": [
       "create",
       "delete",
       "deletecollection",
       "get",
       "list",
       "patch",
       "update",
       "watch"
     ],
     "storageVersionHash": "z6Bc9vgk6yE="
   }
 ]
}
❯ kubectl get --raw /apis/resource.k8s.io/v1beta2 --v=10
...
I1008 11:53:07.243896   65067 helpers.go:246] server response object: %s[{
 "metadata": {},
 "status": "Failure",
 "message": "the server could not find the requested resource",
 "reason": "NotFound",
 "details": {},
 "code": 404
}]
Error from server (NotFound): the server could not find the requested resource
❯ kubectl get --raw /apis/resource.k8s.io/v1beta1 --v=10
...
I1008 11:54:53.094033   65681 helpers.go:246] server response object: %s[{
 "metadata": {},
 "status": "Failure",
 "message": "the server could not find the requested resource",
 "reason": "NotFound",
 "details": {},
 "code": 404
}]
Error from server (NotFound): the server could not find the requested resource
❯ kubectl get --raw /apis/resource.k8s.io/v1alpha3 --v=10
...
I1008 11:55:30.564474   65893 helpers.go:246] server response object: %s[{
 "metadata": {},
 "status": "Failure",
 "message": "the server could not find the requested resource",
 "reason": "NotFound",
 "details": {},
 "code": 404
}]
Error from server (NotFound): the server could not find the requested resource

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 3e3b6f6 into openshift:main Oct 8, 2025
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants