Skip to content

MON-4129: adjust Prometheus classic histograms 'le' related selectors in rules defs and relabel config to accommodate the update to Prometheus v3 #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Feb 3, 2025
Merged

MON-4129: adjust Prometheus classic histograms 'le' related selectors in rules defs and relabel config to accommodate the update to Prometheus v3 #1784

openshift-merge-bot merged 1 commit into from
Feb 3, 2025

Conversation

@machine424
Copy link
Contributor

@machine424 machine424 commented Jan 15, 2025

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2025
@machine424 machine424 mentioned this pull request Jan 15, 2025
Merged
2 tasks
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2554
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-rosa-sts-hypershift-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/50647e70-d3fb-11ef-84ae-020c1e634813-0

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2554
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-rosa-sts-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6c58b6a0-d3fb-11ef-9ad3-ed24ac0f8204-0

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2554
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-rosa-sts-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/88b2b380-d411-11ef-93dc-3c642b2d31ff-0

@machine424
Copy link
Contributor Author

machine424 commented Jan 17, 2025 •
edited by openshift-ci bot
Loading

/retitle MON-4129: adjust Prometheus histograms 'le' related selectors in rules relabel config

@openshift-ci openshift-ci bot changed the title WIP: adjust histograms 'le' related selectors MON-4129: adjust Prometheus histograms 'le' related selectors in rules relabel config Jan 17, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2025 •
edited by openshift-ci bot
Loading

@machine424: This pull request references MON-4129 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2025
@machine424 machine424 changed the title MON-4129: adjust Prometheus histograms 'le' related selectors in rules relabel config WIP: MON-4129: adjust Prometheus histograms 'le' related selectors in rules relabel config Jan 17, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2025
@machine424
Copy link
Contributor Author

machine424 commented Jan 30, 2025

/retest

@machine424
Copy link
Contributor Author

machine424 commented Jan 30, 2025 •
edited by openshift-ci bot
Loading

/retitle MON-4129: adjust Prometheus classic histograms 'le' related selectors in rules defs and relabel config to accommodate the update to Prometheus v3

@openshift-ci openshift-ci bot changed the title WIP: MON-4129: adjust Prometheus histograms 'le' related selectors in rules relabel config MON-4129: adjust Prometheus classic histograms 'le' related selectors in rules defs and relabel config to accommodate the update to Prometheus v3 Jan 30, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2025
vrutkovs
vrutkovs approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machine424, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2025
@machine424
Copy link
Contributor Author

machine424 commented Jan 31, 2025

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 31, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2025

/retest-required

Remaining retests: 0 against base HEAD 1c44cc5 and 2 for PR HEAD d030fb5 in total

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2025

/retest-required

Remaining retests: 0 against base HEAD 1c44cc5 and 2 for PR HEAD d030fb5 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 1, 2025

/retest-required

Remaining retests: 0 against base HEAD e7cb5af and 1 for PR HEAD d030fb5 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 1, 2025 •
edited
Loading

@machine424: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator-single-node d030fb5 link false /test e2e-gcp-operator-single-node
ci/prow/e2e-aws-operator-disruptive-single-node d030fb5 link false /test e2e-aws-operator-disruptive-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 1, 2025

/retest-required

Remaining retests: 0 against base HEAD e7cb5af and 2 for PR HEAD d030fb5 in total

@machine424
Copy link
Contributor Author

machine424 commented Feb 3, 2025

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 2a0efa5 into openshift:master Feb 3, 2025
14 of 16 checks passed
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 3, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-kube-apiserver-operator
This PR has been included in build ose-cluster-kube-apiserver-operator-container-v4.19.0-202502031307.p0.g2a0efa5.assembly.stream.el9.
All builds following this will include this PR.

machine424 added a commit to machine424/cluster-kube-apiserver-operator that referenced this pull request Feb 26, 2025
@machine424
MON-4129: revert openshift#1784
a730266 
this also fixes a bad `le="30(.0)?"` as a result of openshift#1742

The chosen approach is to move to float buckets one Prometheus v3 is merged
forgetting about the integer historical data.

That will be done in openshift#1816
openshift-merge-bot bot added a commit that referenced this pull request Feb 27, 2025
@openshift-merge-bot
Merge pull request #1817 from machine424/roll
5eac560 
MON-4129: revert #1784
@microshift-rebase-script microshift-rebase-script bot mentioned this pull request Mar 3, 2025
Closed
@eslutsky eslutsky mentioned this pull request Mar 3, 2025
Merged
p0lyn0mial pushed a commit to p0lyn0mial/cluster-kube-apiserver-operator that referenced this pull request Dec 11, 2025
@machine424 @p0lyn0mial
MON-4129: revert openshift#1784
dbc7081 
this also fixes a bad `le="30(.0)?"` as a result of openshift#1742

The chosen approach is to move to float buckets one Prometheus v3 is merged
forgetting about the integer historical data.

That will be done in openshift#1816
wangke19 pushed a commit to wangke19/cluster-kube-apiserver-operator that referenced this pull request Dec 22, 2025
@machine424 @wangke19
MON-4129: revert openshift#1784
ac17466 
this also fixes a bad `le="30(.0)?"` as a result of openshift#1742

The chosen approach is to move to float buckets one Prometheus v3 is merged
forgetting about the integer historical data.

That will be done in openshift#1816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

1 more reviewer

@vrutkovs vrutkovs vrutkovs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vrutkovs vrutkovs

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@machine424 @openshift-ci-robot @openshift-bot @vrutkovs