Skip to content

Config Observer and Latency Controller for nodes.config.openshift.io WorkerLatencyProfile #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
May 13, 2022
Merged

Config Observer and Latency Controller for nodes.config.openshift.io WorkerLatencyProfile #1328

openshift-merge-robot merged 2 commits into from
May 13, 2022

Conversation

@swghosh
Copy link
Member

@swghosh swghosh commented Mar 10, 2022 •
edited
Loading

  • Config observer for Worker Latency Profiles intended to update the following kube-api-server arguments on the basis of latency profile values found in config.openshift.io/v1/node resource.
    1. default-not-ready-toleration-seconds
    2. default-unreachable-toleration-seconds
  • LatencyController to sync rollout status in config.openshift.io/v1/node/cluster object.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2022
@openshift-ci openshift-ci bot requested review from mfojtik and p0lyn0mial March 10, 2022 15:15
@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Mar 10, 2022
@swghosh
Copy link
Member Author

swghosh commented Mar 10, 2022

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2022
@swghosh swghosh marked this pull request as ready for review March 10, 2022 17:50
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2022
@openshift-ci openshift-ci bot requested review from sttts and tkashem March 10, 2022 17:51
@swghosh swghosh force-pushed the OCPNODE-854 branch 2 times, most recently from 64573c7 to 42eed76 Compare March 10, 2022 22:59
@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Mar 10, 2022
@swghosh swghosh changed the title Draft: Config Observer Hacks Update Config Observer for nodes.config.openshift.io WorkerLatencyProfile Mar 10, 2022
@swghosh swghosh marked this pull request as draft March 14, 2022 15:44
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2022
@swghosh swghosh changed the title Update Config Observer for nodes.config.openshift.io WorkerLatencyProfile WIP: Update Config Observer for nodes.config.openshift.io WorkerLatencyProfile Mar 15, 2022
@swghosh swghosh changed the title WIP: Update Config Observer for nodes.config.openshift.io WorkerLatencyProfile [WIP]: Update Config Observer for nodes.config.openshift.io WorkerLatencyProfile Mar 15, 2022
@swghosh swghosh force-pushed the OCPNODE-854 branch 2 times, most recently from 4f336de to 872e896 Compare March 16, 2022 09:15
@swghosh
Copy link
Member Author

swghosh commented Mar 18, 2022

/test all

@swghosh
Copy link
Member Author

swghosh commented Mar 18, 2022

/retest-required

@swghosh
Copy link
Member Author

swghosh commented Mar 28, 2022

/retest

@swghosh
Copy link
Member Author

swghosh commented Mar 29, 2022

/retest-required

@swghosh swghosh force-pushed the OCPNODE-854 branch 2 times, most recently from 83d5c40 to 96f5b52 Compare March 30, 2022 22:46
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2022
@swghosh swghosh force-pushed the OCPNODE-854 branch 2 times, most recently from c0f8f48 to 505e84a Compare May 11, 2022 06:32
@swghosh
Copy link
Member Author

swghosh commented May 11, 2022

/assign @p0lyn0mial

@swghosh
Copy link
Member Author

swghosh commented May 11, 2022

/retest

@p0lyn0mial
Copy link
Contributor

p0lyn0mial commented May 12, 2022

once the library-go PR merges, please split into two commits, one for the bump and the second for actual changes.

@p0lyn0mial
Copy link
Contributor

p0lyn0mial commented May 12, 2022

/retest-required

@harche
Copy link

harche commented May 12, 2022

/retest-required

@swghosh
Copy link
Member Author

swghosh commented May 13, 2022

Invoked the implementation of latency profile config observer and latency profile controller introduced in openshift/library-go#1364.

@p0lyn0mial you may PTAL.

@swghosh
Copy link
Member Author

swghosh commented May 13, 2022

/remove-hold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2022
@harche
Copy link

harche commented May 13, 2022

/retest-required

@p0lyn0mial
Copy link
Contributor

p0lyn0mial commented May 13, 2022 •
edited
Loading

/lgtm
/approve

thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, swghosh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2022
@openshift-bot
Copy link
Contributor

openshift-bot commented May 13, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 13, 2022

@swghosh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator-disruptive-single-node 268d437 link false /test e2e-aws-operator-disruptive-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ace7a66 into openshift:master May 13, 2022
@harche harche deleted the OCPNODE-854 branch May 13, 2022 10:18
@harche harche restored the OCPNODE-854 branch May 13, 2022 10:18
@swghosh swghosh mentioned this pull request Jun 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@sttts sttts Awaiting requested review from sttts

@tkashem tkashem Awaiting requested review from tkashem

@rphillips rphillips Awaiting requested review from rphillips

3 more reviewers

@soltysh soltysh soltysh left review comments

@harche harche harche left review comments

@p0lyn0mial p0lyn0mial p0lyn0mial left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@p0lyn0mial p0lyn0mial

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@swghosh @rphillips @nee1esh @p0lyn0mial @harche @openshift-bot @mfojtik @soltysh @openshift-merge-robot