Skip to content

Conversation

@Miciah
Copy link
Contributor

@Miciah Miciah commented Oct 19, 2023

Bump the vendored golang.org/x/net package to v0.17.0 in order to remedy CVE-2023-44487 (the "Rapid Reset Attack") using the following commands:

go get golang.org/x/[email protected]
go mod tidy
go mod vendor
  • go.mod: Bump.
  • go.sum:
  • vendor/*: Regenerate.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 19, 2023
@openshift-ci-robot
Copy link
Contributor

@Miciah: This pull request references Jira Issue OCPBUGS-20765, which is invalid:

  • expected dependent Jira Issue OCPBUGS-20781 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bump the vendored golang.org/x/net package to v0.17.0 in order to remedy CVE-2023-44487 (the "Rapid Reset Attack").

  • go.mod: Bump.
  • go.sum:
  • vendor/*: Regenerate.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah Miciah changed the title OCPBUGS-20765: Bump golang.org/x/net for CVE-2023-44487 [release-4.12] OCPBUGS-20765: Bump golang.org/x/net for CVE-2023-44487 Oct 19, 2023
@openshift-ci openshift-ci bot requested review from candita and knobunc October 19, 2023 14:10
Bump the vendored golang.org/x/net package to v0.17.0 in order to remedy CVE-2023-44487 (the "Rapid Reset Attack") using the following commands:

go get golang.org/x/[email protected]
go mod tidy
go mod vendor

This commit fixes OCPBUGS-20765.

https://issues.redhat.com/browse/OCPBUGS-20765

* go.mod: Bump.
* go.sum:
* vendor/*: Regenerate.
@Miciah Miciah force-pushed the OCPBUGS-20765-CVE-2023-44487 branch from 1ac9c3e to 461ad0d Compare October 20, 2023 15:22
@Miciah
Copy link
Contributor Author

Miciah commented Oct 20, 2023

@Miciah
Copy link
Contributor Author

Miciah commented Oct 26, 2023

e2e-aws-operator failed, and events.json has Failed to pull image "openshift/origin-node": rpc error: code = Unknown desc = reading manifest latest in docker.io/openshift/origin-node: errors:\ndenied: requested access to the resource is denied errors. Looks like we need to backport OCPBUGS-17359 to the release-4.12 branch.

@Miciah
Copy link
Contributor Author

Miciah commented Oct 26, 2023

#992 should fix the "failed to pull image" failures.

@candita
Copy link
Contributor

candita commented Oct 26, 2023

/retest

@Miciah
Copy link
Contributor Author

Miciah commented Oct 27, 2023

I'm still seeing Failed to pull image "openshift/origin-node"in events.json for the last run of e2e-aws-operator.

build-log.txt shows that the build used https://github.com/openshift/cluster-ingress-operator/commits/0bb8ffc4:

 �[36mINFO�[0m[2023-10-26T23:35:34Z] Resolved source https://github.com/openshift/cluster-ingress-operator to release-4.12@0bb8ffc4, merging: #988 461ad0de @Miciah 

However, we need https://github.com/openshift/cluster-ingress-operator/commits/69f83b13 to get the changes in #992. I expect the job will l get those changes if it runs again.
/test e2e-aws-operator

@ShudiLi
Copy link
Member

ShudiLi commented Nov 1, 2023

tested it with 4.12.0-0.ci.test-2023-11-01-021158-ci-ln-is1v2kt-latest
`
1.
% oc get clusterversion
NAME VERSION AVAILABLE PROGRESSING SINCE STATUS
version 4.12.0-0.ci.test-2023-11-01-021158-ci-ln-is1v2kt-latest True False 10m Cluster version is 4.12.0-0.ci.test-2023-11-01-021158-ci-ln-is1v2kt-latest

% oc -n openshift-ingress-operator get pods
NAME READY STATUS RESTARTS AGE
ingress-operator-685cdbcd9d-lhmp7 2/2 Running 2 (23m ago) 32m

shudi@Shudis-MacBook-Pro po % oc rsync -n openshift-ingress-operator ingress-operator-685cdbcd9d-lhmp7:/usr/bin/ingress-operator .
receiving file list ... done
ingress-operator

% go version -m ingress-operator| grep golang.org
dep golang.org/x/crypto v0.14.0
dep golang.org/x/net v0.17.0
dep golang.org/x/oauth2 v0.0.0-20220411215720-9780585627b5
dep golang.org/x/sys v0.13.0
dep golang.org/x/term v0.13.0
dep golang.org/x/text v0.13.0
dep golang.org/x/time v0.0.0-20220609170525-579cf78fd858
dep google.golang.org/api v0.57.0
dep google.golang.org/genproto v0.0.0-20220502173005-c8bf987b8c21
dep google.golang.org/grpc v1.47.0
dep google.golang.org/protobuf v1.28.0
%
`

@Miciah
Copy link
Contributor Author

Miciah commented Nov 1, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 1, 2023
@openshift-ci-robot
Copy link
Contributor

@Miciah: This pull request references Jira Issue OCPBUGS-20765, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-20781 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-20781 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact:
/cc @ShudiLi

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from ShudiLi November 1, 2023 08:19
@frobware
Copy link
Contributor

frobware commented Nov 1, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2023
@ShudiLi
Copy link
Member

ShudiLi commented Nov 1, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 1, 2023
@candita
Copy link
Contributor

candita commented Nov 1, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 1, 2023
@melvinjoseph86
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 1, 2023
@melvinjoseph86
Copy link

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@melvinjoseph86: This pull request references Jira Issue OCPBUGS-20765, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-20781 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-20781 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact:
/cc @ShudiLi

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 1, 2023

@Miciah: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 5e62d56 into openshift:release-4.12 Nov 1, 2023
@openshift-ci-robot
Copy link
Contributor

@Miciah: Jira Issue OCPBUGS-20765: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-20765 has been moved to the MODIFIED state.

Details

In response to this:

Bump the vendored golang.org/x/net package to v0.17.0 in order to remedy CVE-2023-44487 (the "Rapid Reset Attack") using the following commands:

go get golang.org/x/[email protected]
go mod tidy
go mod vendor

  • go.mod: Bump.
  • go.sum:
  • vendor/*: Regenerate.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.12.0-0.nightly-2023-11-02-003745

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-ingress-operator-container-v4.12.0-202311220908.p0.g5e62d56.assembly.stream for distgit ose-cluster-ingress-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants