NETOBSERV-1052: Add monitoring dashboard controller to create dashboard configmap by OlivierCazade · Pull Request #962 · openshift/cluster-ingress-operator

OlivierCazade · 2023-07-19T08:40:13Z

This PR add a new controller to manage a configmap to deploy monitoring dashboard.

The configmap is deployed as long as the controlPlaneTopology is not set to external.

The dashboard itself is there as an example but I wanted to open the PR to start getting review on the controller part.

I am going to look more precisely about what would be the most valuable to display in the dashboard.

openshift-ci-robot · 2023-07-19T08:40:15Z

@OlivierCazade: This pull request references NETOBSERV-1052 which is a valid jira issue.

Details

In response to this:

This PR add a new controller to manage a configmap to deploy monitoring dashboard.

The configmap is deployed as long as the controlPlaneTopology is not set to external.

The dashboard itself is there as an example but I wanted to open the PR to start getting review on the controller part.

I am going to look more precisely about what would be the most valuable to display in the dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

candita · 2023-07-25T23:01:55Z

@OlivierCazade there is a verify error - no linkage to new e2e test.

candita · 2023-07-26T15:42:54Z

/assign @frobware

pkg/operator/controller/monitoring-dashboard/monitoring_dashboard.go

test/e2e/dashboard_test.go

pkg/operator/controller/monitoring-dashboard/monitoring_dashboard.go

pkg/operator/controller/monitoring-dashboard/dashboard.json

test/e2e/dashboard_test.go

candita · 2023-08-09T16:20:07Z

/assign

openshift-ci-robot · 2023-10-09T15:24:45Z

@OlivierCazade: This pull request references NETOBSERV-1052 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but it targets "openshift-4.14" instead.

Details

In response to this:

This PR add a new controller to manage a configmap to deploy monitoring dashboard.

The configmap is deployed as long as the controlPlaneTopology is not set to external.

The dashboard itself is there as an example but I wanted to open the PR to start getting review on the controller part.

I am going to look more precisely about what would be the most valuable to display in the dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Co-authored-by: Andrew McDermott <frobware@users.noreply.github.com>

openshift-ci-robot · 2023-10-09T15:26:57Z

@OlivierCazade: This pull request references NETOBSERV-1052 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but it targets "openshift-4.14" instead.

Details

In response to this:

This PR add a new controller to manage a configmap to deploy monitoring dashboard.

The configmap is deployed as long as the controlPlaneTopology is not set to external.

The dashboard itself is there as an example but I wanted to open the PR to start getting review on the controller part.

I am going to look more precisely about what would be the most valuable to display in the dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

OlivierCazade · 2023-10-12T12:59:27Z

/retest

pkg/operator/controller/monitoring-dashboard/monitoring_dashboard.go

test/e2e/all_test.go

pkg/operator/controller/monitoring-dashboard/monitoring_dashboard.go

test/e2e/dashboard_test.go

pkg/operator/controller/monitoring-dashboard/controller.go

frobware · 2023-11-09T20:48:55Z

/lgtm
/hold

The EP needs approval.

frobware · 2023-11-28T16:47:11Z

/retest

frobware · 2023-11-28T18:18:13Z

/label tide/merge-method-squash
/lgtm
/approve

Cancelling the hold per: https://redhat-internal.slack.com/archives/C05FWJDFPL4/p1701189670070019?thread_ts=1697538070.044369&cid=C05FWJDFPL4

/hold cancel

openshift-ci · 2023-11-28T18:27:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [frobware]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2023-11-28T18:37:24Z

/retest-required

Remaining retests: 0 against base HEAD 30833ad and 2 for PR HEAD 381ce5f in total

frobware · 2023-11-28T18:54:16Z

Note: The e2e-gcp-operator job is permanently failing at the moment; see slack thread https://redhat-internal.slack.com/archives/CBZHF4DHC/p1694792730351859.

Bug# pending.

frobware · 2023-11-28T19:12:12Z

Note: The e2e-gcp-operator job is permanently failing at the moment; see slack thread https://redhat-internal.slack.com/archives/CBZHF4DHC/p1694792730351859.

Bug# pending.

https://issues.redhat.com/browse/OCPBUGS-24044

Miciah · 2023-11-28T23:21:05Z

e2e-gcp-operator failed again because TestUnmanagedDNSToManagedDNSInternalIngressController failed, which is a known issue (OCPBUGS-24044), and this PR doesn't change anything that would impact GCP specifically, so we can override the test failure.
/override ci/prow/e2e-gcp-operator

openshift-ci · 2023-11-28T23:21:23Z

@Miciah: Overrode contexts on behalf of Miciah: ci/prow/e2e-gcp-operator

Details

In response to this:

e2e-gcp-operator failed again because TestUnmanagedDNSToManagedDNSInternalIngressController failed, which is a known issue (OCPBUGS-24044), and this PR doesn't change anything that would impact GCP specifically, so we can override the test failure.
/override ci/prow/e2e-gcp-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-11-28T23:21:24Z

@OlivierCazade: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2023-11-29T01:16:26Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-ingress-operator-container-v4.15.0-202311290051.p0.gbd29f8a.assembly.stream for distgit ose-cluster-ingress-operator.
All builds following this will include this PR.

frobware · 2023-11-29T16:29:27Z

I added some tooling to verify the server response errors here: https://github.com/frobware/openshift-ingress-dashboard-test.

…rd configmap (openshift#962) * Add monitoring dashboard controller to create dashboard configmap * Apply suggestions from code review Co-authored-by: Andrew McDermott <frobware@users.noreply.github.com> * Corrections from code review * Added graphs in dashboard * Updated graph with per route and per namespace sections * Removed blank lines * Added per shard graphs * Limit each graph to top 10 values * Filtering blank routes and some title changes * Title rewording * Filtering null metrics and metrics without routes in the per shard graph * Addressing PR comments * Changed http error formula * Error rate title wording and filtering out empty route error rate --------- Co-authored-by: Andrew McDermott <frobware@users.noreply.github.com>

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 19, 2023

openshift-ci bot requested review from candita and miheer July 19, 2023 08:42

openshift-ci bot assigned frobware Jul 26, 2023

OlivierCazade force-pushed the dashboard-controller branch from a36bde0 to 3138949 Compare July 28, 2023 13:12

frobware requested changes Aug 2, 2023

View reviewed changes

openshift-ci bot assigned candita Aug 9, 2023

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2023

OlivierCazade and others added 5 commits October 9, 2023 17:26

Add monitoring dashboard controller to create dashboard configmap

becbe6a

Apply suggestions from code review

0e7e8e9

Co-authored-by: Andrew McDermott <frobware@users.noreply.github.com>

Corrections from code review

7f15887

Added graphs in dashboard

1ae9d06

Updated graph with per route and per namespace sections

5560819

OlivierCazade force-pushed the dashboard-controller branch from 398032f to 5560819 Compare October 9, 2023 15:26

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2023

OlivierCazade added 2 commits October 9, 2023 17:29

Removed blank lines

d51776b

Added per shard graphs

592677f

OlivierCazade added 4 commits October 19, 2023 17:28

Limit each graph to top 10 values

f647474

Filtering blank routes and some title changes

b429118

Title rewording

f0ba780

Filtering null metrics and metrics without routes in the per shard graph

a803900

frobware requested changes Nov 7, 2023

View reviewed changes

frobware reviewed Nov 7, 2023

View reviewed changes

test/e2e/dashboard_test.go Show resolved Hide resolved

OlivierCazade force-pushed the dashboard-controller branch from 908255f to d20b06e Compare November 7, 2023 16:43

frobware reviewed Nov 8, 2023

View reviewed changes

pkg/operator/controller/monitoring-dashboard/controller.go Outdated Show resolved Hide resolved

Addressing PR comments

8bf16bc

OlivierCazade force-pushed the dashboard-controller branch from d20b06e to 8bf16bc Compare November 9, 2023 13:45

openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Nov 9, 2023

Changed http error formula

e621c76

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2023

Error rate title wording and filtering out empty route error rate

381ce5f

jotak mentioned this pull request Nov 28, 2023

OCPSTRAT-139: Ingress operator dashboard openshift/enhancements#1431

Merged

frobware approved these changes Nov 28, 2023

View reviewed changes

openshift-ci bot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 28, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2023

openshift-merge-bot bot merged commit bd29f8a into openshift:master Nov 28, 2023

Conversation

OlivierCazade commented Jul 19, 2023

Uh oh!

openshift-ci-robot commented Jul 19, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

candita commented Jul 25, 2023

Uh oh!

candita commented Jul 26, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

candita commented Aug 9, 2023

Uh oh!

openshift-ci-robot commented Oct 9, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 9, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OlivierCazade commented Oct 12, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

frobware commented Nov 9, 2023

Uh oh!

frobware commented Nov 28, 2023

Uh oh!

frobware commented Nov 28, 2023

Uh oh!

openshift-ci bot commented Nov 28, 2023

Uh oh!

openshift-ci-robot commented Nov 28, 2023

Uh oh!

frobware commented Nov 28, 2023

Uh oh!

frobware commented Nov 28, 2023

Uh oh!

Miciah commented Nov 28, 2023

Uh oh!

openshift-ci bot commented Nov 28, 2023

Uh oh!

openshift-ci bot commented Nov 28, 2023

Uh oh!

openshift-bot commented Nov 29, 2023

Uh oh!

frobware commented Nov 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

openshift-ci-robot commented Jul 19, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 9, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 9, 2023 •

edited by openshift-ci bot

Loading