Skip to content

Conversation

@rfredette
Copy link
Contributor

Copy of #941 with #904 test fix included

rfredette and others added 4 commits June 1, 2023 18:51
Leave a stub of the CRL controller to clean up any existing configmaps.
The stub controller will need to be removed in a future release

Use cluster-wide proxy for CRL downloads when available

Add a test with several test cases to test CRL management, and a test to
test CRL updates
…eteWithOldPodTermination

Also:
- Rename pods to podList
- When checking for old pod termination, only count the currently ready
  pods, instead of all pods
Follow-up to commit 20e4e38.

* test/e2e/operator_test.go
(waitForDeploymentCompleteWithOldPodTermination): Correct the function name
in the godoc.  Use "k8s.io/utils/pointer".Int32Deref, and respect the value
in spec.replicas even if it is set explicitly to 0.
@openshift-ci openshift-ci bot requested review from candita and gcs278 June 7, 2023 19:20
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rfredette. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2023

@rfredette: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator ad827a1 link true /test e2e-aws-operator
ci/prow/e2e-gcp-ovn-serial ad827a1 link true /test e2e-gcp-ovn-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rfredette rfredette closed this Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants