[release-4.11] OCPBUGS-14456, OCPBUGS-14457: Handle mTLS CRLs, and fix accidental CRL duplication by rfredette · Pull Request #942 · openshift/cluster-ingress-operator

rfredette · 2023-06-01T23:16:38Z

Manual cherry pick & squash of #939

Leave a stub of the CRL controller to clean up any existing configmaps. The stub controller will need to be removed in a future release

Use cluster-wide proxy for CRL downloads when available

Add a test with several test cases to test CRL management, and a test to test CRL updates

openshift-ci-robot · 2023-06-01T23:16:43Z

@rfredette: This pull request references Jira Issue OCPBUGS-14457, which is invalid:

expected Jira Issue OCPBUGS-14457 to depend on a bug targeting a version in 4.12.0, 4.12.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual cherry pick & squash of #939

Leave a stub of the CRL controller to clean up any existing configmaps. The stub controller will need to be removed in a future release

Use cluster-wide proxy for CRL downloads when available

Add a test with several test cases to test CRL management, and a test to test CRL updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Leave a stub of the CRL controller to clean up any existing configmaps. The stub controller will need to be removed in a future release Use cluster-wide proxy for CRL downloads when available Add a test with several test cases to test CRL management, and a test to test CRL updates

frobware · 2023-06-02T17:49:49Z

/hold

This PR (and the tests) depends on openshift/router#492.

frobware · 2023-06-05T13:23:24Z

e2e-aws-operator - FAIL: TestAll/parallel/TestAWSELBConnectionIdleTimeout, which is bug https://issues.redhat.com/browse/OCPBUGS-13810.

Investigation for 13810 happening in: #940.

frobware · 2023-06-05T13:24:22Z

e2e-aws-single-node - "Failed while waiting on imagestream import"

/test e2e-aws-single-node

frobware · 2023-06-05T16:22:19Z

/test e2e-aws-operatoe

I see failures for the mTLS tests:

        --- FAIL: TestAll/parallel/TestCRLUpdate (391.96s)
            --- FAIL: TestAll/parallel/TestCRLUpdate/certificate-distributes-its-own-crl (100.07s)
            --- FAIL: TestAll/parallel/TestCRLUpdate/certificate-distributes-its-signers-crl (101.13s)
            --- FAIL: TestAll/parallel/TestCRLUpdate/certificate-distributes-its-signers-crl-with-workaround (94.11s)
            --- FAIL: TestAll/parallel/TestCRLUpdate/many-CAs-with-signers-crl-workaround (96.51s)
        --- FAIL: TestAll/parallel/TestMTLSWithCRLs (526.73s)
            --- FAIL: TestAll/parallel/TestMTLSWithCRLs/certificate-distributes-its-own-crl (102.39s)
            --- FAIL: TestAll/parallel/TestMTLSWithCRLs/certificate-distributes-its-signers-crl (101.77s)
            --- FAIL: TestAll/parallel/TestMTLSWithCRLs/certificate-distributes-its-signers-crl-with-workaround (102.69s)
            --- FAIL: TestAll/parallel/TestMTLSWithCRLs/large-crl (104.38s)
            --- FAIL: TestAll/parallel/TestMTLSWithCRLs/multiple-intermediate-ca (105.24s)

openshift-ci · 2023-06-05T16:22:28Z

@frobware: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-aws
/test e2e-aws-operator
/test e2e-aws-upgrade
/test e2e-gcp-serial
/test images
/test unit
/test verify

The following commands are available to trigger optional jobs:

/test e2e-aws-single-node
/test e2e-azure
/test e2e-azure-operator
/test e2e-gcp-operator

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-cluster-ingress-operator-release-4.11-e2e-aws
pull-ci-openshift-cluster-ingress-operator-release-4.11-e2e-aws-operator
pull-ci-openshift-cluster-ingress-operator-release-4.11-e2e-aws-single-node
pull-ci-openshift-cluster-ingress-operator-release-4.11-e2e-aws-upgrade
pull-ci-openshift-cluster-ingress-operator-release-4.11-e2e-gcp-serial
pull-ci-openshift-cluster-ingress-operator-release-4.11-images
pull-ci-openshift-cluster-ingress-operator-release-4.11-unit
pull-ci-openshift-cluster-ingress-operator-release-4.11-verify

Details

In response to this:

/test e2e-aws-operatoe

I see failures for the mTLS tests:

       --- FAIL: TestAll/parallel/TestCRLUpdate (391.96s)
           --- FAIL: TestAll/parallel/TestCRLUpdate/certificate-distributes-its-own-crl (100.07s)
           --- FAIL: TestAll/parallel/TestCRLUpdate/certificate-distributes-its-signers-crl (101.13s)
           --- FAIL: TestAll/parallel/TestCRLUpdate/certificate-distributes-its-signers-crl-with-workaround (94.11s)
           --- FAIL: TestAll/parallel/TestCRLUpdate/many-CAs-with-signers-crl-workaround (96.51s)
       --- FAIL: TestAll/parallel/TestMTLSWithCRLs (526.73s)
           --- FAIL: TestAll/parallel/TestMTLSWithCRLs/certificate-distributes-its-own-crl (102.39s)
           --- FAIL: TestAll/parallel/TestMTLSWithCRLs/certificate-distributes-its-signers-crl (101.77s)
           --- FAIL: TestAll/parallel/TestMTLSWithCRLs/certificate-distributes-its-signers-crl-with-workaround (102.69s)
           --- FAIL: TestAll/parallel/TestMTLSWithCRLs/large-crl (104.38s)
           --- FAIL: TestAll/parallel/TestMTLSWithCRLs/multiple-intermediate-ca (105.24s)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

frobware · 2023-06-05T16:24:27Z

/test e2e-aws-operator

frobware · 2023-06-05T19:44:00Z

/test e2e-aws-operatoe

I see failures for the mTLS tests:

        --- FAIL: TestAll/parallel/TestCRLUpdate (391.96s)
            --- FAIL: TestAll/parallel/TestCRLUpdate/certificate-distributes-its-own-crl (100.07s)
            --- FAIL: TestAll/parallel/TestCRLUpdate/certificate-distributes-its-signers-crl (101.13s)
            --- FAIL: TestAll/parallel/TestCRLUpdate/certificate-distributes-its-signers-crl-with-workaround (94.11s)
            --- FAIL: TestAll/parallel/TestCRLUpdate/many-CAs-with-signers-crl-workaround (96.51s)
        --- FAIL: TestAll/parallel/TestMTLSWithCRLs (526.73s)
            --- FAIL: TestAll/parallel/TestMTLSWithCRLs/certificate-distributes-its-own-crl (102.39s)
            --- FAIL: TestAll/parallel/TestMTLSWithCRLs/certificate-distributes-its-signers-crl (101.77s)
            --- FAIL: TestAll/parallel/TestMTLSWithCRLs/certificate-distributes-its-signers-crl-with-workaround (102.69s)
            --- FAIL: TestAll/parallel/TestMTLSWithCRLs/large-crl (104.38s)
            --- FAIL: TestAll/parallel/TestMTLSWithCRLs/multiple-intermediate-ca (105.24s)

This is not a problem; see #942 (comment).

frobware · 2023-06-05T19:44:13Z

/lgtm

Miciah · 2023-06-05T21:00:40Z

/approve
/label backport-risk-assessed

lihongan · 2023-06-06T02:34:05Z

/label cherry-pick-approved,

openshift-ci · 2023-06-06T02:34:07Z

@lihongan: The label(s) /label cherry-pick-approved, cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, rebase/manual, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label cherry-pick-approved,

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lihongan · 2023-06-06T02:34:30Z

/label cherry-pick-approved

lihongan · 2023-06-08T07:10:10Z

/unhold
since openshift/router#492 get merged

lihongan · 2023-06-08T07:14:44Z

/retest-required

lihongan · 2023-06-08T07:23:08Z

/jira refresh

openshift-ci-robot · 2023-06-08T07:23:13Z

@lihongan: This pull request references Jira Issue OCPBUGS-14457, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.11.z) matches configured target version for branch (4.11.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-14455 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-14455 targets the "4.12.z" version, which is one of the valid target versions: 4.12.0, 4.12.z
bug has dependents

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

frobware · 2023-06-08T07:34:26Z

/test all

openshift-ci-robot · 2023-06-08T08:33:49Z

/retest-required

Remaining retests: 0 against base HEAD ce29f22 and 2 for PR HEAD e8a2a58 in total

frobware · 2023-06-08T09:50:41Z

level=fatal msg=failed to fetch Terraform Variables: failed to fetch dependency of "Terraform Variables": failed to generate asset "Platform Provisioning Check": baseDomain: Invalid value: "origin-ci-int-aws.dev.rhcloud.com": the zone already has record sets for the domain of the cluster: [api.ci-op-ih8pi4zj-51128.origin-ci-int-aws.dev.rhcloud.com. (A), \052.apps.ci-op-ih8pi4zj-51128.origin-ci-int-aws.dev.rhcloud.com. (A)]
Installer exit with code 1

/test e2e-aws-operator

frobware · 2023-06-08T09:51:56Z

Failed: [sig-arch][Late] operators should not create watch channels very often [Suite:openshift/conformance/parallel]

/test e2e-aws-single-node

frobware · 2023-06-08T10:39:06Z

level=fatal msg=failed to fetch Terraform Variables: failed to fetch dependency of "Terraform Variables": failed to generate asset "Platform Provisioning Check": baseDomain: Invalid value: "origin-ci-int-aws.dev.rhcloud.com": the zone already has record sets for the domain of the cluster: [api.ci-op-ih8pi4zj-51128.origin-ci-int-aws.dev.rhcloud.com. (A), \052.apps.ci-op-ih8pi4zj-51128.origin-ci-int-aws.dev.rhcloud.com. (A)] Installer exit with code 1

/test e2e-aws-operator

See also: https://redhat-internal.slack.com/archives/CEKNRGF25/p1686218879266109

x509.RevocationList was added in go 1.19 (deprecating pkix.CertificateList), but 4.11 is built with go 1.18.

frobware · 2023-06-08T11:02:37Z

New changes are detected. LGTM label has been removed.

This is a no-edit commit. See: https://redhat-internal.slack.com/archives/CEKNRGF25/p1686220147776379?thread_ts=1686218879.266109&cid=CEKNRGF25

/lgtm
/approve

openshift-ci · 2023-06-08T11:03:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Miciah,frobware]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

frobware · 2023-06-08T13:18:32Z

/skip

openshift-ci · 2023-06-08T13:29:23Z

@rfredette: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-single-node	`1e9876c`	link	false	`/test e2e-aws-single-node`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2023-06-08T13:32:30Z

@rfredette: Jira Issue OCPBUGS-14457: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14457 has been moved to the MODIFIED state.

Details

In response to this:

Manual cherry pick & squash of #939

Leave a stub of the CRL controller to clean up any existing configmaps. The stub controller will need to be removed in a future release

Use cluster-wide proxy for CRL downloads when available

Add a test with several test cases to test CRL management, and a test to test CRL updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot · 2023-06-09T00:44:32Z

Fix included in accepted release 4.11.0-0.nightly-2023-06-08-182148

openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jun 1, 2023

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 1, 2023

openshift-ci bot requested review from Miciah and candita June 1, 2023 23:17

rfredette force-pushed the ocpbugs-9464-4.11 branch from 925c0e5 to fbb9d67 Compare June 1, 2023 23:36

rfredette force-pushed the ocpbugs-9464-4.11 branch from fbb9d67 to 1f0f54a Compare June 1, 2023 23:41

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2023

openshift-ci bot assigned frobware Jun 5, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2023

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 5, 2023

openshift-ci bot assigned lihongan, melvinjoseph86 and ShudiLi Jun 5, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2023

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 6, 2023

openshift-ci-robot mentioned this pull request Jun 8, 2023

[release-4.11] OCPBUGS-14456, OCPBUGS-14457: Handle mTLS CRLs, and fix accidental CRL duplication openshift/router#492

Merged

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2023

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 8, 2023

openshift-ci bot requested a review from lihongan June 8, 2023 07:23

Convert tests to use pkix.CertificateList instead of x509.RevocationList

1e9876c

x509.RevocationList was added in go 1.19 (deprecating pkix.CertificateList), but 4.11 is built with go 1.18.

frobware force-pushed the ocpbugs-9464-4.11 branch from e8a2a58 to 1e9876c Compare June 8, 2023 11:01

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2023

openshift-merge-robot merged commit 681e8de into openshift:release-4.11 Jun 8, 2023

Conversation

rfredette commented Jun 1, 2023

Uh oh!

openshift-ci-robot commented Jun 1, 2023

Uh oh!

frobware commented Jun 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

frobware commented Jun 5, 2023

Uh oh!

frobware commented Jun 5, 2023

Uh oh!

frobware commented Jun 5, 2023

Uh oh!

openshift-ci bot commented Jun 5, 2023

Uh oh!

frobware commented Jun 5, 2023

Uh oh!

frobware commented Jun 5, 2023

Uh oh!

frobware commented Jun 5, 2023

Uh oh!

Miciah commented Jun 5, 2023

Uh oh!

lihongan commented Jun 6, 2023

Uh oh!

openshift-ci bot commented Jun 6, 2023

Uh oh!

lihongan commented Jun 6, 2023

Uh oh!

lihongan commented Jun 8, 2023

Uh oh!

lihongan commented Jun 8, 2023

Uh oh!

lihongan commented Jun 8, 2023

Uh oh!

openshift-ci-robot commented Jun 8, 2023

Uh oh!

frobware commented Jun 8, 2023

Uh oh!

openshift-ci-robot commented Jun 8, 2023

Uh oh!

frobware commented Jun 8, 2023

Uh oh!

frobware commented Jun 8, 2023

Uh oh!

frobware commented Jun 8, 2023

Uh oh!

frobware commented Jun 8, 2023

Uh oh!

openshift-ci bot commented Jun 8, 2023

Uh oh!

frobware commented Jun 8, 2023

Uh oh!

openshift-ci bot commented Jun 8, 2023

Uh oh!

openshift-ci-robot commented Jun 8, 2023

Uh oh!

openshift-merge-robot commented Jun 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Comments

frobware commented Jun 2, 2023 •

edited

Loading