OCPBUGS-13963: Bump vendors k8s libraries to 0.27.2 #936
Conversation
openshift-ci-robot
added
jira/severity-important
|
@gcs278: This pull request references Jira Issue OCPBUGS-13963, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
E2E installation failure. Looks like ingress operator won't start with: Reading through release notes now... |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/assign @alebedev87 |
gcs278
force-pushed
the
k8s-1.27
branch
2 times, most recently
from
e08007a to
3e14ebe
Compare
|
/retest |
|
disruption issue |
gcs278
force-pushed
the
k8s-1.27
branch
4 times, most recently
from
8df9ad4 to
f8398f5
Compare
alebedev87
left a comment
alebedev87
left a comment
There was a problem hiding this comment.
LGTM, just 2 last remarks.
pkg/operator/controller/sync-http-error-code-configmap/controller.go
Outdated
Show resolved
Hide resolved
gcs278
force-pushed
the
k8s-1.27
branch
2 times, most recently
from
d911c1c to
050e4d1
Compare
|
@gcs278: This pull request references Jira Issue OCPBUGS-13963, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@gcs278: This pull request references Jira Issue OCPBUGS-13963, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
|
|
|
go get k8s.io/api@v0.27.2
go get sigs.k8s.io/controller-runtime@v0.15.0
go mod tidy
go mod vendor
`go.mod`: Bumped to GO 1.20, controller-runtime, api, and dependencies.
`pkg/operator/client/client.go`: Created HTTPClient for updated for
NewDiscoveryRESTMapper function definitiont.
`pkg/operator/controller/canary/controller.go`,
`pkg/operator/controller/certificate-publisher/controller.go`,
`pkg/operator/controller/certificate/controller.go`,
`pkg/operator/controller/clientca-configmap/controller.go`,
`pkg/operator/controller/configurable-route/controller.go`,
`pkg/operator/controller/crl/controller.go`,
`pkg/operator/controller/dns/controller.go`,
`pkg/operator/controller/gateway-service-dns/controller.go`,
`pkg/operator/controller/gatewayapi/controller.go`,
`pkg/operator/controller/gatewayclass/controller.go`,
`pkg/operator/controller/ingress/controller.go`,
`pkg/operator/controller/ingressclass/controller.go`,
`pkg/operator/controller/route-metrics/controller.go`,
`pkg/operator/controller/status/controller.go`,
`pkg/operator/controller/sync-http-error-code-configmap/controller.go`:
Updates for source.Kind conversion from type to function, MapFunc definition
update to add context argument, handler.EnqueueRequestForOwner definition update
for scheme and mapper.
`pkg/operator/operator.go`: Removed deprecated MultiNamespacedCacheBuilder for
cache.Options{}. Added override to client.Options.Cache in NewClient function
so client won't use cache. Removed deprecated Namespace manager.Options{} field.
`pkg/operator/controller/dns/controller_test.go`: TestMigrateDNSRecordStatus:
Updated to `NewClientBuilder()`. controller-runtime v0.15.0 required add
`WithStatusSubresource()` to create an object with a status. Added t.Run().
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@gcs278: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
e2e-aws-operator failed because |
|
@Miciah: Overrode contexts on behalf of Miciah: ci/prow/e2e-aws-operator DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
e2e-aws-ovn-upgrade failed on I don't think it's related. |
|
Investigating the e2e-gcp-ovn and e2e-azure-ovn failures may be useful for improving product stability, but note that those failing jobs are currently optional and thus do not block this PR from merging. |
|
True, I habitually started overlooking them, so it's a good reminder to review. And same thing with e2e-gcp-ovn: Discussion here: https://redhat-internal.slack.com/archives/CDCP2LA9L/p1685464016247739 |
|
/refresh |
|
@gcs278: Jira Issue OCPBUGS-13963: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-13963 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
OCPBUGS-13963: Bump vendors k8s libraries to 0.27.2
go.mod: Bumped to GO 1.20, controller-runtime, api, and dependencies.pkg/operator/client/client.go: Created HTTPClient for updated for NewDiscoveryRESTMapper function definitiont.pkg/operator/controller/canary/controller.go,pkg/operator/controller/certificate-publisher/controller.go,pkg/operator/controller/certificate/controller.go,pkg/operator/controller/clientca-configmap/controller.go,pkg/operator/controller/configurable-route/controller.go,pkg/operator/controller/crl/controller.go,pkg/operator/controller/dns/controller.go,pkg/operator/controller/gateway-service-dns/controller.go,pkg/operator/controller/gatewayapi/controller.go,pkg/operator/controller/gatewayclass/controller.go,pkg/operator/controller/ingress/controller.go,pkg/operator/controller/ingressclass/controller.go,pkg/operator/controller/route-metrics/controller.go,pkg/operator/controller/status/controller.go,pkg/operator/controller/sync-http-error-code-configmap/controller.go: Updates for source.Kind conversion from type to function, MapFunc definition update to add context argument, handler.EnqueueRequestForOwner definition update for scheme and mapper.pkg/operator/operator.go: Removed deprecated MultiNamespacedCacheBuilder for cache.Options{}. Added override to client.Options.Cache in NewClient function so client won't use cache. Removed deprecated Namespace manager.Options{} field.pkg/operator/controller/dns/controller_test.go: TestMigrateDNSRecordStatus: Updated toNewClientBuilder(). controller-runtime v0.15.0 required addWithStatusSubresource()to create an object with a status. Added t.Run()