Skip to content

[release-4.13] OCPBUGS-13157: Deflake TestRouterCompressionOperation#926

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.13from
openshift-cherrypick-robot:cherry-pick-920-to-release-4.13
May 6, 2023
Merged

[release-4.13] OCPBUGS-13157: Deflake TestRouterCompressionOperation#926
openshift-merge-robot merged 1 commit intoopenshift:release-4.13from
openshift-cherrypick-robot:cherry-pick-920-to-release-4.13

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented May 5, 2023

This is an automated cherry-pick of #920

/assign gcs278

@gcs278
OCPBUGS-12913: Deflake TestRouterCompressionOperation
7015b26 
Wait for old router pods to be cleaned up before proceeding with testing
compression.

- `test/e2e/router_compression_test.go`: Use
waitForDeploymentCompleteWithOldPodTermination
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 5, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 5, 2023

@openshift-cherrypick-robot: Jira Issue OCPBUGS-12913 has been cloned as Jira Issue OCPBUGS-13157. Will retitle bug to link to clone.
/retitle [release-4.13] OCPBUGS-13157: Deflake TestRouterCompressionOperation

Details

In response to this:

This is an automated cherry-pick of #920

/assign gcs278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.13] OCPBUGS-12913: Deflake TestRouterCompressionOperation [release-4.13] OCPBUGS-13157: Deflake TestRouterCompressionOperation May 5, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 5, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 5, 2023

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-13157, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-12913 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-12913 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #920

/assign gcs278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.13] OCPBUGS-13157: Deflake TestRouterCompressionOperation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from frobware, lihongan and rfredette May 5, 2023 12:26
@gcs278 gcs278 mentioned this pull request May 5, 2023
Merged
@Miciah
Copy link
Contributor

Miciah commented May 5, 2023

This is a clean cherry-pick to fix a flaky test with no changes outside of the problematic E2E test itself.
/approve
/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 5, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2023
@melvinjoseph86
Copy link

melvinjoseph86 commented May 5, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 5, 2023
@gcs278
Copy link
Contributor

gcs278 commented May 5, 2023

/test verify

@gcs278
Copy link
Contributor

gcs278 commented May 5, 2023

/retest

@gcs278
Copy link
Contributor

gcs278 commented May 5, 2023

TestUnmanagedDNSToManagedDNSInternalIngressController failure
/test e2e-aws-operator

@gcs278
Copy link
Contributor

gcs278 commented May 5, 2023

TestIngressControllerRouteSelectorUpdateShouldClearRouteStatus: I've seen this once or twice before, but not related. TestUnmanagedDNSToManagedDNSInternalIngressController: Known
/retest-required

@knobunc knobunc added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label May 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 6, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7262c34 into openshift:release-4.13 May 6, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 6, 2023

@openshift-cherrypick-robot: Jira Issue OCPBUGS-13157: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13157 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #920

/assign gcs278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented May 10, 2023

Fix included in accepted release 4.13.0-0.nightly-2023-05-10-062807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lihongan lihongan Awaiting requested review from lihongan

@frobware frobware Awaiting requested review from frobware

@rfredette rfredette Awaiting requested review from rfredette

Assignees

@Miciah Miciah

@gcs278 gcs278

@lihongan lihongan

@melvinjoseph86 melvinjoseph86

@ShudiLi ShudiLi

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@openshift-cherrypick-robot @openshift-ci-robot @Miciah @melvinjoseph86 @gcs278 @openshift-merge-robot @knobunc @lihongan @ShudiLi